Cygwin gdb-20020411-1 HelpViewer does not display images

Cygwin gdb-20020411-1 HelpViewer does not display images

[Ton van Overbeek]

While trying to use the recently released Cygwin gdb I noticed that
the internal helpviewer does not display images. It shows
the 'broken image' on all places a gif is referenced.

The internal helpviewer uses the Scrolledhtml class.
Thic class inherits from the Scrolledtext class.
The Scrolledtext class has a public method called 'image'.
(this method did not exist in older gdb releases)
So all unqualified image commands in Scrolledhtml will use
Scrolledtext::image instead of the plain Tk image command.

Deleting the image method in Scrolledtext makes all the images
appear again in the helpviewer.
This is a 'quick & dirty' fix. The better approach (probably) is
to replace all reference to image in Scrolledhtml with ::image
to make the reference to the plain Tk image command explicit.

So, itcl/itk gurus, what is the 'correct' fix to this problem ?
I am happy to submit a patch either way.
Waiting for feedback.

Ton van Overbeek

Re: Cygwin gdb-20020411-1 HelpViewer does not display images

[Keith Seitz]

On Wed, 17 Apr 2002, Ton van Overbeek wrote:

> While trying to use the recently released Cygwin gdb I noticed that
> the internal helpviewer does not display images. It shows
> the 'broken image' on all places a gif is referenced.

Ugh. Yes, I've been meaning to get to that...

> The internal helpviewer uses the Scrolledhtml class.
> Thic class inherits from the Scrolledtext class.
> The Scrolledtext class has a public method called 'image'.
> (this method did not exist in older gdb releases)
> So all unqualified image commands in Scrolledhtml will use
> Scrolledtext::image instead of the plain Tk image command.

Aha! Wow, am I glad someone tracked this down! Yes, you are right: the
correct way of dealing with this is specifying a namespace/scope for the
image command used in Scrolledhtml, "::image".

Keith

Re: Cygwin gdb-20020411-1 HelpViewer does not display images

[Keith Seitz]

On Wed, 17 Apr 2002 tvoverbe@cistron.nl wrote:

> Do you still want me to supply a patch, or will you do it
> yourself, since it is rather trivial?

I can definitely churn one out quickly enough, now that you've pointed it
out.

Thanks a bunch!
Keith

Re: Cygwin gdb-20020411-1 HelpViewer does not display images

[tvoverbe]

> On Wed, 17 Apr 2002, Ton van Overbeek wrote:
> 
> > While trying to use the recently released Cygwin gdb I noticed that
> > the internal helpviewer does not display images. It shows
> > the 'broken image' on all places a gif is referenced.
> 
> Ugh. Yes, I've been meaning to get to that...
> 
> > The internal helpviewer uses the Scrolledhtml class.
> > Thic class inherits from the Scrolledtext class.
> > The Scrolledtext class has a public method called 'image'.
> > (this method did not exist in older gdb releases)
> > So all unqualified image commands in Scrolledhtml will use
> > Scrolledtext::image instead of the plain Tk image command.
> 
> Aha! Wow, am I glad someone tracked this down! Yes, you are right: the
> correct way of dealing with this is specifying a namespace/scope for the
> image command used in Scrolledhtml, "::image".
> 

In the meantime I checked the itcl/itk/iwidgets CVS at
sourceforge, and indeed from iwidgets 4.0.0 onward all
references to image in Scrolledhtml are now "::image".

Do you still want me to supply a patch, or will you do it
yourself, since it is rather trivial?

Ton