From: Keith Seitz <keiths@redhat.com>
To: Insight Maling List <insight@sources.redhat.com>
Subject: [PATCH] Remove "-modal" option to tk_messageBox
Date: Wed, 31 Jul 2002 18:22:00 -0000 [thread overview]
Message-ID: <Pine.GSO.4.33.0207311819110.12925-100000@makita.cygnus.com> (raw)
Hi,
I've checked in the patch below, which removes all the references to the
tk_messageBox option "-modal", which was a redhat-local change to our
version of Tk8.0. Like many of our font changes, this change was never
accepted or maybe even submitted to the Tk folks, and it has disappeared
with the latest import of the current Tk8.3 sources in cvs.
Keith
ChangeLog
2002-07-31 Keith Seitz <keiths@redhat.com>
* library/browserwin.itb (_full_funcs_combo): Remove "-modal"
option from tk_messageBox call. It was redhat-local in tk8.0,
but is no longer in tk8.3.
* library/download.itb (download_it): Likewise.
* library/interface.tcl (gdbtk_tcl_query): Likewise.
(show_warning): Likewise.
(set_exe): Likewise.
(set_target): Likewise.
* library/memwin.itb (error_dialog): Likewise.
* library/srcwin.itb (fillFuncCB): Likewise.
* library/util.tcl (tfind_cmd): Likewise.
Patch
Index: library//browserwin.itb
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/library/browserwin.itb,v
retrieving revision 1.5
diff -p -r1.5 browserwin.itb
*** library//browserwin.itb 7 Jun 2002 09:22:44 -0000 1.5
--- library//browserwin.itb 1 Aug 2002 01:17:11 -0000
*************** body BrowserWin::_fill_funcs_combo {name
*** 900,906 ****
set maxlen 10
if {[catch {gdb_listfuncs $name} listfuncs]} {
tk_messageBox -icon error -default ok \
! -title "GDB" -type ok -modal system \
-message "This file can not be found or does not contain\ndebugging information."
return
}
--- 900,906 ----
set maxlen 10
if {[catch {gdb_listfuncs $name} listfuncs]} {
tk_messageBox -icon error -default ok \
! -title "GDB" -type ok \
-message "This file can not be found or does not contain\ndebugging information."
return
}
Index: library//download.itb
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/library/download.itb,v
retrieving revision 1.7
diff -p -r1.7 download.itb
*** library//download.itb 5 Apr 2002 02:16:22 -0000 1.7
--- library//download.itb 1 Aug 2002 01:17:11 -0000
*************** body Download::download_it { } {
*** 194,200 ****
set f $gdb_exe_name
}
if {! [file exists $f]} {
! tk_messageBox -icon error -title GDB -type ok -modal task\
-message "Request to download non-existent executable $gdb_exe_name"
set gdb_downloading 0
gdbtk_idle
--- 194,200 ----
set f $gdb_exe_name
}
if {! [file exists $f]} {
! tk_messageBox -icon error -title GDB -type ok \
-message "Request to download non-existent executable $gdb_exe_name"
set gdb_downloading 0
gdbtk_idle
Index: library//interface.tcl
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/library/interface.tcl,v
retrieving revision 1.43
diff -p -r1.43 interface.tcl
*** library//interface.tcl 26 Apr 2002 21:09:54 -0000 1.43
--- library//interface.tcl 1 Aug 2002 01:17:11 -0000
*************** proc gdbtk_tcl_query {message {default y
*** 346,352 ****
# question.
set r [tk_messageBox -icon warning -default $default \
-message $message -title $title \
! -type yesno -modal $modal -parent .]
}
update idletasks
--- 346,352 ----
# question.
set r [tk_messageBox -icon warning -default $default \
-message $message -title $title \
! -type yesno -parent .]
}
update idletasks
*************** proc show_warning {message} {
*** 398,404 ****
} else {
set r [tk_messageBox -icon warning -default ok \
-message $message -title $title \
! -type ok -modal $modal -parent .]
}
}
--- 398,404 ----
} else {
set r [tk_messageBox -icon warning -default ok \
-message $message -title $title \
! -type ok -parent .]
}
}
*************** proc set_exe {} {
*** 877,883 ****
return
} elseif {[string match {*no debugging symbols found*} $msg]} {
tk_messageBox -icon error -default ok \
! -title "GDB" -type ok -modal system \
-message "This executable has no debugging information."
}
--- 877,883 ----
return
} elseif {[string match {*no debugging symbols found*} $msg]} {
tk_messageBox -icon error -default ok \
! -title "GDB" -type ok \
-message "This executable has no debugging information."
}
*************** proc set_target {} {
*** 1110,1116 ****
set dialog_title "GDB"
set debugger_name "GDB"
tk_messageBox -icon error -title $dialog_title -type ok \
! -modal task -message "$msg\n\n$debugger_name cannot connect to the target board\
using [lindex $gdb_target_cmd 1].\nVerify that the board is securely connected and, if\
necessary,\nmodify the port setting with the debugger preferences."
return ERROR
--- 1110,1116 ----
set dialog_title "GDB"
set debugger_name "GDB"
tk_messageBox -icon error -title $dialog_title -type ok \
! -message "$msg\n\n$debugger_name cannot connect to the target board\
using [lindex $gdb_target_cmd 1].\nVerify that the board is securely connected and, if\
necessary,\nmodify the port setting with the debugger preferences."
return ERROR
Index: library//memwin.itb
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/library/memwin.itb,v
retrieving revision 1.18
diff -p -r1.18 memwin.itb
*** library//memwin.itb 7 Jun 2002 09:22:44 -0000 1.18
--- library//memwin.itb 1 Aug 2002 01:17:11 -0000
*************** body MemWin::memMoveCell {w x y} {
*** 769,774 ****
body MemWin::error_dialog {msg {modality task} {type ok}} {
set parent [winfo toplevel [namespace tail $this]]
tk_messageBox -icon error -title Error -type $type \
! -modal $modality -message $msg -parent $parent
}
--- 769,774 ----
body MemWin::error_dialog {msg {modality task} {type ok}} {
set parent [winfo toplevel [namespace tail $this]]
tk_messageBox -icon error -title Error -type $type \
! -message $msg -parent $parent
}
Index: library//srcwin.itb
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/library/srcwin.itb,v
retrieving revision 1.24
diff -p -r1.24 srcwin.itb
*** library//srcwin.itb 6 Mar 2002 20:42:44 -0000 1.24
--- library//srcwin.itb 1 Aug 2002 01:17:12 -0000
*************** body SrcWin::fillFuncCB {name} {
*** 388,394 ****
set maxlen 10
if {[catch {gdb_listfuncs $name} listfuncs]} {
tk_messageBox -icon error -default ok \
! -title "GDB" -type ok -modal system \
-message "This file can not be found or does not contain\ndebugging information."
_set_name ""
return
--- 388,394 ----
set maxlen 10
if {[catch {gdb_listfuncs $name} listfuncs]} {
tk_messageBox -icon error -default ok \
! -title "GDB" -type ok \
-message "This file can not be found or does not contain\ndebugging information."
_set_name ""
return
Index: library//util.tcl
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/library/util.tcl,v
retrieving revision 1.10
diff -p -r1.10 util.tcl
*** library//util.tcl 19 Nov 2001 18:43:19 -0000 1.10
--- library//util.tcl 1 Aug 2002 01:17:12 -0000
*************** proc tfind_cmd {command} {
*** 79,85 ****
set err [catch {gdb_cmd $command} msg]
if {$err || [regexp "Target failed to find requested trace frame" $msg]} {
tk_messageBox -icon error -title "GDB" -type ok \
! -modal task -message $msg
gdbtk_idle
return
} else {
--- 79,85 ----
set err [catch {gdb_cmd $command} msg]
if {$err || [regexp "Target failed to find requested trace frame" $msg]} {
tk_messageBox -icon error -title "GDB" -type ok \
! -message $msg
gdbtk_idle
return
} else {
reply other threads:[~2002-08-01 1:22 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.GSO.4.33.0207311819110.12925-100000@makita.cygnus.com \
--to=keiths@redhat.com \
--cc=insight@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).