From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <insight-return-3667-listarch-insight=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 13627 invoked by alias); 13 Sep 2002 14:44:43 -0000
Mailing-List: contact insight-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:insight-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/insight/>
List-Post: <mailto:insight@sources.redhat.com>
List-Help: <mailto:insight-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: insight-owner@sources.redhat.com
Received: (qmail 13620 invoked from network); 13 Sep 2002 14:44:42 -0000
Received: from unknown (HELO valrhona.uglyboxes.com) (64.1.192.220)
  by sources.redhat.com with SMTP; 13 Sep 2002 14:44:42 -0000
Received: from localhost.localdomain (IDENT:gsYMICIaDDeohF2hs7Rl8qHDhgDJkmNx@localhost.localdomain [127.0.0.1])
	by valrhona.uglyboxes.com (8.11.6/8.11.6) with ESMTP id g8DElOA01822;
	Fri, 13 Sep 2002 07:47:24 -0700
Date: Fri, 13 Sep 2002 07:44:00 -0000
From: Keith Seitz <keiths@redhat.com>
X-X-Sender: keiths@valrhona.uglyboxes.com
To: Mo DeJong <supermo@bayarea.net>
cc: Insight <insight@sources.redhat.com>
Subject: Re: Patch to avoid using mkfifo under Cygwin
In-Reply-To: <20020912155153.5df1e557.supermo@bayarea.net>
Message-ID: <Pine.LNX.4.44.0209130746340.1407-100000@valrhona.uglyboxes.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
X-SW-Source: 2002-q3/txt/msg00154.txt.bz2

On Thu, 12 Sep 2002, Mo DeJong wrote:

> Here is a patch that avoids calling mkfifo under Cygwin since
> it is not functional.

Ok, so given cgf's latest comments, do we want to hold off on this or 
revert it when the cygwin work is ready? Maybe we can write an autoconf 
test for it?

Keith

> 2002-09-12  Mo DeJong  <supermo@bayarea.net>
> 
> 	* unix/tclUnixFCmd.c (DoCopyFile): Don't use mkfifo
> 	when compiling with Cygwin, since it is not supported.
> 
> Index: unix/tclUnixFCmd.c
> ===================================================================
> RCS file: /cvs/src/src/tcl/unix/tclUnixFCmd.c,v
> retrieving revision 1.2
> diff -u -r1.2 tclUnixFCmd.c
> --- unix/tclUnixFCmd.c	9 Sep 2001 23:56:09 -0000	1.2
> +++ unix/tclUnixFCmd.c	12 Sep 2002 22:37:10 -0000
> @@ -391,12 +391,18 @@
>  	    }
>  	    return CopyFileAtts(src, dst, &srcStatBuf);
>  	}
> +#ifndef __CYGWIN__
> +        /*
> +         * mkfifo is not supported under Cygwin even though it is prototyped
> +         * in newlib headers.
> +         */
>          case S_IFIFO: {
>  	    if (mkfifo(dst, srcStatBuf.st_mode) < 0) {	/* INTL: Native. */
>  		return TCL_ERROR;
>  	    }
>  	    return CopyFileAtts(src, dst, &srcStatBuf);
>  	}
> +#endif /* __CYGWIN__ */
>          default: {
>  	    return CopyFile(src, dst, &srcStatBuf);
>  	}
>