From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <insight-return-3875-listarch-insight=sources.redhat.com@sources.redhat.com>
Received: (qmail 1578 invoked by alias); 4 Dec 2002 16:20:54 -0000
Mailing-List: contact insight-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:insight-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/insight/>
List-Post: <mailto:insight@sources.redhat.com>
List-Help: <mailto:insight-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: insight-owner@sources.redhat.com
Received: (qmail 1571 invoked from network); 4 Dec 2002 16:20:52 -0000
Received: from unknown (HELO mx1.redhat.com) (66.187.233.31)
  by sources.redhat.com with SMTP; 4 Dec 2002 16:20:52 -0000
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254])
	by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id gB4FtnP14985
	for <insight@sources.redhat.com>; Wed, 4 Dec 2002 10:55:49 -0500
Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156])
	by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id gB4GKqD29831;
	Wed, 4 Dec 2002 11:20:52 -0500
Received: from valrhona.uglyboxes.com (IDENT:n2Kz8Lhnl/hDEaU1G59xvZGkB/gC3cJI@vpn50-33.rdu.redhat.com [172.16.50.33])
	by pobox.corp.redhat.com (8.11.6/8.11.6) with ESMTP id gB4GKp900834;
	Wed, 4 Dec 2002 11:20:51 -0500
Date: Wed, 04 Dec 2002 08:20:00 -0000
From: Keith Seitz <keiths@redhat.com>
X-X-Sender: keiths@valrhona.uglyboxes.com
To: Andrew Cagney <ac131313@redhat.com>
cc: insight@sources.redhat.com
Subject: [PATCH] Re: Insight -Werrors
In-Reply-To: <3DE91483.1020704@redhat.com>
Message-ID: <Pine.LNX.4.44.0212040817560.1506-100000@valrhona.uglyboxes.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
X-SW-Source: 2002-q4/txt/msg00159.txt.bz2

On Sat, 30 Nov 2002, Andrew Cagney wrote:

> gdbtk-cmds.c:1600: warning: implicit declaration of function 
> `Tk_NameToWindow'
> gdbtk-cmds.c:1601: warning: implicit declaration of function `Tk_MainWindow'
> 
> gdbtk-hooks.c:392: warning: implicit declaration of function `Tk_MainLoop'
> 
> when building configured with --enable-gdb-build-warnings=,-Werror 
> (which, for GDB, is pretty much the norm).

I checked in the following patches which correct these problems.

Thanks for the pointer.

Keith

ChangeLog
2002-12-04  Keith Seitz  <keiths@redhat.com>

        * generic/gdbtk-hooks.c: Include tcl.h and tk.h to pull
        in declarations for some Tk functions used in this file.
        * generic/gdbtk-cmds.c: Likewise.


Patch
Index: generic/gdbtk-cmds.c
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk-cmds.c,v
retrieving revision 1.63
diff -p -r1.63 gdbtk-cmds.c
*** generic/gdbtk-cmds.c	30 Nov 2002 17:49:21 -0000	1.63
--- generic/gdbtk-cmds.c	4 Dec 2002 16:20:36 -0000
***************
*** 40,45 ****
--- 40,47 ----
  #define HAS_STDARG 1
  
  #include <itcl.h>
+ #include <tcl.h>
+ #include <tk.h>
  
  #include "guitcl.h"
  #include "gdbtk.h"
Index: generic/gdbtk-hooks.c
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk-hooks.c,v
retrieving revision 1.28
diff -p -r1.28 gdbtk-hooks.c
*** generic/gdbtk-hooks.c	27 Nov 2002 19:09:17 -0000	1.28
--- generic/gdbtk-hooks.c	4 Dec 2002 16:20:36 -0000
***************
*** 43,48 ****
--- 43,50 ----
  #define HAS_STDARG 1
  
  #include <itcl.h>
+ #include <tcl.h>
+ #include <tk.h>
  #include "guitcl.h"
  #include "gdbtk.h"