From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6013 invoked by alias); 10 May 2007 11:42:55 -0000 Received: (qmail 6005 invoked by uid 22791); 10 May 2007 11:42:54 -0000 X-Spam-Check-By: sourceware.org Received: from dmz.mips-uk.com (HELO dmz.mips-uk.com) (194.74.144.194) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 10 May 2007 11:42:50 +0000 Received: from internal-mx1 ([192.168.192.240] helo=ukservices1.mips.com) by dmz.mips-uk.com with esmtp (Exim 3.35 #1 (Debian)) id 1Hm72m-0004Fb-00; Thu, 10 May 2007 12:42:48 +0100 Received: from perivale.mips.com ([192.168.192.200]) by ukservices1.mips.com with esmtp (Exim 3.36 #1 (Debian)) id 1Hm72d-0004RC-00; Thu, 10 May 2007 12:42:39 +0100 Received: from macro (helo=localhost) by perivale.mips.com with local-esmtp (Exim 4.63) (envelope-from ) id 1Hm72d-0000Ih-BD; Thu, 10 May 2007 12:42:39 +0100 Date: Thu, 10 May 2007 11:42:00 -0000 From: "Maciej W. Rozycki" To: insight@sourceware.org cc: Christopher Faylor , "Maciej W. Rozycki" Subject: [patch] Only use CW_SYNC_WINENV for Cygwin 1.15.20+ Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-MIPS-Technologies-UK-MailScanner: Found to be clean X-MIPS-Technologies-UK-MailScanner-From: macro@mips.com Mailing-List: contact insight-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: insight-owner@sourceware.org X-SW-Source: 2007-q2/txt/msg00030.txt.bz2 Hello, This change: 2006-11-30 Christopher Faylor * win/tclWinPipe.c (TclpCreateProcess): Call cygwin-specific routine to set up windows environment. broke building on versions of Cygwin predating 1.15.20. The CW_SYNC_WINENV internal call was not previously available. Here is a fix. 2007-05-10 Maciej W. Rozycki * win/tclWinPipe.c (TclpCreateProcess): Only use CW_SYNC_WINENV for Cygwin 1.15.20+. OK to apply? Maciej tcl_cw_sync_winenv.diff Index: binutils-quilt/src/tcl/win/tclWinPipe.c =================================================================== --- binutils-quilt.orig/src/tcl/win/tclWinPipe.c 2006-12-01 13:31:17.000000000 +0000 +++ binutils-quilt/src/tcl/win/tclWinPipe.c 2007-05-10 12:10:25.000000000 +0100 @@ -1228,7 +1228,8 @@ BuildCommandLine(execPath, argc, argv, &cmdLine); -#ifdef __CYGWIN__ +#if defined(__CYGWIN__) && (CYGWIN_VERSION_API_MAJOR > 1 || CYGWIN_VERSION_API_MINOR >= 154) + /* Only available in Cygwin 1.15.20+. */ cygwin_internal (CW_SYNC_WINENV); #endif