From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13646 invoked by alias); 14 May 2007 13:49:31 -0000 Received: (qmail 13629 invoked by uid 22791); 14 May 2007 13:49:28 -0000 X-Spam-Check-By: sourceware.org Received: from dmz.mips-uk.com (HELO dmz.mips-uk.com) (194.74.144.194) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 14 May 2007 13:49:25 +0000 Received: from internal-mx1 ([192.168.192.240] helo=ukservices1.mips.com) by dmz.mips-uk.com with esmtp (Exim 3.35 #1 (Debian)) id 1HnavT-0007tL-00; Mon, 14 May 2007 14:49:23 +0100 Received: from perivale.mips.com ([192.168.192.200]) by ukservices1.mips.com with esmtp (Exim 3.36 #1 (Debian)) id 1HnavN-0007bN-00; Mon, 14 May 2007 14:49:17 +0100 Received: from macro (helo=localhost) by perivale.mips.com with local-esmtp (Exim 4.63) (envelope-from ) id 1HnavN-0005IN-CM; Mon, 14 May 2007 14:49:17 +0100 Date: Mon, 14 May 2007 13:49:00 -0000 From: "Maciej W. Rozycki" To: insight@sourceware.org cc: "Maciej W. Rozycki" Subject: Re: [patch] Only use CW_SYNC_WINENV for Cygwin 1.15.20+ In-Reply-To: <20070510152950.GA5528@ednor.casa.cgf.cx> Message-ID: References: <20070510152950.GA5528@ednor.casa.cgf.cx> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-MIPS-Technologies-UK-MailScanner: Found to be clean X-MIPS-Technologies-UK-MailScanner-From: macro@mips.com Mailing-List: contact insight-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: insight-owner@sourceware.org X-SW-Source: 2007-q2/txt/msg00032.txt.bz2 On Thu, 10 May 2007, Christopher Faylor wrote: > There is no such thing as Cygwin 1.15.20. I don't know exactly when this was > applied but I would just avoid referring to the exact version of Cygwin in the > ChangeLog. Hmm, your own words: http://www.cygwin.com/ml/cygwin/2006-07/msg00037.html Or do you mean the missing "-1" suffix? If so, then sorry -- this can certainly be rectified. I just copied the change including the comment from elsewhere as is. > >2007-05-10 Maciej W. Rozycki > > > > * win/tclWinPipe.c (TclpCreateProcess): Only use CW_SYNC_WINENV > > for Cygwin 1.15.20+. > > > > OK to apply? > > No, sorry. If you are going to be testing versions like this then please > use CYGWIN_VERSION_USER_API_VERSION_COMBINED. Well, no such macro as of 1.5.14, but it was introduced before CW_SYNC_WINENV (at CYGWIN_VERSION_API_MINOR == 147), so it would be OK. Except it's not going to guard against CW_SYNC_WINENV being undefined anyway (which is what I am addressing here) as it refers to a "user_data" structure variable, so it can only be used at the run time (the result is not a preprocessor constant). I could use something like: #if CYGWIN_VERSION_DLL_MAKE_COMBINED(CYGWIN_VERSION_API_MAJOR, \ CYGWIN_VERSION_API_MINOR) >= 154 if you prefer -- does it look better to you? It builds for me. Either is fine by my standards. And BTW, where is "user_data" declared? Certainly not in any header included from . Maciej