public inbox for insight@sourceware.org
 help / color / mirror / Atom feed
From: "Maciej W. Rozycki" <macro@mips.com>
To: insight@sourceware.org
Cc: "Maciej W. Rozycki" <macro@linux-mips.org>
Subject: Re: [patch] Only use CW_SYNC_WINENV for Cygwin 1.15.20+
Date: Mon, 14 May 2007 16:29:00 -0000	[thread overview]
Message-ID: <Pine.LNX.4.61.0705141611280.12457@perivale.mips.com> (raw)
In-Reply-To: <20070514150822.GA8230@ednor.casa.cgf.cx>

On Mon, 14 May 2007, Christopher Faylor wrote:

> You're quoting a message from me which does not mention 1.15.20.  It is
> 1.*5*.20.
> 
> There is no reason to argue about this when a simple removal of the 
> version is all that I'm asking for.  Changing the "for Cygwin 
> 1.15.20(sic)+" to "when it is supported by the compilation environment" 
> would be sufficient.

 Well, that's a typo that I've kept missing -- sorry for the confusion.  
Here's an updated version.

2007-05-14  Maciej W. Rozycki  <macro@mips.com>

	* win/tclWinPipe.c (TclpCreateProcess): Only use CW_SYNC_WINENV
	if supported by the compilation environment.

 OK to apply?

  Maciej

tcl_cw_sync_winenv.diff
Index: binutils-quilt/src/tcl/win/tclWinPipe.c
===================================================================
--- binutils-quilt.orig/src/tcl/win/tclWinPipe.c	2007-05-14 16:16:44.000000000 +0100
+++ binutils-quilt/src/tcl/win/tclWinPipe.c	2007-05-14 16:18:41.000000000 +0100
@@ -1228,7 +1228,9 @@
 
     BuildCommandLine(execPath, argc, argv, &cmdLine);
 
-#ifdef __CYGWIN__
+#if defined(__CYGWIN__) && \
+    (CYGWIN_VERSION_API_MAJOR > 0 || CYGWIN_VERSION_API_MINOR >= 154)
+    /* Only available in Cygwin 1.5.20+. */
     cygwin_internal (CW_SYNC_WINENV);
 #endif
 

  reply	other threads:[~2007-05-14 16:29 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-10 11:42 Maciej W. Rozycki
2007-05-10 15:29 ` Christopher Faylor
2007-05-14 13:49   ` Maciej W. Rozycki
2007-05-14 15:08     ` Christopher Faylor
2007-05-14 16:29       ` Maciej W. Rozycki [this message]
2007-05-14 16:54         ` Christopher Faylor
2007-05-14 16:58           ` Keith Seitz
2007-05-14 17:13             ` Christopher Faylor
2007-05-14 17:24       ` Dave Korn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.61.0705141611280.12457@perivale.mips.com \
    --to=macro@mips.com \
    --cc=insight@sourceware.org \
    --cc=macro@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).