From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9027 invoked by alias); 14 May 2007 16:29:09 -0000 Received: (qmail 9018 invoked by uid 22791); 14 May 2007 16:29:08 -0000 X-Spam-Check-By: sourceware.org Received: from dmz.mips-uk.com (HELO dmz.mips-uk.com) (194.74.144.194) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 14 May 2007 16:29:05 +0000 Received: from internal-mx1 ([192.168.192.240] helo=ukservices1.mips.com) by dmz.mips-uk.com with esmtp (Exim 3.35 #1 (Debian)) id 1HndPz-0006iV-00; Mon, 14 May 2007 17:29:03 +0100 Received: from perivale.mips.com ([192.168.192.200]) by ukservices1.mips.com with esmtp (Exim 3.36 #1 (Debian)) id 1HndPw-0000vn-00; Mon, 14 May 2007 17:29:00 +0100 Received: from macro (helo=localhost) by perivale.mips.com with local-esmtp (Exim 4.63) (envelope-from ) id 1HndPw-0006nk-2z; Mon, 14 May 2007 17:29:00 +0100 Date: Mon, 14 May 2007 16:29:00 -0000 From: "Maciej W. Rozycki" To: insight@sourceware.org cc: "Maciej W. Rozycki" Subject: Re: [patch] Only use CW_SYNC_WINENV for Cygwin 1.15.20+ In-Reply-To: <20070514150822.GA8230@ednor.casa.cgf.cx> Message-ID: References: <20070510152950.GA5528@ednor.casa.cgf.cx> <20070514150822.GA8230@ednor.casa.cgf.cx> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-MIPS-Technologies-UK-MailScanner: Found to be clean X-MIPS-Technologies-UK-MailScanner-From: macro@mips.com Mailing-List: contact insight-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: insight-owner@sourceware.org X-SW-Source: 2007-q2/txt/msg00034.txt.bz2 On Mon, 14 May 2007, Christopher Faylor wrote: > You're quoting a message from me which does not mention 1.15.20. It is > 1.*5*.20. > > There is no reason to argue about this when a simple removal of the > version is all that I'm asking for. Changing the "for Cygwin > 1.15.20(sic)+" to "when it is supported by the compilation environment" > would be sufficient. Well, that's a typo that I've kept missing -- sorry for the confusion. Here's an updated version. 2007-05-14 Maciej W. Rozycki * win/tclWinPipe.c (TclpCreateProcess): Only use CW_SYNC_WINENV if supported by the compilation environment. OK to apply? Maciej tcl_cw_sync_winenv.diff Index: binutils-quilt/src/tcl/win/tclWinPipe.c =================================================================== --- binutils-quilt.orig/src/tcl/win/tclWinPipe.c 2007-05-14 16:16:44.000000000 +0100 +++ binutils-quilt/src/tcl/win/tclWinPipe.c 2007-05-14 16:18:41.000000000 +0100 @@ -1228,7 +1228,9 @@ BuildCommandLine(execPath, argc, argv, &cmdLine); -#ifdef __CYGWIN__ +#if defined(__CYGWIN__) && \ + (CYGWIN_VERSION_API_MAJOR > 0 || CYGWIN_VERSION_API_MINOR >= 154) + /* Only available in Cygwin 1.5.20+. */ cygwin_internal (CW_SYNC_WINENV); #endif