From: "Maciej W. Rozycki" <macro@mips.com>
To: insight@sourceware.org, gdb-patches@sourceware.org
Cc: Vladimir Prus <vladimir@codesourcery.com>,
"Maciej W. Rozycki" <macro@linux-mips.org>
Subject: generic/gdbtk-varobj.c: Adjust for varobj_list_children change
Date: Thu, 31 Jan 2008 13:34:00 -0000 [thread overview]
Message-ID: <Pine.LNX.4.61.0801301549310.3319@perivale.mips.com> (raw)
Hello,
Following recent changes to varobj.c this is a fix to make Insight build
again.
I have regression tested it with the gdb.gdbtk/*.exp subset of the test
suite, using the mipsisa32-sde-elf target with the
mips-sim-sde32/-EB/-march=mips32r2/-mips16 board and it actually saw an
improvement compared to the state from before the change to varobj.c:
-# of expected passes 457
-# of unexpected failures 28
+# of expected passes 517
+# of unexpected failures 30
2008-01-30 Maciej W. Rozycki <macro@mips.com>
* generic/gdbtk-varobj.c (variable_children): Adjust
for varobj_list_children change.
OK to apply?
Maciej
gdb-varobj_list_children.diff
Index: binutils-quilt/src/gdb/gdbtk/generic/gdbtk-varobj.c
===================================================================
--- binutils-quilt.orig/src/gdb/gdbtk/generic/gdbtk-varobj.c 2007-04-30 13:24:36.000000000 +0100
+++ binutils-quilt/src/gdb/gdbtk/generic/gdbtk-varobj.c 2008-01-30 15:34:19.000000000 +0000
@@ -413,26 +413,24 @@
variable_children (Tcl_Interp *interp, struct varobj *var)
{
Tcl_Obj *list;
- struct varobj **childlist;
- struct varobj **vc;
+ VEC(varobj_p) *children;
+ struct varobj *child;
char *childname;
+ int ix;
list = Tcl_NewListObj (0, NULL);
- varobj_list_children (var, &childlist);
+ children = varobj_list_children (var);
- vc = childlist;
- while (*vc != NULL)
+ for (ix = 0; VEC_iterate (varobj_p, children, ix, child); ++ix)
{
- childname = varobj_get_objname (*vc);
+ childname = varobj_get_objname (child);
/* Add child to result list and install the Tcl command for it. */
Tcl_ListObjAppendElement (NULL, list,
Tcl_NewStringObj (childname, -1));
install_variable (interp, childname);
- vc++;
}
- xfree (childlist);
return list;
}
next reply other threads:[~2008-01-31 13:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-31 13:34 Maciej W. Rozycki [this message]
2008-01-31 22:59 ` Daniel Jacobowitz
2008-02-06 19:42 ` Keith Seitz
2008-02-07 12:59 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.61.0801301549310.3319@perivale.mips.com \
--to=macro@mips.com \
--cc=gdb-patches@sourceware.org \
--cc=insight@sourceware.org \
--cc=macro@linux-mips.org \
--cc=vladimir@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).