From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6590 invoked by alias); 31 Jan 2008 13:34:21 -0000 Received: (qmail 6571 invoked by uid 22791); 31 Jan 2008 13:34:20 -0000 X-Spam-Check-By: sourceware.org Received: from dmz.mips-uk.com (HELO dmz.mips-uk.com) (194.74.144.194) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 31 Jan 2008 13:34:03 +0000 Received: from internal-mx1 ([192.168.192.240] helo=ukservices1.mips.com) by dmz.mips-uk.com with esmtp (Exim 3.35 #1 (Debian)) id 1JKZYG-0000nz-00; Thu, 31 Jan 2008 13:34:00 +0000 Received: from perivale.mips.com ([192.168.192.200]) by ukservices1.mips.com with esmtp (Exim 3.36 #1 (Debian)) id 1JKZYA-0005Ci-00; Thu, 31 Jan 2008 13:33:54 +0000 Received: from macro (helo=localhost) by perivale.mips.com with local-esmtp (Exim 4.63) (envelope-from ) id 1JKZYA-0001qX-Ef; Thu, 31 Jan 2008 13:33:54 +0000 Date: Thu, 31 Jan 2008 13:34:00 -0000 From: "Maciej W. Rozycki" To: insight@sourceware.org, gdb-patches@sourceware.org cc: Vladimir Prus , "Maciej W. Rozycki" Subject: generic/gdbtk-varobj.c: Adjust for varobj_list_children change Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII ReSent-Date: Thu, 31 Jan 2008 13:33:12 +0000 (GMT) ReSent-From: "Maciej W. Rozycki" ReSent-To: insight@sourceware.org, gdb-patches@sourceware.org ReSent-Subject: generic/gdbtk-varobj.c: Adjust for varobj_list_children change ReSent-Message-ID: X-MIPS-Technologies-UK-MailScanner: Found to be clean X-MIPS-Technologies-UK-MailScanner-From: macro@mips.com Mailing-List: contact insight-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: insight-owner@sourceware.org X-SW-Source: 2008-q1/txt/msg00004.txt.bz2 Hello, Following recent changes to varobj.c this is a fix to make Insight build again. I have regression tested it with the gdb.gdbtk/*.exp subset of the test suite, using the mipsisa32-sde-elf target with the mips-sim-sde32/-EB/-march=mips32r2/-mips16 board and it actually saw an improvement compared to the state from before the change to varobj.c: -# of expected passes 457 -# of unexpected failures 28 +# of expected passes 517 +# of unexpected failures 30 2008-01-30 Maciej W. Rozycki * generic/gdbtk-varobj.c (variable_children): Adjust for varobj_list_children change. OK to apply? Maciej gdb-varobj_list_children.diff Index: binutils-quilt/src/gdb/gdbtk/generic/gdbtk-varobj.c =================================================================== --- binutils-quilt.orig/src/gdb/gdbtk/generic/gdbtk-varobj.c 2007-04-30 13:24:36.000000000 +0100 +++ binutils-quilt/src/gdb/gdbtk/generic/gdbtk-varobj.c 2008-01-30 15:34:19.000000000 +0000 @@ -413,26 +413,24 @@ variable_children (Tcl_Interp *interp, struct varobj *var) { Tcl_Obj *list; - struct varobj **childlist; - struct varobj **vc; + VEC(varobj_p) *children; + struct varobj *child; char *childname; + int ix; list = Tcl_NewListObj (0, NULL); - varobj_list_children (var, &childlist); + children = varobj_list_children (var); - vc = childlist; - while (*vc != NULL) + for (ix = 0; VEC_iterate (varobj_p, children, ix, child); ++ix) { - childname = varobj_get_objname (*vc); + childname = varobj_get_objname (child); /* Add child to result list and install the Tcl command for it. */ Tcl_ListObjAppendElement (NULL, list, Tcl_NewStringObj (childname, -1)); install_variable (interp, childname); - vc++; } - xfree (childlist); return list; }