* INSTALL_DATA, ranlib, and tcl-related shared libraries
@ 2001-04-17 15:02 Phil Edwards
2001-04-17 16:02 ` Syd Polk
0 siblings, 1 reply; 7+ messages in thread
From: Phil Edwards @ 2001-04-17 15:02 UTC (permalink / raw)
To: insight
[please cc replies to my address also]
For a few months now I've been having to work around the same problem as
this guy did a year ago:
http://sources.redhat.com/ml/insight/1999-q3/msg00085.html
I submitted a patch (mistakenly to the gdb list), which was forwarded on
to the Insight list:
http://sources.redhat.com/ml/gdb/2001-01/msg00023.html
If Insight isn't going to be ported to Libtool anytime soon, could someone
consider applying this? An updated patch is appended. In my previous email
I said that this wasn't suitable for applying directly, but it works in
"most cases," and it's better than completely dying...
It contains an additional thinko fix; tixwish is mistakenly installed with
INSTALL_DATA, not INSTALL_PROGRAM, which means that its permissions lack
the execute bit. That fix should be done, at least.
Phil
Index: itcl/itcl/unix/Makefile.in
===================================================================
RCS file: /cvs/src/src/itcl/itcl/unix/Makefile.in,v
retrieving revision 1.1.1.1
diff -c -3 -r1.1.1.1 Makefile.in
*** Makefile.in 2000/02/07 00:19:46 1.1.1.1
--- Makefile.in 2001/04/17 01:00:36
***************
*** 193,199 ****
@ITCL_LIB_FILE@: $(OBJS)
rm -f $(ITCL_LIB_FILE)
@MAKE_LIB@
! $(RANLIB) $(ITCL_LIB_FILE)
itclsh: tclAppInit.o $(ITCL_LIB_FILE) @TCL_LIB_FULL_PATH@
$(CC) @LD_FLAGS@ tclAppInit.o @ITCL_BUILD_LIB_SPEC@ \
--- 193,199 ----
@ITCL_LIB_FILE@: $(OBJS)
rm -f $(ITCL_LIB_FILE)
@MAKE_LIB@
! case $(ITCL_LIB_FILE) in *.a) $(RANLIB) $(ITCL_LIB_FILE) ;; esac
itclsh: tclAppInit.o $(ITCL_LIB_FILE) @TCL_LIB_FULL_PATH@
$(CC) @LD_FLAGS@ tclAppInit.o @ITCL_BUILD_LIB_SPEC@ \
***************
*** 213,219 ****
@$(MKINSTALLDIRS) $(LIB_INSTALL_DIR) $(BIN_INSTALL_DIR)
@echo "Installing $(ITCL_LIB_FILE)"
@$(INSTALL_DATA) $(ITCL_LIB_FILE) $(LIB_INSTALL_DIR)/$(ITCL_LIB_FILE)
! @(cd $(LIB_INSTALL_DIR); $(RANLIB) $(ITCL_LIB_FILE))
chmod 555 $(LIB_INSTALL_DIR)/$(ITCL_LIB_FILE)
@echo "Installing itclsh"
$(INSTALL_PROGRAM) itclsh $(BIN_INSTALL_DIR)/itclsh$(VERSION)
--- 213,219 ----
@$(MKINSTALLDIRS) $(LIB_INSTALL_DIR) $(BIN_INSTALL_DIR)
@echo "Installing $(ITCL_LIB_FILE)"
@$(INSTALL_DATA) $(ITCL_LIB_FILE) $(LIB_INSTALL_DIR)/$(ITCL_LIB_FILE)
! @case $(ITCL_LIB_FILE) in *.a) (cd $(LIB_INSTALL_DIR); $(RANLIB) $(ITCL_LIB_FILE));; esac
chmod 555 $(LIB_INSTALL_DIR)/$(ITCL_LIB_FILE)
@echo "Installing itclsh"
$(INSTALL_PROGRAM) itclsh $(BIN_INSTALL_DIR)/itclsh$(VERSION)
Index: itcl/itk/unix/Makefile.in
===================================================================
RCS file: /cvs/src/src/itcl/itk/unix/Makefile.in,v
retrieving revision 1.1.1.1
diff -c -3 -r1.1.1.1 Makefile.in
*** Makefile.in 2000/02/07 00:19:46 1.1.1.1
--- Makefile.in 2001/04/17 01:00:36
***************
*** 226,232 ****
@ITK_LIB_FILE@: ${OBJS}
rm -f $(ITK_LIB_FILE)
@MAKE_LIB@
! $(RANLIB) $(ITK_LIB_FILE)
itkwish: tkAppInit.o $(ITK_LIB_FILE) @TCL_LIB_FULL_PATH@ @TK_LIB_FULL_PATH@ \
@ITCL_LIB_FULL_PATH@
--- 226,232 ----
@ITK_LIB_FILE@: ${OBJS}
rm -f $(ITK_LIB_FILE)
@MAKE_LIB@
! case $(ITK_LIB_FILE) in *.a) $(RANLIB) $(ITK_LIB_FILE) ;; esac
itkwish: tkAppInit.o $(ITK_LIB_FILE) @TCL_LIB_FULL_PATH@ @TK_LIB_FULL_PATH@ \
@ITCL_LIB_FULL_PATH@
***************
*** 253,259 ****
@$(MKINSTALLDIRS) $(LIB_INSTALL_DIR) $(BIN_INSTALL_DIR)
@echo "Installing $(ITK_LIB_FILE)"
@$(INSTALL_DATA) $(ITK_LIB_FILE) $(LIB_INSTALL_DIR)
! @(cd $(LIB_INSTALL_DIR); $(RANLIB) $(ITK_LIB_FILE))
@chmod 555 $(LIB_INSTALL_DIR)/$(ITK_LIB_FILE)
@echo "Installing itkwish"
$(INSTALL_PROGRAM) itkwish $(BIN_INSTALL_DIR)/itkwish$(VERSION)
--- 253,259 ----
@$(MKINSTALLDIRS) $(LIB_INSTALL_DIR) $(BIN_INSTALL_DIR)
@echo "Installing $(ITK_LIB_FILE)"
@$(INSTALL_DATA) $(ITK_LIB_FILE) $(LIB_INSTALL_DIR)
! @case $(ITK_LIB_FILE) in *.a) (cd $(LIB_INSTALL_DIR); $(RANLIB) $(ITK_LIB_FILE));; esac
@chmod 555 $(LIB_INSTALL_DIR)/$(ITK_LIB_FILE)
@echo "Installing itkwish"
$(INSTALL_PROGRAM) itkwish $(BIN_INSTALL_DIR)/itkwish$(VERSION)
Index: tcl/unix/Makefile.in
===================================================================
RCS file: /cvs/src/src/tcl/unix/Makefile.in,v
retrieving revision 1.1.1.1
diff -c -3 -r1.1.1.1 Makefile.in
*** Makefile.in 1999/11/09 01:28:44 1.1.1.1
--- Makefile.in 2001/04/17 01:00:36
***************
*** 449,455 ****
done;
@echo "Installing $(TCL_LIB_FILE)"
@$(INSTALL_DATA) $(TCL_LIB_FILE) $(LIB_INSTALL_DIR)/$(TCL_LIB_FILE)
! @(cd $(LIB_INSTALL_DIR); $(RANLIB) $(TCL_LIB_FILE))
@chmod 555 $(LIB_INSTALL_DIR)/$(TCL_LIB_FILE)
@echo "Installing tclsh"
@$(INSTALL_PROGRAM) tclsh $(BIN_INSTALL_DIR)/tclsh
--- 449,455 ----
done;
@echo "Installing $(TCL_LIB_FILE)"
@$(INSTALL_DATA) $(TCL_LIB_FILE) $(LIB_INSTALL_DIR)/$(TCL_LIB_FILE)
! @case $(TCL_LIB_FILE) in *.a) (cd $(LIB_INSTALL_DIR); $(RANLIB) $(TCL_LIB_FILE));; esac
@chmod 555 $(LIB_INSTALL_DIR)/$(TCL_LIB_FILE)
@echo "Installing tclsh"
@$(INSTALL_PROGRAM) tclsh $(BIN_INSTALL_DIR)/tclsh
Index: tix/unix/tk8.0/Makefile.in
===================================================================
RCS file: /cvs/src/src/tix/unix/tk8.0/Makefile.in,v
retrieving revision 1.1.1.1
diff -c -3 -r1.1.1.1 Makefile.in
*** Makefile.in 2000/02/07 00:19:29 1.1.1.1
--- Makefile.in 2001/04/17 01:00:36
***************
*** 67,73 ****
#
TCL_SRC_DIR = @TCL_SRC_DIR@
TCL_GENERIC_DIR = $(TCL_SRC_DIR)/generic
! TCL_BIN_DIR = @TCL_BIN_DIR@
# Location of the Tk 8.0 source directory.
#
--- 67,73 ----
#
TCL_SRC_DIR = @TCL_SRC_DIR@
TCL_GENERIC_DIR = $(TCL_SRC_DIR)/generic
! TCL_BIN_DIR=@TCLBINDIR_VARIABLE@
# Location of the Tk 8.0 source directory.
#
***************
*** 84,89 ****
--- 84,90 ----
RUN_TCLSH = TCL_LIBRARY=$(TCL_SRC_DIR)/library \
TK_LIBRARY=$(TK_SRC_DIR)/library \
+ LD_LIBRARY_PATH=$(TCL_BIN_DIR):${LD_LIBRARY_PATH} \
$(TCL_BIN_DIR)/tclsh
***************
*** 483,489 ****
@echo "Installing $(TIX_LIB_FILE) as $(LIB_DIR)/$(TIX_LIB_FILE)"
@$(INSTALL_DATA) $(TIX_LIB_FILE) $(LIB_DIR)/$(TIX_LIB_FILE)
@echo "Installing $(TIX_EXE_FILE) as $(BIN_DIR)/$(INST_EXE)"
! @$(INSTALL_DATA) $(TIX_EXE_FILE) $(BIN_DIR)/$(INST_EXE)
_install_sam_exe_: $(SAM_TARGETS)
@for i in $(LIB_DIR) $(BIN_DIR) ; \
--- 484,490 ----
@echo "Installing $(TIX_LIB_FILE) as $(LIB_DIR)/$(TIX_LIB_FILE)"
@$(INSTALL_DATA) $(TIX_LIB_FILE) $(LIB_DIR)/$(TIX_LIB_FILE)
@echo "Installing $(TIX_EXE_FILE) as $(BIN_DIR)/$(INST_EXE)"
! @$(INSTALL_PROGRAM) $(TIX_EXE_FILE) $(BIN_DIR)/$(INST_EXE)
_install_sam_exe_: $(SAM_TARGETS)
@for i in $(LIB_DIR) $(BIN_DIR) ; \
Index: tix/unix/tk8.0/configure.in
===================================================================
RCS file: /cvs/src/src/tix/unix/tk8.0/configure.in,v
retrieving revision 1.1.1.1
diff -c -3 -r1.1.1.1 configure.in
*** configure.in 2000/02/07 00:19:29 1.1.1.1
--- configure.in 2001/04/17 01:00:36
***************
*** 144,150 ****
# CYGNUS LOCAL: This used to get TCL_BIN_DIR from TCL_SRC_DIR, which
# only works when srcdir == objdir
! TCL_BIN_DIR=../../../tcl/unix
#--------------------------------------------------------------------
# See if there was a command-line option for where Tk is; if
--- 144,150 ----
# CYGNUS LOCAL: This used to get TCL_BIN_DIR from TCL_SRC_DIR, which
# only works when srcdir == objdir
! TCLBINDIR_VARIABLE=../../../tcl/unix
#--------------------------------------------------------------------
# See if there was a command-line option for where Tk is; if
***************
*** 221,227 ****
# Makefile.
#--------------------------------------------------------------------
! file=$TCL_BIN_DIR/tclConfig.sh
. $file
CC=$TCL_CC
SHLIB_CFLAGS=$TCL_SHLIB_CFLAGS
--- 221,227 ----
# Makefile.
#--------------------------------------------------------------------
! file=$TCLBINDIR_VARIABLE/tclConfig.sh
. $file
CC=$TCL_CC
SHLIB_CFLAGS=$TCL_SHLIB_CFLAGS
***************
*** 387,393 ****
AC_SUBST(TCL_LIBS)
AC_SUBST(TCL_VERSION)
AC_SUBST(TCL_SRC_DIR)
! AC_SUBST(TCL_BIN_DIR)
AC_SUBST(TCL_LIB_FULL_PATH)
AC_SUBST(TK_BUILD_LIB_SPEC)
AC_SUBST(TK_LIBS)
--- 387,393 ----
AC_SUBST(TCL_LIBS)
AC_SUBST(TCL_VERSION)
AC_SUBST(TCL_SRC_DIR)
! AC_SUBST(TCLBINDIR_VARIABLE)
AC_SUBST(TCL_LIB_FULL_PATH)
AC_SUBST(TK_BUILD_LIB_SPEC)
AC_SUBST(TK_LIBS)
Index: tk/unix/Makefile.in
===================================================================
RCS file: /cvs/src/src/tk/unix/Makefile.in,v
retrieving revision 1.1.1.1
diff -c -3 -r1.1.1.1 Makefile.in
*** Makefile.in 2000/02/07 00:19:30 1.1.1.1
--- Makefile.in 2001/04/17 01:00:36
***************
*** 386,392 ****
done;
@echo "Installing $(TK_LIB_FILE)"
@$(INSTALL_DATA) $(TK_LIB_FILE) $(LIB_INSTALL_DIR)/$(TK_LIB_FILE)
! @(cd $(LIB_INSTALL_DIR); $(RANLIB) $(TK_LIB_FILE))
@chmod 555 $(LIB_INSTALL_DIR)/$(TK_LIB_FILE)
@echo "Installing wish"
@$(INSTALL_PROGRAM) wish $(BIN_INSTALL_DIR)/wish
--- 386,392 ----
done;
@echo "Installing $(TK_LIB_FILE)"
@$(INSTALL_DATA) $(TK_LIB_FILE) $(LIB_INSTALL_DIR)/$(TK_LIB_FILE)
! @case $(TK_LIB_FILE) in *.a) (cd $(LIB_INSTALL_DIR); $(RANLIB) $(TK_LIB_FILE));; esac
@chmod 555 $(LIB_INSTALL_DIR)/$(TK_LIB_FILE)
@echo "Installing wish"
@$(INSTALL_PROGRAM) wish $(BIN_INSTALL_DIR)/wish
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: INSTALL_DATA, ranlib, and tcl-related shared libraries
2001-04-17 15:02 INSTALL_DATA, ranlib, and tcl-related shared libraries Phil Edwards
@ 2001-04-17 16:02 ` Syd Polk
2001-04-20 12:14 ` Keith Seitz
0 siblings, 1 reply; 7+ messages in thread
From: Syd Polk @ 2001-04-17 16:02 UTC (permalink / raw)
To: Phil Edwards, insight
I approve these changes. Fernando or Keith, can you check them in?
At 06:17 PM 4/17/01 -0400, Phil Edwards wrote:
>[please cc replies to my address also]
>
>For a few months now I've been having to work around the same problem as
>this guy did a year ago:
> http://sources.redhat.com/ml/insight/1999-q3/msg00085.html
>
>I submitted a patch (mistakenly to the gdb list), which was forwarded on
>to the Insight list:
> http://sources.redhat.com/ml/gdb/2001-01/msg00023.html
>
>If Insight isn't going to be ported to Libtool anytime soon, could someone
>consider applying this? An updated patch is appended. In my previous email
>I said that this wasn't suitable for applying directly, but it works in
>"most cases," and it's better than completely dying...
>
>
>It contains an additional thinko fix; tixwish is mistakenly installed with
>INSTALL_DATA, not INSTALL_PROGRAM, which means that its permissions lack
>the execute bit. That fix should be done, at least.
>
>
>Phil
>
>
>Index: itcl/itcl/unix/Makefile.in
>===================================================================
>RCS file: /cvs/src/src/itcl/itcl/unix/Makefile.in,v
>retrieving revision 1.1.1.1
>diff -c -3 -r1.1.1.1 Makefile.in
>*** Makefile.in 2000/02/07 00:19:46 1.1.1.1
>--- Makefile.in 2001/04/17 01:00:36
>***************
>*** 193,199 ****
> @ITCL_LIB_FILE@: $(OBJS)
> rm -f $(ITCL_LIB_FILE)
> @MAKE_LIB@
>! $(RANLIB) $(ITCL_LIB_FILE)
>
> itclsh: tclAppInit.o $(ITCL_LIB_FILE) @TCL_LIB_FULL_PATH@
> $(CC) @LD_FLAGS@ tclAppInit.o @ITCL_BUILD_LIB_SPEC@ \
>--- 193,199 ----
> @ITCL_LIB_FILE@: $(OBJS)
> rm -f $(ITCL_LIB_FILE)
> @MAKE_LIB@
>! case $(ITCL_LIB_FILE) in *.a) $(RANLIB) $(ITCL_LIB_FILE) ;; esac
>
> itclsh: tclAppInit.o $(ITCL_LIB_FILE) @TCL_LIB_FULL_PATH@
> $(CC) @LD_FLAGS@ tclAppInit.o @ITCL_BUILD_LIB_SPEC@ \
>***************
>*** 213,219 ****
> @$(MKINSTALLDIRS) $(LIB_INSTALL_DIR) $(BIN_INSTALL_DIR)
> @echo "Installing $(ITCL_LIB_FILE)"
> @$(INSTALL_DATA) $(ITCL_LIB_FILE) $(LIB_INSTALL_DIR)/$(ITCL_LIB_FILE)
>! @(cd $(LIB_INSTALL_DIR); $(RANLIB) $(ITCL_LIB_FILE))
> chmod 555 $(LIB_INSTALL_DIR)/$(ITCL_LIB_FILE)
> @echo "Installing itclsh"
> $(INSTALL_PROGRAM) itclsh $(BIN_INSTALL_DIR)/itclsh$(VERSION)
>--- 213,219 ----
> @$(MKINSTALLDIRS) $(LIB_INSTALL_DIR) $(BIN_INSTALL_DIR)
> @echo "Installing $(ITCL_LIB_FILE)"
> @$(INSTALL_DATA) $(ITCL_LIB_FILE) $(LIB_INSTALL_DIR)/$(ITCL_LIB_FILE)
>! @case $(ITCL_LIB_FILE) in *.a) (cd $(LIB_INSTALL_DIR); $(RANLIB)
>$(ITCL_LIB_FILE));; esac
> chmod 555 $(LIB_INSTALL_DIR)/$(ITCL_LIB_FILE)
> @echo "Installing itclsh"
> $(INSTALL_PROGRAM) itclsh $(BIN_INSTALL_DIR)/itclsh$(VERSION)
>Index: itcl/itk/unix/Makefile.in
>===================================================================
>RCS file: /cvs/src/src/itcl/itk/unix/Makefile.in,v
>retrieving revision 1.1.1.1
>diff -c -3 -r1.1.1.1 Makefile.in
>*** Makefile.in 2000/02/07 00:19:46 1.1.1.1
>--- Makefile.in 2001/04/17 01:00:36
>***************
>*** 226,232 ****
> @ITK_LIB_FILE@: ${OBJS}
> rm -f $(ITK_LIB_FILE)
> @MAKE_LIB@
>! $(RANLIB) $(ITK_LIB_FILE)
>
> itkwish: tkAppInit.o $(ITK_LIB_FILE) @TCL_LIB_FULL_PATH@
> @TK_LIB_FULL_PATH@ \
> @ITCL_LIB_FULL_PATH@
>--- 226,232 ----
> @ITK_LIB_FILE@: ${OBJS}
> rm -f $(ITK_LIB_FILE)
> @MAKE_LIB@
>! case $(ITK_LIB_FILE) in *.a) $(RANLIB) $(ITK_LIB_FILE) ;; esac
>
> itkwish: tkAppInit.o $(ITK_LIB_FILE) @TCL_LIB_FULL_PATH@
> @TK_LIB_FULL_PATH@ \
> @ITCL_LIB_FULL_PATH@
>***************
>*** 253,259 ****
> @$(MKINSTALLDIRS) $(LIB_INSTALL_DIR) $(BIN_INSTALL_DIR)
> @echo "Installing $(ITK_LIB_FILE)"
> @$(INSTALL_DATA) $(ITK_LIB_FILE) $(LIB_INSTALL_DIR)
>! @(cd $(LIB_INSTALL_DIR); $(RANLIB) $(ITK_LIB_FILE))
> @chmod 555 $(LIB_INSTALL_DIR)/$(ITK_LIB_FILE)
> @echo "Installing itkwish"
> $(INSTALL_PROGRAM) itkwish $(BIN_INSTALL_DIR)/itkwish$(VERSION)
>--- 253,259 ----
> @$(MKINSTALLDIRS) $(LIB_INSTALL_DIR) $(BIN_INSTALL_DIR)
> @echo "Installing $(ITK_LIB_FILE)"
> @$(INSTALL_DATA) $(ITK_LIB_FILE) $(LIB_INSTALL_DIR)
>! @case $(ITK_LIB_FILE) in *.a) (cd $(LIB_INSTALL_DIR); $(RANLIB)
>$(ITK_LIB_FILE));; esac
> @chmod 555 $(LIB_INSTALL_DIR)/$(ITK_LIB_FILE)
> @echo "Installing itkwish"
> $(INSTALL_PROGRAM) itkwish $(BIN_INSTALL_DIR)/itkwish$(VERSION)
>Index: tcl/unix/Makefile.in
>===================================================================
>RCS file: /cvs/src/src/tcl/unix/Makefile.in,v
>retrieving revision 1.1.1.1
>diff -c -3 -r1.1.1.1 Makefile.in
>*** Makefile.in 1999/11/09 01:28:44 1.1.1.1
>--- Makefile.in 2001/04/17 01:00:36
>***************
>*** 449,455 ****
> done;
> @echo "Installing $(TCL_LIB_FILE)"
> @$(INSTALL_DATA) $(TCL_LIB_FILE) $(LIB_INSTALL_DIR)/$(TCL_LIB_FILE)
>! @(cd $(LIB_INSTALL_DIR); $(RANLIB) $(TCL_LIB_FILE))
> @chmod 555 $(LIB_INSTALL_DIR)/$(TCL_LIB_FILE)
> @echo "Installing tclsh"
> @$(INSTALL_PROGRAM) tclsh $(BIN_INSTALL_DIR)/tclsh
>--- 449,455 ----
> done;
> @echo "Installing $(TCL_LIB_FILE)"
> @$(INSTALL_DATA) $(TCL_LIB_FILE) $(LIB_INSTALL_DIR)/$(TCL_LIB_FILE)
>! @case $(TCL_LIB_FILE) in *.a) (cd $(LIB_INSTALL_DIR); $(RANLIB)
>$(TCL_LIB_FILE));; esac
> @chmod 555 $(LIB_INSTALL_DIR)/$(TCL_LIB_FILE)
> @echo "Installing tclsh"
> @$(INSTALL_PROGRAM) tclsh $(BIN_INSTALL_DIR)/tclsh
>Index: tix/unix/tk8.0/Makefile.in
>===================================================================
>RCS file: /cvs/src/src/tix/unix/tk8.0/Makefile.in,v
>retrieving revision 1.1.1.1
>diff -c -3 -r1.1.1.1 Makefile.in
>*** Makefile.in 2000/02/07 00:19:29 1.1.1.1
>--- Makefile.in 2001/04/17 01:00:36
>***************
>*** 67,73 ****
> #
> TCL_SRC_DIR = @TCL_SRC_DIR@
> TCL_GENERIC_DIR = $(TCL_SRC_DIR)/generic
>! TCL_BIN_DIR = @TCL_BIN_DIR@
>
> # Location of the Tk 8.0 source directory.
> #
>--- 67,73 ----
> #
> TCL_SRC_DIR = @TCL_SRC_DIR@
> TCL_GENERIC_DIR = $(TCL_SRC_DIR)/generic
>! TCL_BIN_DIR=@TCLBINDIR_VARIABLE@
>
> # Location of the Tk 8.0 source directory.
> #
>***************
>*** 84,89 ****
>--- 84,90 ----
>
> RUN_TCLSH = TCL_LIBRARY=$(TCL_SRC_DIR)/library \
> TK_LIBRARY=$(TK_SRC_DIR)/library \
>+ LD_LIBRARY_PATH=$(TCL_BIN_DIR):${LD_LIBRARY_PATH} \
> $(TCL_BIN_DIR)/tclsh
>
>
>***************
>*** 483,489 ****
> @echo "Installing $(TIX_LIB_FILE) as $(LIB_DIR)/$(TIX_LIB_FILE)"
> @$(INSTALL_DATA) $(TIX_LIB_FILE) $(LIB_DIR)/$(TIX_LIB_FILE)
> @echo "Installing $(TIX_EXE_FILE) as $(BIN_DIR)/$(INST_EXE)"
>! @$(INSTALL_DATA) $(TIX_EXE_FILE) $(BIN_DIR)/$(INST_EXE)
>
> _install_sam_exe_: $(SAM_TARGETS)
> @for i in $(LIB_DIR) $(BIN_DIR) ; \
>--- 484,490 ----
> @echo "Installing $(TIX_LIB_FILE) as $(LIB_DIR)/$(TIX_LIB_FILE)"
> @$(INSTALL_DATA) $(TIX_LIB_FILE) $(LIB_DIR)/$(TIX_LIB_FILE)
> @echo "Installing $(TIX_EXE_FILE) as $(BIN_DIR)/$(INST_EXE)"
>! @$(INSTALL_PROGRAM) $(TIX_EXE_FILE) $(BIN_DIR)/$(INST_EXE)
>
> _install_sam_exe_: $(SAM_TARGETS)
> @for i in $(LIB_DIR) $(BIN_DIR) ; \
>Index: tix/unix/tk8.0/configure.in
>===================================================================
>RCS file: /cvs/src/src/tix/unix/tk8.0/configure.in,v
>retrieving revision 1.1.1.1
>diff -c -3 -r1.1.1.1 configure.in
>*** configure.in 2000/02/07 00:19:29 1.1.1.1
>--- configure.in 2001/04/17 01:00:36
>***************
>*** 144,150 ****
>
> # CYGNUS LOCAL: This used to get TCL_BIN_DIR from TCL_SRC_DIR, which
> # only works when srcdir == objdir
>! TCL_BIN_DIR=../../../tcl/unix
>
> #--------------------------------------------------------------------
> # See if there was a command-line option for where Tk is; if
>--- 144,150 ----
>
> # CYGNUS LOCAL: This used to get TCL_BIN_DIR from TCL_SRC_DIR, which
> # only works when srcdir == objdir
>! TCLBINDIR_VARIABLE=../../../tcl/unix
>
> #--------------------------------------------------------------------
> # See if there was a command-line option for where Tk is; if
>***************
>*** 221,227 ****
> # Makefile.
> #--------------------------------------------------------------------
>
>! file=$TCL_BIN_DIR/tclConfig.sh
> . $file
> CC=$TCL_CC
> SHLIB_CFLAGS=$TCL_SHLIB_CFLAGS
>--- 221,227 ----
> # Makefile.
> #--------------------------------------------------------------------
>
>! file=$TCLBINDIR_VARIABLE/tclConfig.sh
> . $file
> CC=$TCL_CC
> SHLIB_CFLAGS=$TCL_SHLIB_CFLAGS
>***************
>*** 387,393 ****
> AC_SUBST(TCL_LIBS)
> AC_SUBST(TCL_VERSION)
> AC_SUBST(TCL_SRC_DIR)
>! AC_SUBST(TCL_BIN_DIR)
> AC_SUBST(TCL_LIB_FULL_PATH)
> AC_SUBST(TK_BUILD_LIB_SPEC)
> AC_SUBST(TK_LIBS)
>--- 387,393 ----
> AC_SUBST(TCL_LIBS)
> AC_SUBST(TCL_VERSION)
> AC_SUBST(TCL_SRC_DIR)
>! AC_SUBST(TCLBINDIR_VARIABLE)
> AC_SUBST(TCL_LIB_FULL_PATH)
> AC_SUBST(TK_BUILD_LIB_SPEC)
> AC_SUBST(TK_LIBS)
>Index: tk/unix/Makefile.in
>===================================================================
>RCS file: /cvs/src/src/tk/unix/Makefile.in,v
>retrieving revision 1.1.1.1
>diff -c -3 -r1.1.1.1 Makefile.in
>*** Makefile.in 2000/02/07 00:19:30 1.1.1.1
>--- Makefile.in 2001/04/17 01:00:36
>***************
>*** 386,392 ****
> done;
> @echo "Installing $(TK_LIB_FILE)"
> @$(INSTALL_DATA) $(TK_LIB_FILE) $(LIB_INSTALL_DIR)/$(TK_LIB_FILE)
>! @(cd $(LIB_INSTALL_DIR); $(RANLIB) $(TK_LIB_FILE))
> @chmod 555 $(LIB_INSTALL_DIR)/$(TK_LIB_FILE)
> @echo "Installing wish"
> @$(INSTALL_PROGRAM) wish $(BIN_INSTALL_DIR)/wish
>--- 386,392 ----
> done;
> @echo "Installing $(TK_LIB_FILE)"
> @$(INSTALL_DATA) $(TK_LIB_FILE) $(LIB_INSTALL_DIR)/$(TK_LIB_FILE)
>! @case $(TK_LIB_FILE) in *.a) (cd $(LIB_INSTALL_DIR); $(RANLIB)
>$(TK_LIB_FILE));; esac
> @chmod 555 $(LIB_INSTALL_DIR)/$(TK_LIB_FILE)
> @echo "Installing wish"
> @$(INSTALL_PROGRAM) wish $(BIN_INSTALL_DIR)/wish
Syd Polk spolk@redhat.com
Engineering Manager +1 408 543 9430
Red Hat, Inc.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: INSTALL_DATA, ranlib, and tcl-related shared libraries
2001-04-17 16:02 ` Syd Polk
@ 2001-04-20 12:14 ` Keith Seitz
2001-04-20 12:20 ` Mo DeJong
2001-04-20 13:37 ` Syd Polk
0 siblings, 2 replies; 7+ messages in thread
From: Keith Seitz @ 2001-04-20 12:14 UTC (permalink / raw)
To: Syd Polk; +Cc: Phil Edwards, insight
On Tue, 17 Apr 2001, Syd Polk wrote:
> I approve these changes. Fernando or Keith, can you check them in?
Ummm... May I make one small recommendation? :-)
The real reason this is failing to work is because the toplevel Makefile
is passing RANLIB down. This fails because our toolchains are,
historically, always built static, but someone always tries to change
them (until he runs into a sun4 or something).
Anyway, the easier fix is to just ignore what we're passed and take
whatever configure gives us.
Keith
Index: itcl/itcl/unix/Makefile.in
===================================================================
RCS file: /cvs/src/src/itcl/itcl/unix/Makefile.in,v
retrieving revision 1.1.1.1
diff -p -u -r1.1.1.1 Makefile.in
--- itcl/itcl/unix/Makefile.in 2000/02/07 00:19:46 1.1.1.1
+++ itcl/itcl/unix/Makefile.in 2001/04/20 19:09:39
@@ -149,7 +149,7 @@ SHLIB_LD = @SHLIB_LD@
#----------------------------------------------------------------
AC_FLAGS = @TCL_DEFS@
-RANLIB = @RANLIB@
+ITCL_RANLIB = @RANLIB@
TOP_DIR = @ITCL_SRC_DIR@
GENERIC_DIR = $(TOP_DIR)/generic
UNIX_DIR = $(TOP_DIR)/unix
@@ -193,7 +193,7 @@ all: $(ITCL_LIB_FILE) itclsh
@ITCL_LIB_FILE@: $(OBJS)
rm -f $(ITCL_LIB_FILE)
@MAKE_LIB@
- $(RANLIB) $(ITCL_LIB_FILE)
+ $(ITCL_RANLIB) $(ITCL_LIB_FILE)
itclsh: tclAppInit.o $(ITCL_LIB_FILE) @TCL_LIB_FULL_PATH@
$(CC) @LD_FLAGS@ tclAppInit.o @ITCL_BUILD_LIB_SPEC@ \
@@ -213,7 +213,7 @@ install-binaries: $(ITCL_LIB_FILE) itcls
@$(MKINSTALLDIRS) $(LIB_INSTALL_DIR) $(BIN_INSTALL_DIR)
@echo "Installing $(ITCL_LIB_FILE)"
@$(INSTALL_DATA) $(ITCL_LIB_FILE) $(LIB_INSTALL_DIR)/$(ITCL_LIB_FILE)
- @(cd $(LIB_INSTALL_DIR); $(RANLIB) $(ITCL_LIB_FILE))
+ @(cd $(LIB_INSTALL_DIR); $(ITCL_RANLIB) $(ITCL_LIB_FILE))
chmod 555 $(LIB_INSTALL_DIR)/$(ITCL_LIB_FILE)
@echo "Installing itclsh"
$(INSTALL_PROGRAM) itclsh $(BIN_INSTALL_DIR)/itclsh$(VERSION)
Index: itcl/itk/unix/Makefile.in
===================================================================
RCS file: /cvs/src/src/itcl/itk/unix/Makefile.in,v
retrieving revision 1.1.1.1
diff -p -u -r1.1.1.1 Makefile.in
--- itcl/itk/unix/Makefile.in 2000/02/07 00:19:46 1.1.1.1
+++ itcl/itk/unix/Makefile.in 2001/04/20 19:09:55
@@ -193,7 +193,7 @@ SHLIB_LD = @SHLIB_LD@
#----------------------------------------------------------------
AC_FLAGS = @TCL_DEFS@
-RANLIB = @RANLIB@
+ITK_RANLIB = @RANLIB@
TOP_DIR = @ITK_SRC_DIR@
GENERIC_DIR = $(TOP_DIR)/generic
UNIX_DIR = $(TOP_DIR)/unix
@@ -226,7 +226,7 @@ all: itkwish
@ITK_LIB_FILE@: ${OBJS}
rm -f $(ITK_LIB_FILE)
@MAKE_LIB@
- $(RANLIB) $(ITK_LIB_FILE)
+ $(ITK_RANLIB) $(ITK_LIB_FILE)
itkwish: tkAppInit.o $(ITK_LIB_FILE) @TCL_LIB_FULL_PATH@ @TK_LIB_FULL_PATH@ \
@ITCL_LIB_FULL_PATH@
@@ -253,7 +253,7 @@ install-binaries: $(ITK_LIB_FILE) itkwis
@$(MKINSTALLDIRS) $(LIB_INSTALL_DIR) $(BIN_INSTALL_DIR)
@echo "Installing $(ITK_LIB_FILE)"
@$(INSTALL_DATA) $(ITK_LIB_FILE) $(LIB_INSTALL_DIR)
- @(cd $(LIB_INSTALL_DIR); $(RANLIB) $(ITK_LIB_FILE))
+ @(cd $(LIB_INSTALL_DIR); $(ITK_RANLIB) $(ITK_LIB_FILE))
@chmod 555 $(LIB_INSTALL_DIR)/$(ITK_LIB_FILE)
@echo "Installing itkwish"
$(INSTALL_PROGRAM) itkwish $(BIN_INSTALL_DIR)/itkwish$(VERSION)
Index: tcl/unix/Makefile.in
===================================================================
RCS file: /cvs/src/src/tcl/unix/Makefile.in,v
retrieving revision 1.1.1.1
diff -p -u -r1.1.1.1 Makefile.in
--- tcl/unix/Makefile.in 1999/11/09 01:28:44 1.1.1.1
+++ tcl/unix/Makefile.in 2001/04/20 19:09:58
@@ -188,7 +188,7 @@ TCL_LIB_FLAG = @TCL_LIB_FLAG@
COMPAT_OBJS = @LIBOBJS@
AC_FLAGS = @DEFS@
-RANLIB = @RANLIB@
+TCL_RANLIB = @RANLIB@
SRC_DIR = @srcdir@
TOP_DIR = @srcdir@/..
GENERIC_DIR = $(TOP_DIR)/generic
@@ -341,7 +341,7 @@ ${TCL_SHARED_LIB_FILE}: ${OBJS}
${TCL_UNSHARED_LIB_FILE}: ${OBJS}
rm -f ${TCL_LIB_FILE}
@MAKE_LIB@
- $(RANLIB) ${TCL_LIB_FILE}
+ $(TCL-RANLIB) ${TCL_LIB_FILE}
# END CYGNUS LOCAL
@@ -449,7 +449,7 @@ install-binaries: $(TCL_LIB_FILE) tclsh
done;
@echo "Installing $(TCL_LIB_FILE)"
@$(INSTALL_DATA) $(TCL_LIB_FILE) $(LIB_INSTALL_DIR)/$(TCL_LIB_FILE)
- @(cd $(LIB_INSTALL_DIR); $(RANLIB) $(TCL_LIB_FILE))
+ @(cd $(LIB_INSTALL_DIR); $(TCL_RANLIB) $(TCL_LIB_FILE))
@chmod 555 $(LIB_INSTALL_DIR)/$(TCL_LIB_FILE)
@echo "Installing tclsh"
@$(INSTALL_PROGRAM) tclsh $(BIN_INSTALL_DIR)/tclsh
Index: tk/unix/Makefile.in
===================================================================
RCS file: /cvs/src/src/tk/unix/Makefile.in,v
retrieving revision 1.1.1.1
diff -p -u -r1.1.1.1 Makefile.in
--- tk/unix/Makefile.in 2000/02/07 00:19:30 1.1.1.1
+++ tk/unix/Makefile.in 2001/04/20 19:10:02
@@ -188,7 +188,7 @@ TK_LD_SEARCH_FLAGS = @TK_LD_SEARCH_FLAGS
#----------------------------------------------------------------
AC_FLAGS = @DEFS@
-RANLIB = @RANLIB@
+TK_RANLIB = @RANLIB@
SRC_DIR = @srcdir@/..
TOP_DIR = @srcdir@/..
GENERIC_DIR = $(TOP_DIR)/generic
@@ -316,7 +316,7 @@ ${TK_SHARED_LIB_FILE}: ${OBJS}
${TK_UNSHARED_LIB_FILE}: ${OBJS}
rm -f @TK_LIB_FILE@
@MAKE_LIB@
- $(RANLIB) ${TK_LIB_FILE}
+ $(TK_RANLIB) ${TK_LIB_FILE}
# END CYGNUS LOCAL
@@ -386,7 +386,7 @@ install-binaries: $(TK_LIB_FILE) wish
done;
@echo "Installing $(TK_LIB_FILE)"
@$(INSTALL_DATA) $(TK_LIB_FILE) $(LIB_INSTALL_DIR)/$(TK_LIB_FILE)
- @(cd $(LIB_INSTALL_DIR); $(RANLIB) $(TK_LIB_FILE))
+ @(cd $(LIB_INSTALL_DIR); $(TK_RANLIB) $(TK_LIB_FILE))
@chmod 555 $(LIB_INSTALL_DIR)/$(TK_LIB_FILE)
@echo "Installing wish"
@$(INSTALL_PROGRAM) wish $(BIN_INSTALL_DIR)/wish
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: INSTALL_DATA, ranlib, and tcl-related shared libraries
2001-04-20 12:14 ` Keith Seitz
@ 2001-04-20 12:20 ` Mo DeJong
2001-04-20 12:23 ` Keith Seitz
2001-04-20 13:37 ` Syd Polk
1 sibling, 1 reply; 7+ messages in thread
From: Mo DeJong @ 2001-04-20 12:20 UTC (permalink / raw)
To: Keith Seitz; +Cc: Syd Polk, Phil Edwards, insight
On Fri, 20 Apr 2001, Keith Seitz wrote:
> On Tue, 17 Apr 2001, Syd Polk wrote:
>
> > I approve these changes. Fernando or Keith, can you check them in?
>
> Ummm... May I make one small recommendation? :-)
>
> The real reason this is failing to work is because the toplevel Makefile
> is passing RANLIB down. This fails because our toolchains are,
> historically, always built static, but someone always tries to change
> them (until he runs into a sun4 or something).
>
> Anyway, the easier fix is to just ignore what we're passed and take
> whatever configure gives us.
I think the Makefile in the parent dir should just avoid passing
these variables down. I am running into this same problem as
part of the Tcl/Tk 8.3 and Itcl 3.2 upgrade work, we need
a better fix than just changing the name of the variable in
the Makefile.
Mo DeJong
Red Hat Inc
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: INSTALL_DATA, ranlib, and tcl-related shared libraries
2001-04-20 12:20 ` Mo DeJong
@ 2001-04-20 12:23 ` Keith Seitz
0 siblings, 0 replies; 7+ messages in thread
From: Keith Seitz @ 2001-04-20 12:23 UTC (permalink / raw)
To: Mo DeJong; +Cc: Syd Polk, Phil Edwards, insight
On Fri, 20 Apr 2001, Mo DeJong wrote:
> I think the Makefile in the parent dir should just avoid passing
> these variables down. I am running into this same problem as
> part of the Tcl/Tk 8.3 and Itcl 3.2 upgrade work, we need
> a better fix than just changing the name of the variable in
> the Makefile.
I was hesitant to remove it, since I don't know why it is there to begin
with!
:-)
Let me look around and see if there is a reason to have it there...
Keith
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: INSTALL_DATA, ranlib, and tcl-related shared libraries
2001-04-20 12:14 ` Keith Seitz
2001-04-20 12:20 ` Mo DeJong
@ 2001-04-20 13:37 ` Syd Polk
2001-04-22 3:52 ` Phil Edwards
1 sibling, 1 reply; 7+ messages in thread
From: Syd Polk @ 2001-04-20 13:37 UTC (permalink / raw)
To: Keith Seitz; +Cc: Phil Edwards, insight
At 12:14 PM 4/20/01 -0700, Keith Seitz wrote:
>On Tue, 17 Apr 2001, Syd Polk wrote:
>
> > I approve these changes. Fernando or Keith, can you check them in?
>
>Ummm... May I make one small recommendation? :-)
>
>The real reason this is failing to work is because the toplevel Makefile
>is passing RANLIB down. This fails because our toolchains are,
>historically, always built static, but someone always tries to change
>them (until he runs into a sun4 or something).
>
>Anyway, the easier fix is to just ignore what we're passed and take
>whatever configure gives us.
>
>Keith
Thanks for looking further in depth into this patch. I agree with what you
are doing here.
>Index: itcl/itcl/unix/Makefile.in
>===================================================================
>RCS file: /cvs/src/src/itcl/itcl/unix/Makefile.in,v
>retrieving revision 1.1.1.1
>diff -p -u -r1.1.1.1 Makefile.in
>--- itcl/itcl/unix/Makefile.in 2000/02/07 00:19:46 1.1.1.1
>+++ itcl/itcl/unix/Makefile.in 2001/04/20 19:09:39
>@@ -149,7 +149,7 @@ SHLIB_LD = @SHLIB_LD@
> #----------------------------------------------------------------
>
> AC_FLAGS = @TCL_DEFS@
>-RANLIB = @RANLIB@
>+ITCL_RANLIB = @RANLIB@
> TOP_DIR = @ITCL_SRC_DIR@
> GENERIC_DIR = $(TOP_DIR)/generic
> UNIX_DIR = $(TOP_DIR)/unix
>@@ -193,7 +193,7 @@ all: $(ITCL_LIB_FILE) itclsh
> @ITCL_LIB_FILE@: $(OBJS)
> rm -f $(ITCL_LIB_FILE)
> @MAKE_LIB@
>- $(RANLIB) $(ITCL_LIB_FILE)
>+ $(ITCL_RANLIB) $(ITCL_LIB_FILE)
>
> itclsh: tclAppInit.o $(ITCL_LIB_FILE) @TCL_LIB_FULL_PATH@
> $(CC) @LD_FLAGS@ tclAppInit.o @ITCL_BUILD_LIB_SPEC@ \
>@@ -213,7 +213,7 @@ install-binaries: $(ITCL_LIB_FILE) itcls
> @$(MKINSTALLDIRS) $(LIB_INSTALL_DIR) $(BIN_INSTALL_DIR)
> @echo "Installing $(ITCL_LIB_FILE)"
> @$(INSTALL_DATA) $(ITCL_LIB_FILE) $(LIB_INSTALL_DIR)/$(ITCL_LIB_FILE)
>- @(cd $(LIB_INSTALL_DIR); $(RANLIB) $(ITCL_LIB_FILE))
>+ @(cd $(LIB_INSTALL_DIR); $(ITCL_RANLIB) $(ITCL_LIB_FILE))
> chmod 555 $(LIB_INSTALL_DIR)/$(ITCL_LIB_FILE)
> @echo "Installing itclsh"
> $(INSTALL_PROGRAM) itclsh $(BIN_INSTALL_DIR)/itclsh$(VERSION)
>Index: itcl/itk/unix/Makefile.in
>===================================================================
>RCS file: /cvs/src/src/itcl/itk/unix/Makefile.in,v
>retrieving revision 1.1.1.1
>diff -p -u -r1.1.1.1 Makefile.in
>--- itcl/itk/unix/Makefile.in 2000/02/07 00:19:46 1.1.1.1
>+++ itcl/itk/unix/Makefile.in 2001/04/20 19:09:55
>@@ -193,7 +193,7 @@ SHLIB_LD = @SHLIB_LD@
> #----------------------------------------------------------------
>
> AC_FLAGS = @TCL_DEFS@
>-RANLIB = @RANLIB@
>+ITK_RANLIB = @RANLIB@
> TOP_DIR = @ITK_SRC_DIR@
> GENERIC_DIR = $(TOP_DIR)/generic
> UNIX_DIR = $(TOP_DIR)/unix
>@@ -226,7 +226,7 @@ all: itkwish
> @ITK_LIB_FILE@: ${OBJS}
> rm -f $(ITK_LIB_FILE)
> @MAKE_LIB@
>- $(RANLIB) $(ITK_LIB_FILE)
>+ $(ITK_RANLIB) $(ITK_LIB_FILE)
>
> itkwish: tkAppInit.o $(ITK_LIB_FILE) @TCL_LIB_FULL_PATH@
> @TK_LIB_FULL_PATH@ \
> @ITCL_LIB_FULL_PATH@
>@@ -253,7 +253,7 @@ install-binaries: $(ITK_LIB_FILE) itkwis
> @$(MKINSTALLDIRS) $(LIB_INSTALL_DIR) $(BIN_INSTALL_DIR)
> @echo "Installing $(ITK_LIB_FILE)"
> @$(INSTALL_DATA) $(ITK_LIB_FILE) $(LIB_INSTALL_DIR)
>- @(cd $(LIB_INSTALL_DIR); $(RANLIB) $(ITK_LIB_FILE))
>+ @(cd $(LIB_INSTALL_DIR); $(ITK_RANLIB) $(ITK_LIB_FILE))
> @chmod 555 $(LIB_INSTALL_DIR)/$(ITK_LIB_FILE)
> @echo "Installing itkwish"
> $(INSTALL_PROGRAM) itkwish $(BIN_INSTALL_DIR)/itkwish$(VERSION)
>Index: tcl/unix/Makefile.in
>===================================================================
>RCS file: /cvs/src/src/tcl/unix/Makefile.in,v
>retrieving revision 1.1.1.1
>diff -p -u -r1.1.1.1 Makefile.in
>--- tcl/unix/Makefile.in 1999/11/09 01:28:44 1.1.1.1
>+++ tcl/unix/Makefile.in 2001/04/20 19:09:58
>@@ -188,7 +188,7 @@ TCL_LIB_FLAG = @TCL_LIB_FLAG@
> COMPAT_OBJS = @LIBOBJS@
>
> AC_FLAGS = @DEFS@
>-RANLIB = @RANLIB@
>+TCL_RANLIB = @RANLIB@
> SRC_DIR = @srcdir@
> TOP_DIR = @srcdir@/..
> GENERIC_DIR = $(TOP_DIR)/generic
>@@ -341,7 +341,7 @@ ${TCL_SHARED_LIB_FILE}: ${OBJS}
> ${TCL_UNSHARED_LIB_FILE}: ${OBJS}
> rm -f ${TCL_LIB_FILE}
> @MAKE_LIB@
>- $(RANLIB) ${TCL_LIB_FILE}
>+ $(TCL-RANLIB) ${TCL_LIB_FILE}
>
> # END CYGNUS LOCAL
>
>@@ -449,7 +449,7 @@ install-binaries: $(TCL_LIB_FILE) tclsh
> done;
> @echo "Installing $(TCL_LIB_FILE)"
> @$(INSTALL_DATA) $(TCL_LIB_FILE) $(LIB_INSTALL_DIR)/$(TCL_LIB_FILE)
>- @(cd $(LIB_INSTALL_DIR); $(RANLIB) $(TCL_LIB_FILE))
>+ @(cd $(LIB_INSTALL_DIR); $(TCL_RANLIB) $(TCL_LIB_FILE))
> @chmod 555 $(LIB_INSTALL_DIR)/$(TCL_LIB_FILE)
> @echo "Installing tclsh"
> @$(INSTALL_PROGRAM) tclsh $(BIN_INSTALL_DIR)/tclsh
>Index: tk/unix/Makefile.in
>===================================================================
>RCS file: /cvs/src/src/tk/unix/Makefile.in,v
>retrieving revision 1.1.1.1
>diff -p -u -r1.1.1.1 Makefile.in
>--- tk/unix/Makefile.in 2000/02/07 00:19:30 1.1.1.1
>+++ tk/unix/Makefile.in 2001/04/20 19:10:02
>@@ -188,7 +188,7 @@ TK_LD_SEARCH_FLAGS = @TK_LD_SEARCH_FLAGS
> #----------------------------------------------------------------
>
> AC_FLAGS = @DEFS@
>-RANLIB = @RANLIB@
>+TK_RANLIB = @RANLIB@
> SRC_DIR = @srcdir@/..
> TOP_DIR = @srcdir@/..
> GENERIC_DIR = $(TOP_DIR)/generic
>@@ -316,7 +316,7 @@ ${TK_SHARED_LIB_FILE}: ${OBJS}
> ${TK_UNSHARED_LIB_FILE}: ${OBJS}
> rm -f @TK_LIB_FILE@
> @MAKE_LIB@
>- $(RANLIB) ${TK_LIB_FILE}
>+ $(TK_RANLIB) ${TK_LIB_FILE}
>
> # END CYGNUS LOCAL
>
>@@ -386,7 +386,7 @@ install-binaries: $(TK_LIB_FILE) wish
> done;
> @echo "Installing $(TK_LIB_FILE)"
> @$(INSTALL_DATA) $(TK_LIB_FILE) $(LIB_INSTALL_DIR)/$(TK_LIB_FILE)
>- @(cd $(LIB_INSTALL_DIR); $(RANLIB) $(TK_LIB_FILE))
>+ @(cd $(LIB_INSTALL_DIR); $(TK_RANLIB) $(TK_LIB_FILE))
> @chmod 555 $(LIB_INSTALL_DIR)/$(TK_LIB_FILE)
> @echo "Installing wish"
> @$(INSTALL_PROGRAM) wish $(BIN_INSTALL_DIR)/wish
Syd Polk spolk@redhat.com
Engineering Manager +1 408 543 9430
Red Hat, Inc.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: INSTALL_DATA, ranlib, and tcl-related shared libraries
2001-04-20 13:37 ` Syd Polk
@ 2001-04-22 3:52 ` Phil Edwards
0 siblings, 0 replies; 7+ messages in thread
From: Phil Edwards @ 2001-04-22 3:52 UTC (permalink / raw)
To: Syd Polk; +Cc: Keith Seitz, insight
On Fri, Apr 20, 2001 at 01:37:17PM -0700, Syd Polk wrote:
> At 12:14 PM 4/20/01 -0700, Keith Seitz wrote:
> >On Tue, 17 Apr 2001, Syd Polk wrote:
> >
> > > I approve these changes. Fernando or Keith, can you check them in?
> >
> >Ummm... May I make one small recommendation? :-)
> >
> >The real reason this is failing to work is because the toplevel Makefile
> >is passing RANLIB down. This fails because our toolchains are,
> >historically, always built static, but someone always tries to change
> >them (until he runs into a sun4 or something).
> >
> >Anyway, the easier fix is to just ignore what we're passed and take
> >whatever configure gives us.
> >
> >Keith
>
> Thanks for looking further in depth into this patch. I agree with what you
> are doing here.
I'm glad this is finally getting examined by the experts, instead of just me.
:-) In any case, the s/INSTALL_DATA/INSTALL_PROGRAM/ change is unrelated
to the RANLIB issue and should still be installed.
Phil
--
pedwards at disaster dot jaj dot com | pme at sources dot redhat dot com
devphil at several other less interesting addresses in various dot domains
The gods do not protect fools. Fools are protected by more capable fools.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2001-04-22 3:52 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2001-04-17 15:02 INSTALL_DATA, ranlib, and tcl-related shared libraries Phil Edwards
2001-04-17 16:02 ` Syd Polk
2001-04-20 12:14 ` Keith Seitz
2001-04-20 12:20 ` Mo DeJong
2001-04-20 12:23 ` Keith Seitz
2001-04-20 13:37 ` Syd Polk
2001-04-22 3:52 ` Phil Edwards
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).