From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <insight-return-6738-listarch-insight=sources.redhat.com@sourceware.org>
Received: (qmail 31866 invoked by alias); 12 Mar 2010 17:17:20 -0000
Received: (qmail 31842 invoked by uid 22791); 12 Mar 2010 17:17:20 -0000
X-SWARE-Spam-Status: No, hits=-7.2 required=5.0 	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 12 Mar 2010 17:17:15 +0000
Received: from int-mx04.intmail.prod.int.phx2.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17]) 	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o2CHH7nb009399 	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); 	Fri, 12 Mar 2010 12:17:07 -0500
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) 	by int-mx04.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o2CHH6oe013503; 	Fri, 12 Mar 2010 12:17:06 -0500
Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) 	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o2CHH4qw004949; 	Fri, 12 Mar 2010 12:17:05 -0500
Received: by opsy.redhat.com (Postfix, from userid 500) 	id 58EDF3782C5; Fri, 12 Mar 2010 10:17:04 -0700 (MST)
From: Tom Tromey <tromey@redhat.com>
To: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
Cc: "'Hui Zhu'" <teawater@gmail.com>, <insight@sourceware.org>,         "'Keith Seitz'" <keiths@redhat.com>
Subject: Re: [PATCH] Fix gdbtk-cmds.c: get a build error
References: <daef60381003102300q37fe4237icb942bb7aa3f16da@mail.gmail.com> 	<000001cac1ef$084ed8d0$18ec8a70$@muller@ics-cnrs.unistra.fr>
Reply-To: Tom Tromey <tromey@redhat.com>
Date: Fri, 12 Mar 2010 18:28:00 -0000
In-Reply-To: <000001cac1ef$084ed8d0$18ec8a70$@muller@ics-cnrs.unistra.fr> 	(Pierre Muller's message of "Fri, 12 Mar 2010 15:19:30 +0100")
Message-ID: <m3ljdxbgtr.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-IsSubscribed: yes
Mailing-List: contact insight-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <insight.sourceware.org>
List-Subscribe: <mailto:insight-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/insight/>
List-Post: <mailto:insight@sourceware.org>
List-Help: <mailto:insight-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: insight-owner@sourceware.org
X-SW-Source: 2010-q1/txt/msg00031.txt.bz2

>>>>> "Pierre" == Pierre Muller <pierre.muller@ics-cnrs.unistra.fr> writes:

Pierre> The patch below fixes it.
Pierre> Checked in as obvious,

This patch isn't correct.

It will work for the time being, but it will break whenever we merge in
code that causes an objfile not to use psymtabs.

The rule is, only the psymtab implementation and debuginfo readers are
allowed to include psympriv.h.  All other code must go through the
"quick" API.

I'm working on a replacement patch.

Tom