public inbox for insight@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] update get_frame_block
@ 2002-04-05 14:27 Keith Seitz
  2002-04-05 15:41 ` Andrew Cagney
  2002-04-06 16:17 ` Jim Blandy
  0 siblings, 2 replies; 3+ messages in thread
From: Keith Seitz @ 2002-04-05 14:27 UTC (permalink / raw)
  To: Insight Maling List

Hi,

This patch updates calls to get_frame_block to match recent API changes in
gdb.

Keith

ChangeLog
2002-04-05  Keith Seitz  <keiths@redhat.com>

        * generic/gdbtk-stack.c (gdb_block_vars): Update get_frame_block to
        match recent gdb changes.
        (gdb_get_blocks): Likewise.
        (gdb_get_vars_command): Likewise.
        (gdb_selected_block): Likewise.

Patch
Index: generic/gdbtk-stack.c
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk-stack.c,v
retrieving revision 1.7
diff -p -r1.7 gdbtk-stack.c
*** generic/gdbtk-stack.c	2002/02/07 21:56:07	1.7
--- generic/gdbtk-stack.c	2002/04/05 22:23:34
*************** gdb_block_vars (ClientData clientData, T
*** 105,111 ****
    start = string_to_core_addr (Tcl_GetStringFromObj (objv[1], NULL));
    end   = string_to_core_addr (Tcl_GetStringFromObj (objv[2], NULL));

!   block = get_frame_block (selected_frame);

    while (block != 0)
      {
--- 105,111 ----
    start = string_to_core_addr (Tcl_GetStringFromObj (objv[1], NULL));
    end   = string_to_core_addr (Tcl_GetStringFromObj (objv[2], NULL));

!   block = get_frame_block (selected_frame, 0);

    while (block != 0)
      {
*************** gdb_get_blocks (ClientData clientData, T
*** 169,175 ****

    if (selected_frame != NULL)
      {
!       block = get_frame_block (selected_frame);
        pc = get_frame_pc (selected_frame);
        while (block != 0)
  	{
--- 169,175 ----

    if (selected_frame != NULL)
      {
!       block = get_frame_block (selected_frame, 0);
        pc = get_frame_pc (selected_frame);
        while (block != 0)
  	{
*************** gdb_get_vars_command (ClientData clientD
*** 316,322 ****
        if (selected_frame == NULL)
  	return TCL_OK;

!       block = get_frame_block (selected_frame);
      }

    while (block != 0)
--- 316,322 ----
        if (selected_frame == NULL)
  	return TCL_OK;

!       block = get_frame_block (selected_frame, 0);
      }

    while (block != 0)
*************** gdb_selected_block (ClientData clientDat
*** 389,395 ****
    else
      {
        struct block *block;
!       block = get_frame_block (selected_frame);
        xasprintf (&start, "0x%s", paddr_nz (BLOCK_START (block)));
        xasprintf (&end, "0x%s", paddr_nz (BLOCK_END (block)));
      }
--- 389,395 ----
    else
      {
        struct block *block;
!       block = get_frame_block (selected_frame, 0);
        xasprintf (&start, "0x%s", paddr_nz (BLOCK_START (block)));
        xasprintf (&end, "0x%s", paddr_nz (BLOCK_END (block)));
      }

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [PATCH] update get_frame_block
  2002-04-05 14:27 [PATCH] update get_frame_block Keith Seitz
@ 2002-04-05 15:41 ` Andrew Cagney
  2002-04-06 16:17 ` Jim Blandy
  1 sibling, 0 replies; 3+ messages in thread
From: Andrew Cagney @ 2002-04-05 15:41 UTC (permalink / raw)
  To: Keith Seitz; +Cc: Insight Maling List

> Hi,
> 
> This patch updates calls to get_frame_block to match recent API changes in
> gdb.

Thanks (but not my change that broke it).  I was about to commit 
something very similar.  Technically, the second argument is NULL :-)

Andrew


> Keith
> 
> ChangeLog
> 2002-04-05  Keith Seitz  <keiths@redhat.com>
> 
> * generic/gdbtk-stack.c (gdb_block_vars): Update get_frame_block to
>         match recent gdb changes.
>         (gdb_get_blocks): Likewise.
>         (gdb_get_vars_command): Likewise.
>         (gdb_selected_block): Likewise.
> 
> Patch
> Index: generic/gdbtk-stack.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk-stack.c,v
> retrieving revision 1.7
> diff -p -r1.7 gdbtk-stack.c
> *** generic/gdbtk-stack.c	2002/02/07 21:56:07	1.7
> --- generic/gdbtk-stack.c	2002/04/05 22:23:34
> *************** gdb_block_vars (ClientData clientData, T
> *** 105,111 ****
>     start = string_to_core_addr (Tcl_GetStringFromObj (objv[1], NULL));
>     end   = string_to_core_addr (Tcl_GetStringFromObj (objv[2], NULL));
> 
> !   block = get_frame_block (selected_frame);
> 
>     while (block != 0)
>       {
> --- 105,111 ----
>     start = string_to_core_addr (Tcl_GetStringFromObj (objv[1], NULL));
>     end   = string_to_core_addr (Tcl_GetStringFromObj (objv[2], NULL));
> 
> !   block = get_frame_block (selected_frame, 0);
> 
>     while (block != 0)
>       {
> *************** gdb_get_blocks (ClientData clientData, T
> *** 169,175 ****
> 
>     if (selected_frame != NULL)
>       {
> !       block = get_frame_block (selected_frame);
>         pc = get_frame_pc (selected_frame);
>         while (block != 0)
>   	{
> --- 169,175 ----
> 
>     if (selected_frame != NULL)
>       {
> !       block = get_frame_block (selected_frame, 0);
>         pc = get_frame_pc (selected_frame);
>         while (block != 0)
>   	{
> *************** gdb_get_vars_command (ClientData clientD
> *** 316,322 ****
>         if (selected_frame == NULL)
>   	return TCL_OK;
> 
> !       block = get_frame_block (selected_frame);
>       }
> 
>     while (block != 0)
> --- 316,322 ----
>         if (selected_frame == NULL)
>   	return TCL_OK;
> 
> !       block = get_frame_block (selected_frame, 0);
>       }
> 
>     while (block != 0)
> *************** gdb_selected_block (ClientData clientDat
> *** 389,395 ****
>     else
>       {
>         struct block *block;
> !       block = get_frame_block (selected_frame);
>         xasprintf (&start, "0x%s", paddr_nz (BLOCK_START (block)));
>         xasprintf (&end, "0x%s", paddr_nz (BLOCK_END (block)));
>       }
> --- 389,395 ----
>     else
>       {
>         struct block *block;
> !       block = get_frame_block (selected_frame, 0);
>         xasprintf (&start, "0x%s", paddr_nz (BLOCK_START (block)));
>         xasprintf (&end, "0x%s", paddr_nz (BLOCK_END (block)));
>       }
> 
> 


^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [PATCH] update get_frame_block
  2002-04-05 14:27 [PATCH] update get_frame_block Keith Seitz
  2002-04-05 15:41 ` Andrew Cagney
@ 2002-04-06 16:17 ` Jim Blandy
  1 sibling, 0 replies; 3+ messages in thread
From: Jim Blandy @ 2002-04-06 16:17 UTC (permalink / raw)
  To: Keith Seitz; +Cc: Insight Maling List


Ouch!  Sorry about that.  As is now apparent, I did the work on a GDB
module, not an Insight module.

Keith Seitz <keiths@redhat.com> writes:

> Hi,
> 
> This patch updates calls to get_frame_block to match recent API changes in
> gdb.
> 
> Keith
> 
> ChangeLog
> 2002-04-05  Keith Seitz  <keiths@redhat.com>
> 
>         * generic/gdbtk-stack.c (gdb_block_vars): Update get_frame_block to
>         match recent gdb changes.
>         (gdb_get_blocks): Likewise.
>         (gdb_get_vars_command): Likewise.
>         (gdb_selected_block): Likewise.
> 
> Patch
> Index: generic/gdbtk-stack.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk-stack.c,v
> retrieving revision 1.7
> diff -p -r1.7 gdbtk-stack.c
> *** generic/gdbtk-stack.c	2002/02/07 21:56:07	1.7
> --- generic/gdbtk-stack.c	2002/04/05 22:23:34
> *************** gdb_block_vars (ClientData clientData, T
> *** 105,111 ****
>     start = string_to_core_addr (Tcl_GetStringFromObj (objv[1], NULL));
>     end   = string_to_core_addr (Tcl_GetStringFromObj (objv[2], NULL));
> 
> !   block = get_frame_block (selected_frame);
> 
>     while (block != 0)
>       {
> --- 105,111 ----
>     start = string_to_core_addr (Tcl_GetStringFromObj (objv[1], NULL));
>     end   = string_to_core_addr (Tcl_GetStringFromObj (objv[2], NULL));
> 
> !   block = get_frame_block (selected_frame, 0);
> 
>     while (block != 0)
>       {
> *************** gdb_get_blocks (ClientData clientData, T
> *** 169,175 ****
> 
>     if (selected_frame != NULL)
>       {
> !       block = get_frame_block (selected_frame);
>         pc = get_frame_pc (selected_frame);
>         while (block != 0)
>   	{
> --- 169,175 ----
> 
>     if (selected_frame != NULL)
>       {
> !       block = get_frame_block (selected_frame, 0);
>         pc = get_frame_pc (selected_frame);
>         while (block != 0)
>   	{
> *************** gdb_get_vars_command (ClientData clientD
> *** 316,322 ****
>         if (selected_frame == NULL)
>   	return TCL_OK;
> 
> !       block = get_frame_block (selected_frame);
>       }
> 
>     while (block != 0)
> --- 316,322 ----
>         if (selected_frame == NULL)
>   	return TCL_OK;
> 
> !       block = get_frame_block (selected_frame, 0);
>       }
> 
>     while (block != 0)
> *************** gdb_selected_block (ClientData clientDat
> *** 389,395 ****
>     else
>       {
>         struct block *block;
> !       block = get_frame_block (selected_frame);
>         xasprintf (&start, "0x%s", paddr_nz (BLOCK_START (block)));
>         xasprintf (&end, "0x%s", paddr_nz (BLOCK_END (block)));
>       }
> --- 389,395 ----
>     else
>       {
>         struct block *block;
> !       block = get_frame_block (selected_frame, 0);
>         xasprintf (&start, "0x%s", paddr_nz (BLOCK_START (block)));
>         xasprintf (&end, "0x%s", paddr_nz (BLOCK_END (block)));
>       }

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2002-04-07  0:17 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-04-05 14:27 [PATCH] update get_frame_block Keith Seitz
2002-04-05 15:41 ` Andrew Cagney
2002-04-06 16:17 ` Jim Blandy

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).