From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andreas Jaeger To: Syd Polk Cc: insight@sourceware.cygnus.com Subject: Re: make check in itcl Date: Wed, 03 May 2000 12:05:00 -0000 Message-id: References: <"Mon,> <01> <2000> <10:16:43> <-0700> <"Mon,> <01> <2000> <09:07:18> <-0700> <390DABB6.403CE5A0@cygnus.com> <4.2.0.58.20000501101619.00b6b600@pop.cygnus.com> <4.2.0.58.20000503103543.00a27ac0@pop.cygnus.com> X-SW-Source: 2000-q2/msg00170.html >>>>> Syd Polk writes: Syd> I checked it into sourceware; however, on second look, I don't think Syd> it will work. When you run "make check" from the toplevel, you need to Syd> run "make test" in the itcl subdirectories. I've tested my first patch - but forgot to test that version :-( Sorry about that. Syd> +test check: >> for dir in $(subdirs) ; do \ >> if (echo "Making in $$dir"; cd $$dir && $(MAKE) $@); \ >> then true; else exit 1; fi \ Syd> This just runs "make check" in the sub-directories, which will fail, right? I checked the subdirectories - and it really should fail (and indeed does) Syd> Should be Syd> if (echo "Making in $$dir"; cd $$dir && $(MAKE) test); \ Yes, that works. I've just run make;make check and it's fine with this change. Please commit this fix. Thanks, Andreas -- Andreas Jaeger SuSE Labs aj@suse.de private aj@arthur.rhein-neckar.de