From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15849 invoked by alias); 31 Mar 2010 03:20:06 -0000 Received: (qmail 15839 invoked by uid 22791); 31 Mar 2010 03:20:05 -0000 X-SWARE-Spam-Status: No, hits=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SARE_MSGID_LONG45 X-Spam-Check-By: sourceware.org Received: from mail-pz0-f203.google.com (HELO mail-pz0-f203.google.com) (209.85.222.203) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 31 Mar 2010 03:20:00 +0000 Received: by pzk41 with SMTP id 41so1294133pzk.10 for ; Tue, 30 Mar 2010 20:19:57 -0700 (PDT) MIME-Version: 1.0 Received: by 10.142.103.18 with HTTP; Tue, 30 Mar 2010 20:19:37 -0700 (PDT) In-Reply-To: <4BB22B62.3050402@redhat.com> References: <4BA11802.8050909@redhat.com> <4BB22B62.3050402@redhat.com> From: Hui Zhu Date: Wed, 31 Mar 2010 04:12:00 -0000 Received: by 10.143.84.5 with SMTP id m5mr2128109wfl.313.1270005597144; Tue, 30 Mar 2010 20:19:57 -0700 (PDT) Message-ID: Subject: Re: undefined reference to `set_breakpoint' To: Keith Seitz Cc: insight@sources.redhat.com Content-Type: multipart/mixed; boundary=000e0cd517387b07760483103843 X-IsSubscribed: yes Mailing-List: contact insight-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: insight-owner@sourceware.org X-SW-Source: 2010-q1/txt/msg00050.txt.bz2 --000e0cd517387b07760483103843 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-length: 1081 On Wed, Mar 31, 2010 at 00:48, Keith Seitz wrote: > On 03/30/2010 01:29 AM, Hui Zhu wrote: >> >> Ping. =A0Did I miss something? >> > > Nope -- I did. After the breakpoint commands API was fiddled with, I work= ed > up the original patch. Some (brief) time after committing my patch, the A= PI > was fiddled with again. > > I apologize about the confusion. Try this patch, which I've committed. > > Keith > > ChangeLog > 2010-03-30 =A0Keith Seitz =A0 > > =A0 =A0 =A0 =A0* generic/gdbtk-bp.c (gdb_get_breakpoint_info): Breakpoint > =A0 =A0 =A0 =A0commands are now reference counted. Adjust data pointers. > =A0 =A0 =A0 =A0(gdb_get_tracepoint_info): Likewise. > =A0 =A0 =A0 =A0(gdb_actions_command): Don't free previous actions. If the > =A0 =A0 =A0 =A0commands aren't valid, we would prefer to keep the old ones > =A0 =A0 =A0 =A0any way. break_point_set_commands will also clobber any > =A0 =A0 =A0 =A0previous results anyway. > Hi Keith, I try this patch bug cannot patch to cvs-head. The attachment is the rej file that I got. Thanks, Hui --000e0cd517387b07760483103843 Content-Type: application/x-reject; name="gdbtk-bp.c.rej" Content-Disposition: attachment; filename="gdbtk-bp.c.rej" Content-Transfer-Encoding: base64 X-Attachment-Id: f_g7fkzkuj1 Content-length: 2717 KioqKioqKioqKioqKioqIGdkYl9nZXRfYnJlYWtwb2ludF9pbmZvIChDbGll bnREYXRhIGNsaWUKKioqIDM2MiwzNjggKioqKgogIAkJCSAgICBUY2xfTmV3 SW50T2JqIChiLT5pZ25vcmVfY291bnQpKTsKICAKICAgIFRjbF9MaXN0T2Jq QXBwZW5kRWxlbWVudCAoTlVMTCwgcmVzdWx0X3B0ci0+b2JqX3B0ciwKLSAJ CQkgICAgZ2V0X2JyZWFrcG9pbnRfY29tbWFuZHMgKGItPmNvbW1hbmRzKSk7 CiAgCiAgICBUY2xfTGlzdE9iakFwcGVuZEVsZW1lbnQgKE5VTEwsIHJlc3Vs dF9wdHItPm9ial9wdHIsCiAgCQkJICAgIFRjbF9OZXdTdHJpbmdPYmogKGIt PmNvbmRfc3RyaW5nLCAtMSkpOwotLS0gMzYyLDM2OCAtLS0tCiAgCQkJICAg IFRjbF9OZXdJbnRPYmogKGItPmlnbm9yZV9jb3VudCkpOwogIAogICAgVGNs X0xpc3RPYmpBcHBlbmRFbGVtZW50IChOVUxMLCByZXN1bHRfcHRyLT5vYmpf cHRyLAorIAkJCSAgICBnZXRfYnJlYWtwb2ludF9jb21tYW5kcyAoYi0+Y29t bWFuZHMgPyBiLT5jb21tYW5kcy0+Y29tbWFuZHMgOiBOVUxMKSk7CiAgCiAg ICBUY2xfTGlzdE9iakFwcGVuZEVsZW1lbnQgKE5VTEwsIHJlc3VsdF9wdHIt Pm9ial9wdHIsCiAgCQkJICAgIFRjbF9OZXdTdHJpbmdPYmogKGItPmNvbmRf c3RyaW5nLCAtMSkpOwoqKioqKioqKioqKioqKiogZ2RiX2FjdGlvbnNfY29t bWFuZCAoQ2xpZW50RGF0YSBjbGllbnREYQoqKiogNjg0LDY5MiAqKioqCiAg ICAgICAgcmV0dXJuIFRDTF9FUlJPUjsKICAgICAgfQogIAotICAgLyogRnJl ZSBhbnkgZXhpc3RpbmcgYWN0aW9ucy4gICovCi0gICBmcmVlX2NvbW1hbmRf bGluZXMgKCZ0cC0+Y29tbWFuZHMpOwotIAogICAgLyogVmFsaWRhdGUgYW5k IHNldCBuZXcgdHJhY2Vwb2ludCBhY3Rpb25zLiAgKi8KICAgIFRjbF9MaXN0 T2JqR2V0RWxlbWVudHMgKGludGVycCwgb2JqdlsyXSwgJmdkYnRrX29ial9h cnJheV9jbnQsCiAgCQkJICAmZ2RidGtfb2JqX2FycmF5KTsKLS0tIDY4NCw2 ODkgLS0tLQogICAgICAgIHJldHVybiBUQ0xfRVJST1I7CiAgICAgIH0KICAK ICAgIC8qIFZhbGlkYXRlIGFuZCBzZXQgbmV3IHRyYWNlcG9pbnQgYWN0aW9u cy4gICovCiAgICBUY2xfTGlzdE9iakdldEVsZW1lbnRzIChpbnRlcnAsIG9i anZbMl0sICZnZGJ0a19vYmpfYXJyYXlfY250LAogIAkJCSAgJmdkYnRrX29i al9hcnJheSk7CioqKioqKioqKioqKioqKiBnZGJfZ2V0X3RyYWNlcG9pbnRf aW5mbyAoQ2xpZW50RGF0YSBjbGllCioqKiA3NzMsNzg0ICoqKioKICAKICAg IC8qIEFwcGVuZCBhIGxpc3Qgb2YgYWN0aW9ucyAqLwogICAgYWN0aW9uX2xp c3QgPSBUY2xfTmV3T2JqICgpOwotICAgZm9yIChjbCA9IHRwLT5jb21tYW5k czsgY2wgIT0gTlVMTDsgY2wgPSBjbC0+bmV4dCkKICAgICAgewotICAgICAg IFRjbF9MaXN0T2JqQXBwZW5kRWxlbWVudCAoaW50ZXJwLCBhY3Rpb25fbGlz dCwKLSAJCQkJVGNsX05ld1N0cmluZ09iaiAoY2wtPmxpbmUsIC0xKSk7CiAg ICAgIH0KLSAgIFRjbF9MaXN0T2JqQXBwZW5kRWxlbWVudCAoaW50ZXJwLCBy ZXN1bHRfcHRyLT5vYmpfcHRyLCBhY3Rpb25fbGlzdCk7CiAgCiAgICByZXR1 cm4gVENMX09LOwogIH0KLS0tIDc3MCw3ODQgLS0tLQogIAogICAgLyogQXBw ZW5kIGEgbGlzdCBvZiBhY3Rpb25zICovCiAgICBhY3Rpb25fbGlzdCA9IFRj bF9OZXdPYmogKCk7CisgICBpZiAodHAtPmNvbW1hbmRzICE9IE5VTEwpCiAg ICAgIHsKKyAgICAgICBmb3IgKGNsID0gdHAtPmNvbW1hbmRzLT5jb21tYW5k czsgY2wgIT0gTlVMTDsgY2wgPSBjbC0+bmV4dCkKKyAJeworIAkgIFRjbF9M aXN0T2JqQXBwZW5kRWxlbWVudCAoaW50ZXJwLCBhY3Rpb25fbGlzdCwKKyAJ CQkJICAgIFRjbF9OZXdTdHJpbmdPYmogKGNsLT5saW5lLCAtMSkpOworIAl9 CisgICAgICAgVGNsX0xpc3RPYmpBcHBlbmRFbGVtZW50IChpbnRlcnAsIHJl c3VsdF9wdHItPm9ial9wdHIsIGFjdGlvbl9saXN0KTsKICAgICAgfQogIAog ICAgcmV0dXJuIFRDTF9PSzsKICB9Cg== --000e0cd517387b07760483103843--