From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1648 invoked by alias); 30 Sep 2003 23:14:12 -0000 Mailing-List: contact insight-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: insight-owner@sources.redhat.com Received: (qmail 1439 invoked from network); 30 Sep 2003 23:14:10 -0000 Received: from unknown (HELO hawaii.kealia.com) (209.3.10.89) by sources.redhat.com with SMTP; 30 Sep 2003 23:14:10 -0000 Received: by hawaii.kealia.com (Postfix, from userid 2049) id 7C555CB28; Tue, 30 Sep 2003 16:14:10 -0700 (PDT) To: Andrew Cagney Cc: gdb-patches@sources.redhat.com, insight@sources.redhat.com Subject: Re: [patch/rfc] Deprecate REGISTER_VIRTUAL_SIZE References: <3F75E34F.2090007@redhat.com> <3F79E76A.5060706@redhat.com> From: David Carlton Date: Tue, 30 Sep 2003 23:14:00 -0000 In-Reply-To: <3F79E76A.5060706@redhat.com> (Andrew Cagney's message of "Tue, 30 Sep 2003 16:28:26 -0400") Message-ID: User-Agent: Gnus/5.1002 (Gnus v5.10.2) XEmacs/21.4 (Rational FORTRAN, linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2003-q3/txt/msg00184.txt.bz2 On Tue, 30 Sep 2003 16:28:26 -0400, Andrew Cagney said: > I've checked this in. >> 2003-09-27 Andrew Cagney >> * gdbarch.sh (DEPRECATED_REGISTER_VIRTUAL_SIZE): Rename >> REGISTER_VIRTUAL_SIZE. >> * gdbarch.h, gdbarch.c: Regenerate. >> * vax-tdep.h, sparc-tdep.c, regcache.h: Update. >> * regcache.c, mn10300-tdep.c, mips-tdep.c: Update. >> * infcmd.c, frame.c, findvar.c, cris-tdep.c: Update. >> Index: doc/ChangeLog >> 2003-09-22 Andrew Cagney >> * gdbint.texinfo (Target Architecture Definition): Rename >> REGISTER_VIRTUAL_SIZE to DEPRECATED_REGISTER_VIRTUAL_SIZE. >> (Target Architecture Definition): Index: mi/ChangeLog >> 2003-09-22 Andrew Cagney >> * mi-main.c: Rename REGISTER_VIRTUAL_SIZE to >> DEPRECATED_REGISTER_VIRTUAL_SIZE. Missed one in insight; I've committed the patch below as obvious. I saw somebody using insight today; it looked really cool. If my hands didn't hate pointing devices, I'd be sorely tempted to switch... David Carlton carlton@kealia.com 2003-09-30 David Carlton * generic/gdbtk-register.c (get_register): Replace REGISTER_VIRTUAL_SIZE by DEPRECATED_REGISTER_VIRTUAL_SIZE. =================================================================== RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk-register.c,v retrieving revision 1.20 retrieving revision 1.21 diff -u -r1.20 -r1.21 --- src/gdb/gdbtk/generic/gdbtk-register.c 2003/08/05 14:58:29 1.20 +++ src/gdb/gdbtk/generic/gdbtk-register.c 2003/09/30 23:10:55 1.21 @@ -307,7 +307,8 @@ raw_buffer, virtual_buffer); } else - memcpy (virtual_buffer, raw_buffer, REGISTER_VIRTUAL_SIZE (regnum)); + memcpy (virtual_buffer, raw_buffer, + DEPRECATED_REGISTER_VIRTUAL_SIZE (regnum)); stb = mem_fileopen (); old_chain = make_cleanup_ui_file_delete (stb);