From: Anthony Green <green@redhat.com>
To: classpath-patches <classpath-patches@gnu.org>, java-patches@gcc.gnu.org
Subject: Patch: fix LogManager permission check
Date: Fri, 06 Oct 2006 15:07:00 -0000 [thread overview]
Message-ID: <1160147229.2859.7.camel@localhost.localdomain> (raw)
[-- Attachment #1: Type: text/plain, Size: 147 bytes --]
I hit PR classpath/28070 again today (in FC5). I'd like to check this
patch into GNU Classpath, as well as GCC HEAD and the 4.1 branch. Ok?
AG
[-- Attachment #2: lm.patch --]
[-- Type: text/x-patch, Size: 1324 bytes --]
2006-10-06 Anthony Green <green@redhat.com>
PR classpath/28070:
* java/util/logging/LogManager.java: Don't share a control
permission object.
Index: java/util/logging/LogManager.java
===================================================================
RCS file: /sources/classpath/classpath/java/util/logging/LogManager.java,v
retrieving revision 1.24
diff -u -r1.24 LogManager.java
--- java/util/logging/LogManager.java 19 Sep 2006 10:41:45 -0000 1.24
+++ java/util/logging/LogManager.java 6 Oct 2006 15:02:49 -0000
@@ -787,13 +787,6 @@
}
/**
- * An instance of <code>LoggingPermission("control")</code>
- * that is shared between calls to <code>checkAccess()</code>.
- */
- private static final LoggingPermission controlPermission = new LoggingPermission("control",
- null);
-
- /**
* Checks whether the current security context allows changing
* the configuration of the logging framework. For the security
* context to be trusted, it has to be granted
@@ -807,7 +800,10 @@
{
SecurityManager sm = System.getSecurityManager();
if (sm != null)
- sm.checkPermission(controlPermission);
+ {
+ sm.checkPermission(new LoggingPermission("control",
+ null));
+ }
}
/**
next reply other threads:[~2006-10-06 15:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-06 15:07 Anthony Green [this message]
2006-10-06 15:19 ` Anthony Green
2006-10-06 15:45 ` Tom Tromey
2006-10-06 15:52 ` Anthony Green
2006-10-06 19:05 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1160147229.2859.7.camel@localhost.localdomain \
--to=green@redhat.com \
--cc=classpath-patches@gnu.org \
--cc=java-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).