* Patch: fix LogManager permission check
@ 2006-10-06 15:07 Anthony Green
2006-10-06 15:19 ` Anthony Green
0 siblings, 1 reply; 5+ messages in thread
From: Anthony Green @ 2006-10-06 15:07 UTC (permalink / raw)
To: classpath-patches, java-patches
[-- Attachment #1: Type: text/plain, Size: 147 bytes --]
I hit PR classpath/28070 again today (in FC5). I'd like to check this
patch into GNU Classpath, as well as GCC HEAD and the 4.1 branch. Ok?
AG
[-- Attachment #2: lm.patch --]
[-- Type: text/x-patch, Size: 1324 bytes --]
2006-10-06 Anthony Green <green@redhat.com>
PR classpath/28070:
* java/util/logging/LogManager.java: Don't share a control
permission object.
Index: java/util/logging/LogManager.java
===================================================================
RCS file: /sources/classpath/classpath/java/util/logging/LogManager.java,v
retrieving revision 1.24
diff -u -r1.24 LogManager.java
--- java/util/logging/LogManager.java 19 Sep 2006 10:41:45 -0000 1.24
+++ java/util/logging/LogManager.java 6 Oct 2006 15:02:49 -0000
@@ -787,13 +787,6 @@
}
/**
- * An instance of <code>LoggingPermission("control")</code>
- * that is shared between calls to <code>checkAccess()</code>.
- */
- private static final LoggingPermission controlPermission = new LoggingPermission("control",
- null);
-
- /**
* Checks whether the current security context allows changing
* the configuration of the logging framework. For the security
* context to be trusted, it has to be granted
@@ -807,7 +800,10 @@
{
SecurityManager sm = System.getSecurityManager();
if (sm != null)
- sm.checkPermission(controlPermission);
+ {
+ sm.checkPermission(new LoggingPermission("control",
+ null));
+ }
}
/**
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Patch: fix LogManager permission check
2006-10-06 15:07 Patch: fix LogManager permission check Anthony Green
@ 2006-10-06 15:19 ` Anthony Green
2006-10-06 15:45 ` Tom Tromey
0 siblings, 1 reply; 5+ messages in thread
From: Anthony Green @ 2006-10-06 15:19 UTC (permalink / raw)
To: classpath-patches; +Cc: java-patches
On Fri, 2006-10-06 at 08:07 -0700, Anthony Green wrote:
> I hit PR classpath/28070 again today (in FC5). I'd like to check this
> patch into GNU Classpath, as well as GCC HEAD and the 4.1 branch. Ok?
>
> AG
>
Ooops. This is a GCC 4.1 only bug. I withdraw my patch for GNU
Classpath. Still Ok for GCC 4.1 branch?
AG
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Patch: fix LogManager permission check
2006-10-06 15:19 ` Anthony Green
@ 2006-10-06 15:45 ` Tom Tromey
2006-10-06 15:52 ` Anthony Green
0 siblings, 1 reply; 5+ messages in thread
From: Tom Tromey @ 2006-10-06 15:45 UTC (permalink / raw)
To: Anthony Green; +Cc: classpath-patches, java-patches
>>>>> "Anthony" == Anthony Green <green@redhat.com> writes:
Anthony> Ooops. This is a GCC 4.1 only bug. I withdraw my patch for GNU
Anthony> Classpath. Still Ok for GCC 4.1 branch?
Yes.
Note that this doesn't appear on the RH 4.1 branch either. FWIW.
Tom
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Patch: fix LogManager permission check
2006-10-06 15:45 ` Tom Tromey
@ 2006-10-06 15:52 ` Anthony Green
2006-10-06 19:05 ` Tom Tromey
0 siblings, 1 reply; 5+ messages in thread
From: Anthony Green @ 2006-10-06 15:52 UTC (permalink / raw)
To: tromey; +Cc: java-patches
(I've removed classpath-patches from copy)
On Fri, 2006-10-06 at 09:38 -0600, Tom Tromey wrote:
>
>
> Note that this doesn't appear on the RH 4.1 branch either. FWIW.
You mean the static section isn't there? Was this changed recently?
The source in the gcc-debuginfo package for FC5 shows a static section
in LogManager.
AG
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Patch: fix LogManager permission check
2006-10-06 15:52 ` Anthony Green
@ 2006-10-06 19:05 ` Tom Tromey
0 siblings, 0 replies; 5+ messages in thread
From: Tom Tromey @ 2006-10-06 19:05 UTC (permalink / raw)
To: Anthony Green; +Cc: java-patches
Anthony> You mean the static section isn't there? Was this changed
Anthony> recently?
We did a big backport not too long ago, I don't remember looking at
this file specifically. But I think it did.
Anthony> The source in the gcc-debuginfo package for FC5 shows a
Anthony> static section in LogManager.
The RH 4.1 branch is FC6 now.
Tom
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2006-10-06 19:05 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-10-06 15:07 Patch: fix LogManager permission check Anthony Green
2006-10-06 15:19 ` Anthony Green
2006-10-06 15:45 ` Tom Tromey
2006-10-06 15:52 ` Anthony Green
2006-10-06 19:05 ` Tom Tromey
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).