On Tue, 2007-01-23 at 08:40 -0700, Tom Tromey wrote: > >>>>> "Andrew" == Andrew Pinski writes: > > Andrew> The problem here is that empty "zip" files in the classpath > Andrew> would cause leakage of file streams which meant after a while, > Andrew> we hit the limit of opened files. > > Nice catch, thanks. > > Andrew> OK? > > I think we should free 'zipf' in the 'return NULL' cases. > Ok with that change. And this is what I applied. Thanks, Andrew Pinski 2007-01-23 Andrew Pinski PR java/30454 * jcf-io.c (opendir_in_zip): Close the file and free zipf before returning after an error.