FYI: Fix typo in gst_native_pipeline.c

FYI: Fix typo in gst_native_pipeline.c

[Andrew John Hughes]

[-- Attachment #1: Type: text/plain, Size: 538 bytes --]

Compiling the GStreamer peer as part of GCJ spotted the following
typo:

ChangeLog:

2008-08-18  Andrew John Hughes  <gnu_andrew@member.fsf.org>

	* native/jni/gstreamer-peer/gst_native_pipeline.c:
	(get_free_space(int)): Use #else not #elif when
	there is no condition.

Okay for GCJ too?
-- 
Andrew :)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net
PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint = F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8

[-- Attachment #2: gstreamer-02.diff --]
[-- Type: text/plain, Size: 614 bytes --]

Index: native/jni/gstreamer-peer/gst_native_pipeline.c
===================================================================
RCS file: /sources/classpath/classpath/native/jni/gstreamer-peer/gst_native_pipeline.c,v
retrieving revision 1.3
diff -u -u -r1.3 gst_native_pipeline.c
--- native/jni/gstreamer-peer/gst_native_pipeline.c	27 Sep 2007 19:22:01 -0000	1.3
+++ native/jni/gstreamer-peer/gst_native_pipeline.c	18 Aug 2008 15:29:27 -0000
@@ -509,7 +509,7 @@
 
   result = GST_DETECTED_PIPE_CAPACITY - result;
   
-#elif
+#else
    g_warning("IMPLEMENT ME!!! - !defined (FIONSPACE), !defined (FIONREAD");
  
 #endif

Re: FYI: Fix typo in gst_native_pipeline.c

[Andrew Haley]

Andrew John Hughes wrote:
> Compiling the GStreamer peer as part of GCJ spotted the following
> typo:
> 
> ChangeLog:
> 
> 2008-08-18  Andrew John Hughes  <gnu_andrew@member.fsf.org>
> 
> 	* native/jni/gstreamer-peer/gst_native_pipeline.c:
> 	(get_free_space(int)): Use #else not #elif when
> 	there is no condition.
> 
> Okay for GCJ too?

Yes.  You didn't have to ask: trivial/obvious.

Andrew.

Re: FYI: Fix typo in gst_native_pipeline.c

[Andrew John Hughes]

On 18/08/2008, Andrew Haley <aph@redhat.com> wrote:
> Andrew John Hughes wrote:
>  > Compiling the GStreamer peer as part of GCJ spotted the following
>  > typo:
>  >
>  > ChangeLog:
>  >
>  > 2008-08-18  Andrew John Hughes  <gnu_andrew@member.fsf.org>
>  >
>  >       * native/jni/gstreamer-peer/gst_native_pipeline.c:
>  >       (get_free_space(int)): Use #else not #elif when
>  >       there is no condition.
>  >
>  > Okay for GCJ too?
>
>
> Yes.  You didn't have to ask: trivial/obvious.
>
>
>  Andrew.
>
>

Ok, that was my first instinct with this one, but wanted to be sure as
I'm still new to GCJ commits.

I've committed it to the merge tree for eventual inclusion in trunk.
What other branches, if any, should get this fix?

Thanks,
-- 
Andrew :-)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net

PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8

Re: FYI: Fix typo in gst_native_pipeline.c

[Tom Tromey]

>>>>> "Andrew" == Andrew John Hughes <gnu_andrew@member.fsf.org> writes:

Andrew> I've committed it to the merge tree for eventual inclusion in trunk.
Andrew> What other branches, if any, should get this fix?

Any ones that don't build.  I haven't heard reports about this, so
maybe the other branches are ok.

Tom

Re: [cp-patches] FYI: Fix typo in gst_native_pipeline.c

[Mario Torre]

Il giorno lun, 18/08/2008 alle 17.36 +0100, Andrew John Hughes ha
scritto:
> Compiling the GStreamer peer as part of GCJ spotted the following
> typo:
> 
> ChangeLog:
> 
> 2008-08-18  Andrew John Hughes  <gnu_andrew@member.fsf.org>
> 
> 	* native/jni/gstreamer-peer/gst_native_pipeline.c:
> 	(get_free_space(int)): Use #else not #elif when
> 	there is no condition.
> 
> Okay for GCJ too?

Cool, so this thingy is used now!

I have many pending fixes there (and some new stuff), hopefully I will
work on this in the next days time permitting, but if you spot errors,
please ping me.

Mario
-- 
Mario Torre, Software Developer, http://www.jroller.com/neugens/
aicas Allerton Interworks Computer Automated Systems GmbH
Haid-und-Neu-Straße 18 * D-76131 Karlsruhe * Germany
http://www.aicas.com   * Tel: +49-721-663 968-53
pgp key: http://subkeys.pgp.net/ PGP Key ID: 80F240CF
Fingerprint: BA39 9666 94EC 8B73 27FA  FC7C 4086 63E3 80F2 40CF

USt-Id: DE216375633, Handelsregister HRB 109481, AG Mannheim
Geschäftsführer: Dr. James J. Hunt

Please, support open standards:
http://opendocumentfellowship.org/petition/
http://www.nosoftwarepatents.com/