From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10722 invoked by alias); 9 Jul 2014 10:58:08 -0000 Mailing-List: contact java-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: java-patches-owner@gcc.gnu.org Received: (qmail 10656 invoked by uid 89); 9 Jul 2014 10:58:04 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.0 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 09 Jul 2014 10:58:03 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s69Aw1WO009530 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 9 Jul 2014 06:58:01 -0400 Received: from [10.36.116.108] (ovpn-116-108.ams2.redhat.com [10.36.116.108]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s69AvxH5030252; Wed, 9 Jul 2014 06:58:00 -0400 Subject: Re: [PATCH] java: Use build_qualified_type instead of build_type_variant. From: Mark Wielaard To: Richard Biener Cc: GCC Patches , GCJ-patches , Tom Tromey In-Reply-To: References: <1404850329-16974-1-git-send-email-mjw@redhat.com> Content-Type: text/plain; charset="UTF-8" Date: Wed, 09 Jul 2014 10:58:00 -0000 Message-ID: <1404903479.8859.16.camel@bordewijk.wildebeest.org> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-q3/txt/msg00006.txt.bz2 On Wed, 2014-07-09 at 12:23 +0200, Richard Biener wrote: > On Tue, Jul 8, 2014 at 10:12 PM, Mark Wielaard wrote: > > The java frontend is one of the only places where build_type_variant is > > still used. New code should use build_qualified_type. See gcc/tree.h. > > > > Build and tested on x86_64-unknown-linux-gnu. > > Ok. Thanks. Pushed. > Can build_type_variant be removed now? Not yet. There are still a few usages that are easy to change to build_qualified_type like the ones in the java frontend. But there are 3 cases that I haven't figured out yet. c-common, ada and lto all use it in their implementation of handle_noreturn_attribute and c-common and lto in handle_const_attribute. I think the c-common one is correct, but maybe there is a reason for them to be slightly different. Cheers, Mark