From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19655 invoked by alias); 2 Jul 2013 19:04:46 -0000 Mailing-List: contact java-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: java-patches-owner@gcc.gnu.org Received: (qmail 19626 invoked by uid 89); 2 Jul 2013 19:04:41 -0000 X-Spam-SWARE-Status: No, score=-5.9 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 Received: from mx3-phx2.redhat.com (HELO mx3-phx2.redhat.com) (209.132.183.24) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 02 Jul 2013 19:04:40 +0000 Received: from zmail13.collab.prod.int.phx2.redhat.com (zmail13.collab.prod.int.phx2.redhat.com [10.5.83.15]) by mx3-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r62J4chw000399; Tue, 2 Jul 2013 15:04:39 -0400 Date: Tue, 02 Jul 2013 19:04:00 -0000 From: Jon VanAlten To: Matthias Klose Cc: GCJ-patches , Tom Tromey , Andrew Haley Message-ID: <1437863721.2322487.1372791878657.JavaMail.root@redhat.com> In-Reply-To: <51D29F0E.2000400@ubuntu.com> References: <516BD4B9.8040101@ubuntu.com> <51C2F7FA.9000101@ubuntu.com> <1465929016.3776725.1372274627134.JavaMail.root@redhat.com> <51D29F0E.2000400@ubuntu.com> Subject: Re: ping: Re: [patch] update ecj to ecj-3.8.2/4.2.2 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-q3/txt/msg00001.txt.bz2 ----- Original Message ----- > From: "Matthias Klose" > To: "Jon VanAlten" > Cc: "GCJ-patches" , "Tom Tromey" , "Andrew Haley" > Sent: Tuesday, July 2, 2013 3:36:14 AM > Subject: Re: ping: Re: [patch] update ecj to ecj-3.8.2/4.2.2 > > On 06/26/13 21:23, Jon VanAlten wrote: > > > > checkout: > > - cvs -d $(cvsroot) co -r$(TAG) org.eclipse.jdt.core > > +# git clone -b R3_8_maintenance > > git://git.eclipse.org/gitroot/jdt/eclipse.jdt.core.git > > +# wget > > http://git.eclipse.org/c/jdt/eclipse.jdt.core.git/snapshot/$(TAG).tar.gz > > + tar xf $(TAG).tar.gz > > > > So "checkout" target no longer does a checkout... seems a bit off. Is > > the commented git clone line left over from doing some of this before > > the official tag existed? Might want to drop that, and consider > > renaming the target to reflect its new behaviour. > > sure, I can rename that. any suggestion? The purpose is to make it clear > where > the source do come from. If my reading of this is correct, this make target now does some moving about of things that are already checked out into the local filesystem. My suggestion would be to call it "prepare-sources" or just "prepare". > > > + tar -c -f - -C $(TAG)/org.eclipse.jdt.core/compiler org \ > > + | tar -x -f - -C org.eclipse.jdt.core/ > > > > Am I missing something or is this equivalent and simpler: > > > > + mv $(TAG)/org.eclipse.jdt.core/compiler/org org.eclipse.jdt.core/ > > > > + tar -c -f - -C $(TAG)/org.eclipse.jdt.core/batch org \ > > + | tar -x -f - -C org.eclipse.jdt.core/ > > > > Ditto. > > yes, not having to run the checkout / pull from the web again. > Right, so doing it as "cp -ar" instead of a "mv" would accomplish same? > > As for the GCCMain portion of the change, yes it looks both necessary > > and correct. We do same in Fedora package (once again sorry it didn't > > get posted upstream due to my ignorance), and it would be nice to drop > > the patch once this is in a release. > > yes, having this upstream would be appreciated. > > So besides the style how to do fetch the sources, this looks ok? > Yep. > Is there another newer released ecj version which should be used instead? > Let's check the authoritative source[1] for that. It does seem as though they've done their 4.3 release, the sources for just ecj can be found under JDT Core Batch Compiler at [2]. News[3] does mention a few compiler improvements, but I might suggest to first push update to 3.8 and then update to latest in separate commit (so anyone else who consumes this can choose the version they prefer). cheers, jon [1] http://download.eclipse.org/eclipse/downloads/ [2] http://download.eclipse.org/eclipse/downloads/drops4/R-4.3-201306052000/ [3] http://download.eclipse.org/eclipse/downloads/drops4/R-4.3-201306052000/news/eclipse-news-part2.html