* [hjl@lucon.org: PATCH: libgcj/25840: [4.2 Regression] libjava is broken on Linux/x86-64]
@ 2006-01-18 19:48 H. J. Lu
2006-01-18 19:55 ` Andrew Pinski
0 siblings, 1 reply; 4+ messages in thread
From: H. J. Lu @ 2006-01-18 19:48 UTC (permalink / raw)
To: java-patches
----- Forwarded message from "H. J. Lu" <hjl@lucon.org> -----
Date: Wed, 18 Jan 2006 11:46:28 -0800
From: "H. J. Lu" <hjl@lucon.org>
To: gcc-patches@gcc.gnu.org
Subject: PATCH: libgcj/25840: [4.2 Regression] libjava is broken on Linux/x86-64
User-Agent: Mutt/1.4.2.1i
".text\n" is missing from RESTORE2 in include/x86_64-signal.h. I am
testing it now.
H.J.
---
2006-01-18 H.J. Lu <hongjiu.lu@intel.com>
PR libgcj/25840
* include/x86_64-signal.h (RESTORE2): Add ".text\n".
--- libjava/include/x86_64-signal.h.switch 2005-11-01 13:57:46.000000000 -0800
+++ libjava/include/x86_64-signal.h 2006-01-18 11:40:42.000000000 -0800
@@ -50,6 +50,7 @@ while (0)
#define RESTORE2(name, syscall) \
asm \
( \
+ ".text\n" \
".byte 0 # Yes, this really is necessary\n" \
".align 16\n" \
"__" #name ":\n" \
----- End forwarded message -----
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [hjl@lucon.org: PATCH: libgcj/25840: [4.2 Regression] libjava is broken on Linux/x86-64]
2006-01-18 19:48 [hjl@lucon.org: PATCH: libgcj/25840: [4.2 Regression] libjava is broken on Linux/x86-64] H. J. Lu
@ 2006-01-18 19:55 ` Andrew Pinski
2006-01-18 20:06 ` H. J. Lu
0 siblings, 1 reply; 4+ messages in thread
From: Andrew Pinski @ 2006-01-18 19:55 UTC (permalink / raw)
To: H. J. Lu; +Cc: java-patches, gcc-patches
> Date: Wed, 18 Jan 2006 11:46:28 -0800
> From: "H. J. Lu" <hjl@lucon.org>
> To: gcc-patches@gcc.gnu.org
> Subject: PATCH: libgcj/25840: [4.2 Regression] libjava is broken on Linux/x86-64
> User-Agent: Mutt/1.4.2.1i
>
> ".text\n" is missing from RESTORE2 in include/x86_64-signal.h. I am
> testing it now.
>
> H.J.
> ---
> 2006-01-18 H.J. Lu <hongjiu.lu@intel.com>
>
> PR libgcj/25840
> * include/x86_64-signal.h (RESTORE2): Add ".text\n".
Note I think this is obvious once testing has finished and shows that this fixes
the problem.
Also I should note that more documentation about toplevel asm should include information
like this.
Thanks,
Andrew Pinski
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [hjl@lucon.org: PATCH: libgcj/25840: [4.2 Regression] libjava is broken on Linux/x86-64]
2006-01-18 19:55 ` Andrew Pinski
@ 2006-01-18 20:06 ` H. J. Lu
2006-01-19 12:10 ` Andrew Haley
0 siblings, 1 reply; 4+ messages in thread
From: H. J. Lu @ 2006-01-18 20:06 UTC (permalink / raw)
To: Andrew Pinski; +Cc: java-patches, gcc-patches
On Wed, Jan 18, 2006 at 02:55:51PM -0500, Andrew Pinski wrote:
> > Date: Wed, 18 Jan 2006 11:46:28 -0800
> > From: "H. J. Lu" <hjl@lucon.org>
> > To: gcc-patches@gcc.gnu.org
> > Subject: PATCH: libgcj/25840: [4.2 Regression] libjava is broken on Linux/x86-64
> > User-Agent: Mutt/1.4.2.1i
> >
> > ".text\n" is missing from RESTORE2 in include/x86_64-signal.h. I am
> > testing it now.
> >
> > H.J.
> > ---
> > 2006-01-18 H.J. Lu <hongjiu.lu@intel.com>
> >
> > PR libgcj/25840
> > * include/x86_64-signal.h (RESTORE2): Add ".text\n".
>
> Note I think this is obvious once testing has finished and shows that this fixes
> the problem.
>
Test is OK with my patch. I checked it into mainline. Should I update
4.1, 4.0 and 3.4?
H.J.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [hjl@lucon.org: PATCH: libgcj/25840: [4.2 Regression] libjava is broken on Linux/x86-64]
2006-01-18 20:06 ` H. J. Lu
@ 2006-01-19 12:10 ` Andrew Haley
0 siblings, 0 replies; 4+ messages in thread
From: Andrew Haley @ 2006-01-19 12:10 UTC (permalink / raw)
To: H. J. Lu; +Cc: Andrew Pinski, java-patches, gcc-patches
H. J. Lu writes:
> On Wed, Jan 18, 2006 at 02:55:51PM -0500, Andrew Pinski wrote:
> > > Date: Wed, 18 Jan 2006 11:46:28 -0800
> > > From: "H. J. Lu" <hjl@lucon.org>
> > > To: gcc-patches@gcc.gnu.org
> > > Subject: PATCH: libgcj/25840: [4.2 Regression] libjava is broken on Linux/x86-64
> > > User-Agent: Mutt/1.4.2.1i
> > >
> > > ".text\n" is missing from RESTORE2 in include/x86_64-signal.h. I am
> > > testing it now.
> > >
> > > H.J.
> > > ---
> > > 2006-01-18 H.J. Lu <hongjiu.lu@intel.com>
> > >
> > > PR libgcj/25840
> > > * include/x86_64-signal.h (RESTORE2): Add ".text\n".
> >
> > Note I think this is obvious once testing has finished and shows that this fixes
> > the problem.
>
> Test is OK with my patch. I checked it into mainline. Should I update
> 4.1, 4.0 and 3.4?
Yes, thanks.
Andrew.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2006-01-19 12:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-01-18 19:48 [hjl@lucon.org: PATCH: libgcj/25840: [4.2 Regression] libjava is broken on Linux/x86-64] H. J. Lu
2006-01-18 19:55 ` Andrew Pinski
2006-01-18 20:06 ` H. J. Lu
2006-01-19 12:10 ` Andrew Haley
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).