public inbox for java-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Andrew Haley <aph@redhat.com>
To: Andrew Pinski <pinskia@physics.uc.edu>
Cc: java-patches@gcc.gnu.org, gcc-patches@gcc.gnu.org
Subject: Re: Calls to built-in functions are not Binary Compatible
Date: Wed, 01 Mar 2006 18:43:00 -0000	[thread overview]
Message-ID: <17413.60372.739306.990827@zapata.pink> (raw)
In-Reply-To: <200603011833.k21IXT7B009360@earth.phy.uc.edu>

Andrew Pinski writes:
 > > 
 > > This happens with methods like Math.pow() which are converted to
 > > builtins.  Unfortunately, this leads to direct calls to methods in
 > > libgcj.  This breaks binary compatibility when we change gcj's name
 > > mangling.  Which we just did.
 > 
 > Aren't those direct function calls to libc functions

On some platforms the libc functions wouldn't be sufficiently
accurate.

 > though so they really don't have an effect from gcj's name
 > mangling?

They don't seem to be, no.  AFAIK the only purpose of the
builtins is to expose the possibility of constant propagation and
simplification, and (on x86) use of builtin instructions.

Given that libgcj has its own versions of these builtins, perhaps they
should be called directly rather than via the CNI stubs.  That would
be more efficient that what we do at the present time and solve the
mangling problem.

Andrew.

  reply	other threads:[~2006-03-01 18:43 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-03-01 18:29 Andrew Haley
2006-03-01 18:33 ` Andrew Pinski
2006-03-01 18:43   ` Andrew Haley [this message]
2006-03-01 22:36   ` Tom Tromey
2006-03-03 22:05 ` Bryce McKinlay
2006-03-04 10:41   ` Andrew Haley
2006-03-04 10:55     ` Andrew Haley
2006-03-06 18:49       ` Tom Tromey
2006-03-06 18:51         ` Andrew Haley
2006-03-06 16:02     ` Bryce McKinlay
2006-03-06 16:12       ` Andrew Haley
2006-03-06 19:03         ` Bryce McKinlay

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=17413.60372.739306.990827@zapata.pink \
    --to=aph@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=java-patches@gcc.gnu.org \
    --cc=pinskia@physics.uc.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).