* PR java/27908: Honour volatile
@ 2006-06-08 14:12 Andrew Haley
2006-06-08 18:11 ` Andrew Haley
0 siblings, 1 reply; 2+ messages in thread
From: Andrew Haley @ 2006-06-08 14:12 UTC (permalink / raw)
To: gcc-patches, java-patches
We weren't setting TREE_THIS_VOLATILE on fields.
Committed to trunk and 4.1 branch.
Andrew.
2006-06-07 Andrew Haley <aph@redhat.com>
PR java/27908
* class.c (add_field): Set TREE_THIS_VOLATILE on fields.
Index: gcc/java/class.c
===================================================================
--- gcc/java/class.c (revision 114388)
+++ gcc/java/class.c (working copy)
@@ -785,7 +785,11 @@
if (flags & ACC_PROTECTED) FIELD_PROTECTED (field) = 1;
if (flags & ACC_PRIVATE) FIELD_PRIVATE (field) = 1;
if (flags & ACC_FINAL) FIELD_FINAL (field) = 1;
- if (flags & ACC_VOLATILE) FIELD_VOLATILE (field) = 1;
+ if (flags & ACC_VOLATILE)
+ {
+ FIELD_VOLATILE (field) = 1;
+ TREE_THIS_VOLATILE (field) = 1;
+ }
if (flags & ACC_TRANSIENT) FIELD_TRANSIENT (field) = 1;
if (is_static)
{
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: PR java/27908: Honour volatile
2006-06-08 14:12 PR java/27908: Honour volatile Andrew Haley
@ 2006-06-08 18:11 ` Andrew Haley
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Haley @ 2006-06-08 18:11 UTC (permalink / raw)
To: gcc-patches, java-patches
Andrew Haley writes:
> We weren't setting TREE_THIS_VOLATILE on fields.
>
> Committed to trunk and 4.1 branch.
No it wasn't.
Testing reveasled that while this patch produces the correct result on
trunk, it fails on 4.1 branch. I'm investigating.
Andrew.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-06-08 18:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-06-08 14:12 PR java/27908: Honour volatile Andrew Haley
2006-06-08 18:11 ` Andrew Haley
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).