* fix PR28546
@ 2006-08-01 20:23 Andreas Tobler
2006-08-01 21:59 ` Tom Tromey
0 siblings, 1 reply; 4+ messages in thread
From: Andreas Tobler @ 2006-08-01 20:23 UTC (permalink / raw)
To: Java Patches
Hello all,
this should fix the PR in the subject.
ok for trunk?
Thanks,
Andreas
2006-08-01 Andreas Tobler <a.tobler@schweiz.ch>
PR libgcj/28546
* include/no-threads.h: Typdef _Jv_Thread_t to class.
Index: include/no-threads.h
===================================================================
--- include/no-threads.h (revision 115850)
+++ include/no-threads.h (working copy)
@@ -25,7 +25,7 @@
typedef int _Jv_ConditionVariable_t;
typedef int _Jv_Mutex_t;
-typedef int _Jv_Thread_t;
+typedef class _Jv_Thread_t;
typedef void _Jv_ThreadStartFunc (java::lang::Thread *);
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: fix PR28546
2006-08-01 20:23 fix PR28546 Andreas Tobler
@ 2006-08-01 21:59 ` Tom Tromey
2006-08-02 20:07 ` Andreas Tobler
0 siblings, 1 reply; 4+ messages in thread
From: Tom Tromey @ 2006-08-01 21:59 UTC (permalink / raw)
To: Andreas Tobler; +Cc: Java Patches
>>>>> "Andreas" == Andreas Tobler <toa@pop.agri.ch> writes:
Andreas> PR libgcj/28546
Andreas> * include/no-threads.h: Typdef _Jv_Thread_t to class.
This seems weird since there is no actual definition of the class.
Can't we just do:
class _Jv_Thread_t { };
?
Tom
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: fix PR28546
2006-08-01 21:59 ` Tom Tromey
@ 2006-08-02 20:07 ` Andreas Tobler
2006-08-02 20:10 ` Tom Tromey
0 siblings, 1 reply; 4+ messages in thread
From: Andreas Tobler @ 2006-08-02 20:07 UTC (permalink / raw)
To: tromey; +Cc: Java Patches
Tom Tromey wrote:
>>>>>> "Andreas" == Andreas Tobler <toa@pop.agri.ch> writes:
>
> Andreas> PR libgcj/28546
> Andreas> * include/no-threads.h: Typdef _Jv_Thread_t to class.
>
> This seems weird since there is no actual definition of the class.
>
> Can't we just do:
>
> class _Jv_Thread_t { };
>
Hm, it works with the below.
Ok?
Thanks for review!
Andreas
2006-08-02 Andreas Tobler <a.tobler@schweiz.ch>
PR libgcj/28546
* include/no-threads.h: Declare _Jv_Thread_t as empty class.
Index: no-threads.h
===================================================================
--- no-threads.h (revision 115863)
+++ no-threads.h (working copy)
@@ -1,7 +1,7 @@
// -*- c++ -*-
// no-threads.h - Defines for using no threads.
-/* Copyright (C) 1998, 1999, 2004 Free Software Foundation
+/* Copyright (C) 1998, 1999, 2004, 2006 Free Software Foundation
This file is part of libgcj.
@@ -25,10 +25,14 @@
typedef int _Jv_ConditionVariable_t;
typedef int _Jv_Mutex_t;
-typedef int _Jv_Thread_t;
typedef void _Jv_ThreadStartFunc (java::lang::Thread *);
+//
+// Declarations
+//
+class _Jv_Thread_t { };
+
//
// Condition variables.
//
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: fix PR28546
2006-08-02 20:07 ` Andreas Tobler
@ 2006-08-02 20:10 ` Tom Tromey
0 siblings, 0 replies; 4+ messages in thread
From: Tom Tromey @ 2006-08-02 20:10 UTC (permalink / raw)
To: Andreas Tobler; +Cc: tromey, Java Patches
>>>>> "Andreas" == Andreas Tobler <toa@pop.agri.ch> writes:
Andreas> Hm, it works with the below.
Andreas> Ok?
Yes, thanks.
Tom
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2006-08-02 20:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-08-01 20:23 fix PR28546 Andreas Tobler
2006-08-01 21:59 ` Tom Tromey
2006-08-02 20:07 ` Andreas Tobler
2006-08-02 20:10 ` Tom Tromey
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).