From: Andrew Haley <aph@redhat.com>
To: David Daney <ddaney@avtrex.com>
Cc: java-patches@gcc.gnu.org, gbenson@redhat.com
Subject: Re: FYI: Win32 InetAddress fix (really)
Date: Tue, 03 Oct 2006 16:55:00 -0000 [thread overview]
Message-ID: <17698.38378.993886.203823@zebedee.pink> (raw)
In-Reply-To: <45227D4F.1000906@avtrex.com>
David Daney writes:
> Gary Benson wrote:
> > + // Some soon-to-be-removed native code synchronizes on this.
> > + loopbackAddress = LOCALHOST;
> > + }
> > + catch (UnknownHostException e)
> > + {
> > + throw new RuntimeException("should never happen", e);
> > + }
> >
> Would it be better to throw an InternalError here rather than
> RuntimeException? If it truly should never happen then it would be an
> InternalError if it did. If it can happen, then it should be of some
> type the describes the problem.
AFAICR this is the kind of thing that happens if the IP address of the
loopback interface doesn't have a resolvable name,
Andrew.
next prev parent reply other threads:[~2006-10-03 16:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-04 14:15 RFC: Untested Win32 InetAddress tweak Gary Benson
2006-09-06 16:58 ` Tom Tromey
2006-09-07 7:36 ` Gary Benson
2006-10-01 17:36 ` Marco Trudel
2006-10-01 18:00 ` Mohan Embar
2006-10-02 7:19 ` Marco Trudel
2006-10-02 10:55 ` FYI: Win32 InetAddress fix Gary Benson
2006-10-02 11:22 ` Marco Trudel
2006-10-02 17:43 ` Tom Tromey
2006-10-03 10:35 ` FYI: Win32 InetAddress fix (really) Gary Benson
2006-10-03 15:10 ` David Daney
2006-10-03 16:55 ` Andrew Haley [this message]
2006-10-03 17:23 ` David Daney
2006-10-04 8:37 ` Gary Benson
2006-10-03 15:30 ` Marco Trudel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17698.38378.993886.203823@zebedee.pink \
--to=aph@redhat.com \
--cc=ddaney@avtrex.com \
--cc=gbenson@redhat.com \
--cc=java-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).