From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <java-patches-return-17562-listarch-java-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 21486 invoked by alias); 12 Jan 2007 12:18:09 -0000
Received: (qmail 21476 invoked by uid 22791); 12 Jan 2007 12:18:09 -0000
X-Spam-Check-By: sourceware.org
Received: from mx2.redhat.com (HELO mx2.redhat.com) (66.187.237.31)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 12 Jan 2007 12:18:04 +0000
Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) 	by mx2.redhat.com (8.12.11.20060308/8.12.11) with ESMTP id l0CCI2T6032727 	for <java-patches@gcc.gnu.org>; Fri, 12 Jan 2007 07:18:02 -0500
Received: from zebedee.littlepinkcloud.COM (vpn-14-57.rdu.redhat.com [10.11.14.57]) 	by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id l0CCHxJC009520; 	Fri, 12 Jan 2007 07:18:00 -0500
Received: from littlepinkcloud.COM (localhost.localdomain [127.0.0.1]) 	by zebedee.littlepinkcloud.COM (8.13.6/8.13.5) with ESMTP id l0CCHwvs032074; 	Fri, 12 Jan 2007 12:17:59 GMT
Received: (from aph@localhost) 	by littlepinkcloud.COM (8.13.6/8.13.5/Submit) id l0CCHvux032071; 	Fri, 12 Jan 2007 12:17:57 GMT
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <17831.31861.849673.389800@zebedee.pink>
Date: Fri, 12 Jan 2007 12:18:00 -0000
From: Andrew Haley <aph@redhat.com>
To: Keith Seitz <keiths@redhat.com>
Cc: Java Patch List <java-patches@gcc.gnu.org>
Subject: Re: [RFA/JDWP] VMVirtualMachine StringBuffer cleanup
In-Reply-To: <45A6E7D2.2030306@redhat.com>
References: <4552294E.1070500@redhat.com> 	<45A6E7D2.2030306@redhat.com>
X-Mailer: VM 7.19 under Emacs 21.4.1
X-IsSubscribed: yes
Mailing-List: contact java-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <java-patches.gcc.gnu.org>
List-Subscribe: <mailto:java-patches-subscribe@gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/java-patches/>
List-Post: <mailto:java-patches@gcc.gnu.org>
List-Help: <mailto:java-patches-help@gcc.gnu.org>, <http://gcc.gnu.org/ml/#faqs>
Sender: java-patches-owner@gcc.gnu.org
X-SW-Source: 2007-q1/txt/msg00039.txt.bz2

Keith Seitz writes:
 > Post-merge ping.
 > 
 > Keith
 > 
 > Keith Seitz wrote:
 > > Hi,
 > > 
 > > I've been meaning to cleanup a lot of the gnu/classpath/jdwp/nat*.cc 
 > > files, and this is one of the things that made it onto my pet peeve list 
 > > recently. The attached patch switches to the 
 > > gnu.gcj.runtime.StringBuffer instead of the java.lang one.
 > > 
 > > I've got some other little cleanups that I'll submit after this.
 > > 
 > > Keith
 > > 
 > > ChangeLog
 > > 2006-11-08  Keith Seitz  <keiths@redhat.com>
 > > 
 > >         * gnu/classpath/jdwp/natVMVirtualMachine.cc (suspendThread): Use
 > >         gnu.gcj.runtime.StringBuffer instead of java.lang.StringBuffer.
 > >         (resumeThread): Likewise.

Use java.lang.StringBuilder instead of gnu.gcj.runtime.StringBuffer.
Patch approved with that change.

Andrew.