From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9551 invoked by alias); 27 Jul 2009 22:55:38 -0000 Received: (qmail 9535 invoked by uid 22791); 27 Jul 2009 22:55:37 -0000 X-SWARE-Spam-Status: No, hits=-0.4 required=5.0 tests=AWL,BAYES_00,J_CHICKENPOX_12,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail-fx0-f213.google.com (HELO mail-fx0-f213.google.com) (209.85.220.213) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 27 Jul 2009 22:55:28 +0000 Received: by fxm9 with SMTP id 9so936097fxm.8 for ; Mon, 27 Jul 2009 15:55:25 -0700 (PDT) MIME-Version: 1.0 Received: by 10.204.120.193 with SMTP id e1mr3594680bkr.147.1248735325237; Mon, 27 Jul 2009 15:55:25 -0700 (PDT) In-Reply-To: <4A5CB229.9030400@bluewin.ch> References: <20090630124346.GX4462@tyan-ft48-01.lab.bos.redhat.com> <4A4A2623.9010609@redhat.com> <20090630152911.GA4462@tyan-ft48-01.lab.bos.redhat.com> <4A4B5883.4050905@redhat.com> <20090712203554.GD4462@tyan-ft48-01.lab.bos.redhat.com> <4A5CB229.9030400@bluewin.ch> Date: Mon, 27 Jul 2009 22:55:00 -0000 Message-ID: <17c6771e0907271555v4eeae876se3f8dbc4268a08e6@mail.gmail.com> Subject: Re: [cp-patches] Split gnu/javax/swing/text/html/parser/HTML_401F.java From: Andrew John Hughes To: Audrius Meskauskas Cc: Jakub Jelinek , Gerald Pfeifer , Richard Henderson , Java Patch List , Alexandre Oliva , gcc-patches@gcc.gnu.org, classpath-patches ml Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact java-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: java-patches-owner@gcc.gnu.org X-SW-Source: 2009-q3/txt/msg00057.txt.bz2 2009/7/14 Audrius Meskauskas : > On Sun, Jul 12, 2009 at 10:27:07PM +0200, Gerald Pfeifer wrote: > >> > On Wed, 1 Jul 2009, Andrew Haley wrote: >> >>>> >>>> > >> I haven't studied how exactly is --enable-java-maintainer-mode >>>> > >> compiling the classes; if I just gcj -C HTML_401F.java on >>>> > >> Fedora 11 (GCC 4.4.0, ecj 3.4.2), the compile time with patched >>>> > >> VTA is only 4:53 with 1.5GB top memory usage, if I patch >>>> > >> HTML_401F.java >>>> > >> with the following patch, it compiles within 0:55 and maxes at >>>> > >> 250MB. >>>> >> >> > > That's quite a nice improvement. =C2=A0HTML_401F.java has been causi= ng > >> > > troubles for many years, and splitting it really helps, for example >> > building on (virtual) machines with not so much main memory or in >> > limited settings where there is a process limit for 512MB. >> > >>> >>> > > It's not an ABI change. =C2=A0This patch is OK iff accompanied by a >>> > > comment in the code that explains the problem. >>> >> >> > > I believe the patch has not made it into GCC Subversion yet. =C2=A0A= re >> > the two of you still planning to apply it? >> > > See http://gcc.gnu.org/viewcvs?root=3Dgcc&view=3Drev&rev=3D149148 > > =C2=A0 =C2=A0 =C2=A0 =C2=A0Jakub > > > > > > Masters, where is the beginning of this discussion and where is the propo= sed > patch? I have received four messages about HTML_401F that look completely= in > the middle of the context. While it is great when somebody continues your > work, I think it would make no harm for me to look into the patch on the > class I once wrote. > > Audrius Meskauskas > > Audrius, the patch is visible from the link posted by Jakub: http://gcc.gnu.org/viewcvs?root=3Dgcc&view=3Drev&rev=3D149148 It simply splits the method which defines the entities into five separate methods to reduce load on the compiler. Is this generally useful? If so, it should go into GNU Classpath rather than just the downstream copy in GCJ. --=20 Andrew :-) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and the OpenJDK http://www.gnu.org/software/classpath http://openjdk.java.net PGP Key: 94EFD9D8 (http://subkeys.pgp.net) Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8