From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24151 invoked by alias); 30 Aug 2009 16:08:44 -0000 Received: (qmail 24139 invoked by uid 22791); 30 Aug 2009 16:08:43 -0000 X-SWARE-Spam-Status: No, hits=-0.4 required=5.0 tests=AWL,BAYES_00,J_CHICKENPOX_12,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from an-out-0708.google.com (HELO an-out-0708.google.com) (209.85.132.248) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 30 Aug 2009 16:08:33 +0000 Received: by an-out-0708.google.com with SMTP id c3so1275098ana.26 for ; Sun, 30 Aug 2009 09:08:31 -0700 (PDT) MIME-Version: 1.0 Received: by 10.101.86.13 with SMTP id o13mr4008071anl.184.1251648510673; Sun, 30 Aug 2009 09:08:30 -0700 (PDT) In-Reply-To: <4A9A1DBD.4010208@gmail.com> References: <4A9A1DBD.4010208@gmail.com> Date: Mon, 31 Aug 2009 18:49:00 -0000 Message-ID: <17c6771e0908300908s7880bf34p1b9e4a271a2820a0@mail.gmail.com> Subject: Re: Some patches to break dependencies in libgcj From: Andrew John Hughes To: David Daney Cc: java-patches@gcc.gnu.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact java-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: java-patches-owner@gcc.gnu.org X-SW-Source: 2009-q3/txt/msg00096.txt.bz2 2009/8/30 David Daney : > Attached are some patches I developed to break some dependencies in libgc= j. > =C2=A0The use case I was addressing was to minimize executable size with > -static-libgcj, but the patches may be interesting in other contexts. =C2= =A0I > don't plan on committing these myself, but if others are interested in > testing and committing them or using them as the basis for other work, fe= el > free to do so. > > David Daney > > > I think the first three should be applied to Classpath (if at all) rather than creating further divergence in gcj. The first patch seems ok, though it does make the class more susceptible to changes in package naming (at present, it would break at compile time, with the patch it would require a runtime check). The changes in the second patch seem to be lost in whitespace adjustments. With the third patch, I wonder if we couldn't just supply the default implementation via META-INF and remove that instantiation altogether. I'll leave comments on the fourth patch to those who know the gcj makefiles better than I do :) --=20 Andrew :-) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and the OpenJDK http://www.gnu.org/software/classpath http://openjdk.java.net PGP Key: 94EFD9D8 (http://subkeys.pgp.net) Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8