Unreviewed patches

Unreviewed patches

[Rainer Orth]

The following libjava patches have remained unreviewed for more than a
week:

	PATCH: Avoid command line length limit building tools.zip (PR libgcj/38251)
	http://gcc.gnu.org/ml/java-patches/2010-q1/msg00021.html


        PATCH: Enable interpreter for IRIX 6
        http://gcc.gnu.org/ml/java-patches/2010-q1/msg00022.html

Ok for mainline?

	Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University

Re: Unreviewed patches

[Andrew Haley]

On 01/29/2010 03:39 PM, Rainer Orth wrote:
> The following libjava patches have remained unreviewed for more than a
> week:
> 
> 	PATCH: Avoid command line length limit building tools.zip (PR libgcj/38251)
> 	http://gcc.gnu.org/ml/java-patches/2010-q1/msg00021.html
> 
> 
>         PATCH: Enable interpreter for IRIX 6
>         http://gcc.gnu.org/ml/java-patches/2010-q1/msg00022.html
> 
> Ok for mainline?

OK, thanks.

Andrew.

Re: Unreviewed patches

[Andrew John Hughes]

On 29 January 2010 15:39, Rainer Orth <ro@cebitec.uni-bielefeld.de> wrote:
> The following libjava patches have remained unreviewed for more than a
> week:
>
>        PATCH: Avoid command line length limit building tools.zip (PR libgcj/38251)
>        http://gcc.gnu.org/ml/java-patches/2010-q1/msg00021.html
>

This one needs to go in upstream GNU Classpath too by the looks of it.

>
>        PATCH: Enable interpreter for IRIX 6
>        http://gcc.gnu.org/ml/java-patches/2010-q1/msg00022.html
>
> Ok for mainline?
>
>        Rainer
>
> --
> -----------------------------------------------------------------------------
> Rainer Orth, Center for Biotechnology, Bielefeld University
>



-- 
Andrew :-)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net

PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8

Re: Unreviewed patches

[Rainer Orth]

Andrew John Hughes <gnu_andrew@member.fsf.org> writes:

> On 29 January 2010 15:39, Rainer Orth <ro@cebitec.uni-bielefeld.de> wrote:
>> The following libjava patches have remained unreviewed for more than a
>> week:
>>
>>        PATCH: Avoid command line length limit building tools.zip (PR libgcj/38251)
>>        http://gcc.gnu.org/ml/java-patches/2010-q1/msg00021.html
>>
>
> This one needs to go in upstream GNU Classpath too by the looks of it.

In the past, some of the libjava maintainers has taken care of that.

	Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University

Re: Unreviewed patches

[Andrew Haley]

On 01/29/2010 05:36 PM, Rainer Orth wrote:
> Andrew John Hughes <gnu_andrew@member.fsf.org> writes:
> 
>> On 29 January 2010 15:39, Rainer Orth <ro@cebitec.uni-bielefeld.de> wrote:
>>> The following libjava patches have remained unreviewed for more than a
>>> week:
>>>
>>>        PATCH: Avoid command line length limit building tools.zip (PR libgcj/38251)
>>>        http://gcc.gnu.org/ml/java-patches/2010-q1/msg00021.html
>>>
>>
>> This one needs to go in upstream GNU Classpath too by the looks of it.
> 
> In the past, some of the libjava maintainers has taken care of that.

Go on Andrew, your turn!  :-)

Andrew.

Re: Unreviewed patches

[Andrew John Hughes]

On 29 January 2010 17:36, Rainer Orth <ro@cebitec.uni-bielefeld.de> wrote:
> Andrew John Hughes <gnu_andrew@member.fsf.org> writes:
>
>> On 29 January 2010 15:39, Rainer Orth <ro@cebitec.uni-bielefeld.de> wrote:
>>> The following libjava patches have remained unreviewed for more than a
>>> week:
>>>
>>>        PATCH: Avoid command line length limit building tools.zip (PR libgcj/38251)
>>>        http://gcc.gnu.org/ml/java-patches/2010-q1/msg00021.html
>>>
>>
>> This one needs to go in upstream GNU Classpath too by the looks of it.
>
> In the past, some of the libjava maintainers has taken care of that.
>
>        Rainer
>
> --
> -----------------------------------------------------------------------------
> Rainer Orth, Center for Biotechnology, Bielefeld University
>

Yeah... I'd be happy to do it myself, but still have a backlog of
patches myself.

I don't suppose we have any libtool experts on the list, do we?
Because Classpath+libtool-2.2.6b currently fails to build for me:

/bin/sh ../../../libtool --tag=CC --mode=link gcc -W -Wall
-Wmissing-declarations -Wwrite-strings -Wmissing-prototypes
-Wno-long-long -Wstrict-prototypes -pedantic -fexceptions
-fasynchronous-unwind-tables -g -O2 -module -version-info 0:0:0
-no-undefined  -o libjavanet.la -rpath
/home/andrew/build/classpath/lib/classpath  javanet.lo
java_net_VMInetAddress.lo java_net_VMNetworkInterface.lo
java_net_VMURLConnection.lo gnu_java_net_VMPlainSocketImpl.lo
gnu_java_net_local_LocalSocketImpl.lo
../../../native/jni/classpath/jcl.lo
../../../native/jni/native-lib/libclasspathnative.la -lmagic
libtool: link: unsupported hardcode properties
libtool: link: See the libtool documentation for more information.
libtool: link: Fatal configuration error.

That's been blocking me committing stuff for a while, and haven't had
time to find a fix for it.
-- 
Andrew :-)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net

PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8

Re: Unreviewed patches

[Andrew John Hughes]

On 29 January 2010 17:40, Andrew Haley <aph@redhat.com> wrote:
> On 01/29/2010 05:36 PM, Rainer Orth wrote:
>> Andrew John Hughes <gnu_andrew@member.fsf.org> writes:
>>
>>> On 29 January 2010 15:39, Rainer Orth <ro@cebitec.uni-bielefeld.de> wrote:
>>>> The following libjava patches have remained unreviewed for more than a
>>>> week:
>>>>
>>>>        PATCH: Avoid command line length limit building tools.zip (PR libgcj/38251)
>>>>        http://gcc.gnu.org/ml/java-patches/2010-q1/msg00021.html
>>>>
>>>
>>> This one needs to go in upstream GNU Classpath too by the looks of it.
>>
>> In the past, some of the libjava maintainers has taken care of that.
>
> Go on Andrew, your turn!  :-)
>
> Andrew.
>

It's in; or at least the relevant part is.

I found the solution to the libtool issue -- a number of old libtool
macros were still lurking in the m4 directory -- and so have committed
my pending patches now.
-- 
Andrew :-)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net

PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8