From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30076 invoked by alias); 3 Jan 2008 09:52:50 -0000 Received: (qmail 30056 invoked by uid 22791); 3 Jan 2008 09:52:49 -0000 X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 03 Jan 2008 09:48:49 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id m039mllf026946; Thu, 3 Jan 2008 04:48:47 -0500 Received: from zebedee.littlepinkcloud.COM (vpn-14-13.rdu.redhat.com [10.11.14.13]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id m039mkWx012831; Thu, 3 Jan 2008 04:48:46 -0500 Received: from littlepinkcloud.COM (localhost.localdomain [127.0.0.1]) by zebedee.littlepinkcloud.COM (8.13.8/8.13.5) with ESMTP id m039mfvi028902; Thu, 3 Jan 2008 09:48:43 GMT Received: (from aph@localhost) by littlepinkcloud.COM (8.13.8/8.13.5/Submit) id m039mdDu028899; Thu, 3 Jan 2008 09:48:39 GMT MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <18300.44919.694252.333004@zebedee.pink> Date: Thu, 03 Jan 2008 09:52:00 -0000 From: Andrew Haley To: Andreas Tobler Cc: GCC Patches , Java Patches , Eric Christopher , Richard Guenther Subject: Re: [patch] libffi darwin x86-32bit, fix return_sc testcase. In-Reply-To: <477C054B.7060107@fgznet.ch> References: <477C054B.7060107@fgznet.ch> X-Mailer: VM 7.19 under Emacs 22.0.93.1 X-IsSubscribed: yes Mailing-List: contact java-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: java-patches-owner@gcc.gnu.org X-SW-Source: 2008-q1/txt/msg00001.txt.bz2 Andreas Tobler writes: > Hello all, > > first, a happy new year to all! > > The attached patch brings libffi for darwin x86 (32-bit) back to zero > failures, at least what is covered by the test suite ;) > > I implemented the fix according to Andrew's fix back in July 07 for > linux x86. Except that I had to treat small structs in special way. I will again point out that this is merely a workaround for a gcc code generation bug. Rather than fix the symptom, a libffi test failure, we should fix the real problem: we are not generating ABI-compatible code on x86. This bug was introduced by Author: rguenth Date: Mon Jul 9 09:53:11 2007 New Revision: 126480 http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32843 Andrew. -- Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, UK Registered in England and Wales No. 3798903