From: "John David Anglin" <dave@hiauly1.hia.nrc.ca>
To: tromey@redhat.com
Cc: toa@pop.agri.ch, java-patches@gcc.gnu.org, gcc-patches@gcc.gnu.org
Subject: Re: [patch] include/posix.h
Date: Thu, 25 May 2006 23:21:00 -0000 [thread overview]
Message-ID: <200605252321.k4PNLO5F007688@hiauly1.hia.nrc.ca> (raw)
In-Reply-To: <m3bqtouum8.fsf@localhost.localdomain> from "Tom Tromey" at May 23, 2006 06:36:15 pm
> Andreas> In our case sys/rw_lock.h, the file where this (re)-definition
> Andreas> happens, is included after Boolean.h, implicitely. So I tend to agree
> Andreas> with Dave that the workaround he proposes is probably the best one in
> Andreas> regard of effort and gain.
>
> That patch also looked fine to me. Feel free to check it in.
Done.
Dave
--
J. David Anglin dave.anglin@nrc-cnrc.gc.ca
National Research Council of Canada (613) 990-0752 (FAX: 952-6602)
2006-05-25 John David Anglin <dave.anglin@nrc-cnrc.gc.ca>
* configure.ac: Add sys/rw_lock.h to AC_CHECK_HEADERS.
* configure: Rebuilt.
* include/config.h.in: Likewise.
* include/posix.h: If HAVE_SYS_RW_LOCK_H is defined, include
<sys/rw_lock.h>.
Index: configure.ac
===================================================================
--- configure.ac (revision 113941)
+++ configure.ac (working copy)
@@ -1276,7 +1276,7 @@
sys/ioctl.h sys/filio.h sys/stat.h sys/select.h \
sys/socket.h netinet/in.h arpa/inet.h netdb.h net/if.h \
pwd.h sys/config.h stdint.h langinfo.h locale.h \
- dirent.h])
+ dirent.h sys/rw_lock.h])
AC_CHECK_HEADERS(inttypes.h, [
AC_DEFINE(HAVE_INTTYPES_H, 1, [Define if <inttypes.h> is available])
AC_DEFINE(JV_HAVE_INTTYPES_H, 1, [Define if <inttypes.h> is available])
Index: include/posix.h
===================================================================
--- include/posix.h (revision 113941)
+++ include/posix.h (working copy)
@@ -37,6 +37,12 @@
#include <fcntl.h>
+/* The header file <sys/rw_lock.h> needs to be included before javaprims.h
+ on HP-UX 11 to avoid a compilation error. */
+#ifdef HAVE_SYS_RW_LOCK_H
+#include <sys/rw_lock.h>
+#endif
+
#include <gcj/cni.h>
#include <java/util/Properties.h>
prev parent reply other threads:[~2006-05-25 23:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-19 22:16 Andreas Tobler
2006-05-22 21:25 ` Tom Tromey
2006-05-23 19:47 ` Andreas Tobler
2006-05-24 0:39 ` Tom Tromey
2006-05-25 23:21 ` John David Anglin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200605252321.k4PNLO5F007688@hiauly1.hia.nrc.ca \
--to=dave@hiauly1.hia.nrc.ca \
--cc=gcc-patches@gcc.gnu.org \
--cc=java-patches@gcc.gnu.org \
--cc=toa@pop.agri.ch \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).