public inbox for java-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [ecj] natVMStackWalker.cc comment fixes
@ 2006-12-05 14:55 Gary Benson
  0 siblings, 0 replies; only message in thread
From: Gary Benson @ 2006-12-05 14:55 UTC (permalink / raw)
  To: java-patches

[-- Attachment #1: Type: text/plain, Size: 253 bytes --]

Hi again,

This commit removes a bunch of FIXME comments about security
checks in natVMStackWalker.cc.  Classes in gnu.classpath are
intended to be protected from user access by the security
manager and should not contain security checks.

Cheers,
Gary

[-- Attachment #2: patch --]
[-- Type: text/plain, Size: 1433 bytes --]

Index: ChangeLog
===================================================================
--- ChangeLog	(revision 119540)
+++ ChangeLog	(working copy)
@@ -1,3 +1,7 @@
+2006-12-05  Gary Benson  <gbenson@redhat.com>
+
+	* gnu/classpath/natVMStackWalker.cc: Comment fixes.
+
 2006-12-05  Gary Benson  <gbenson@redhat.com>
 
 	* gnu/classpath/natVMStackWalker.cc (getCallingClass): Unwind
Index: gnu/classpath/natVMStackWalker.cc
===================================================================
--- gnu/classpath/natVMStackWalker.cc	(revision 119540)
+++ gnu/classpath/natVMStackWalker.cc	(working copy)
@@ -21,15 +21,12 @@
 JArray<jclass> *
 gnu::classpath::VMStackWalker::getClassContext(void)
 {
-  // FIXME: Security check here?
   return _Jv_StackTrace::GetStackWalkerStack ();
 }
 
 jclass
 gnu::classpath::VMStackWalker::getCallingClass(::gnu::gcj::RawData *pc)
 {
-  // FIXME: Security check here?
-
   void *f = _Unwind_FindEnclosingFunction (pc);
 
   // FIXME: it might well be a good idea to cache pc values here in
@@ -58,14 +55,12 @@
 ::java::lang::ClassLoader *
 gnu::classpath::VMStackWalker::getClassLoader(::java::lang::Class *c)
 {
-  // FIXME: Security check here?
   return c->getClassLoaderInternal ();
 }
 
 ::java::lang::ClassLoader *
 gnu::classpath::VMStackWalker::getCallingClassLoader(::gnu::gcj::RawData *pc)
 {
-  // FIXME: Security check here?
   return getCallingClass (pc)->getClassLoaderInternal ();
 }
 

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2006-12-05 14:55 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-12-05 14:55 [ecj] natVMStackWalker.cc comment fixes Gary Benson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).