Re: PATCH: Avoid command line length limit building tools.zip (PR libgcj/38251)

[Ralf Wildenhues <Ralf.Wildenhues@gmx.de>]

* Rainer Orth wrote on Tue, Mar 02, 2010 at 12:06:34PM CET:
> >> --- a/libjava/classpath/tools/Makefile.am       Mon Jan 11 04:28:36 2010 +0000
> >> +++ b/libjava/classpath/tools/Makefile.am       Wed Jan 20 17:49:17 2010 +0100
> >> @@ -373,6 +373,9 @@
> >>  ## BEGIN GCJ LOCAL
> >>         cp -pR $(srcdir)/asm .
> >>         cp -pR $(srcdir)/classes .
> >> +       if [ -d asm/.svn ]; then \
> >> +         find asm classes -depth -type d -name .svn -exec rm -rf \{\} \;; \
> >> +       fi
> >>  ## END GCJ LOCAL
> >
> > FWIW, this has the potential to corrupt a SVN source tree iff the build
> > tree and the source trees happen to coincide.

> I've no idea if any developer does in-tree builds anymore.  If so, I'm
> not sure even the cp -pR part is guaranteed to work.

Yes, that will likely fail.

> And end-users who
> do are probably building from a tarball and don't care about a SVN
> checkout anyway.

Yep.

> Thoughts?

Since due to the cp -pR this isn't a regression, I suggest not doing any
further changes now, but please open a low-priority PR about this
in-tree build bug and CC: me or assign to me, so that it is not
forgotten.

Thanks,
Ralf