From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29254 invoked by alias); 2 Mar 2010 20:08:52 -0000 Received: (qmail 29235 invoked by uid 22791); 2 Mar 2010 20:08:51 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from mail.gmx.net (HELO mail.gmx.net) (213.165.64.20) by sourceware.org (qpsmtpd/0.43rc1) with SMTP; Tue, 02 Mar 2010 20:08:46 +0000 Received: (qmail invoked by alias); 02 Mar 2010 20:08:33 -0000 Received: from xdsl-89-0-139-129.netcologne.de (EHLO localhost.localdomain) [89.0.139.129] by mail.gmx.net (mp016) with SMTP; 02 Mar 2010 21:08:33 +0100 Received: from ralf by localhost.localdomain with local (Exim 4.69) (envelope-from ) id 1NmYOD-0002dA-GX; Tue, 02 Mar 2010 21:08:21 +0100 Date: Tue, 02 Mar 2010 20:08:00 -0000 From: Ralf Wildenhues To: Rainer Orth Cc: java-patches@gcc.gnu.org, Andrew Haley Subject: Re: PATCH: Avoid command line length limit building tools.zip (PR libgcj/38251) Message-ID: <20100302200821.GA8410@gmx.de> Mail-Followup-To: Ralf Wildenhues , Rainer Orth , java-patches@gcc.gnu.org, Andrew Haley References: <20100301190940.GF21372@gmx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-10-28) Mailing-List: contact java-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: java-patches-owner@gcc.gnu.org X-SW-Source: 2010-q1/txt/msg00053.txt.bz2 * Rainer Orth wrote on Tue, Mar 02, 2010 at 12:06:34PM CET: > >> --- a/libjava/classpath/tools/Makefile.am Mon Jan 11 04:28:36 2010 +0000 > >> +++ b/libjava/classpath/tools/Makefile.am Wed Jan 20 17:49:17 2010 +0100 > >> @@ -373,6 +373,9 @@ > >> ## BEGIN GCJ LOCAL > >> cp -pR $(srcdir)/asm . > >> cp -pR $(srcdir)/classes . > >> + if [ -d asm/.svn ]; then \ > >> + find asm classes -depth -type d -name .svn -exec rm -rf \{\} \;; \ > >> + fi > >> ## END GCJ LOCAL > > > > FWIW, this has the potential to corrupt a SVN source tree iff the build > > tree and the source trees happen to coincide. > I've no idea if any developer does in-tree builds anymore. If so, I'm > not sure even the cp -pR part is guaranteed to work. Yes, that will likely fail. > And end-users who > do are probably building from a tarball and don't care about a SVN > checkout anyway. Yep. > Thoughts? Since due to the cp -pR this isn't a regression, I suggest not doing any further changes now, but please open a low-priority PR about this in-tree build bug and CC: me or assign to me, so that it is not forgotten. Thanks, Ralf