From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29744 invoked by alias); 18 Aug 2010 09:45:15 -0000 Received: (qmail 29720 invoked by uid 22791); 18 Aug 2010 09:45:14 -0000 X-SWARE-Spam-Status: No, hits=-6.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 18 Aug 2010 09:45:09 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o7I9j8wC017257 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 18 Aug 2010 05:45:08 -0400 Received: from tyan-ft48-01.lab.bos.redhat.com (tyan-ft48-01.lab.bos.redhat.com [10.16.42.4]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o7I9j7LQ013574 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 18 Aug 2010 05:45:07 -0400 Received: from tyan-ft48-01.lab.bos.redhat.com (tyan-ft48-01.lab.bos.redhat.com [127.0.0.1]) by tyan-ft48-01.lab.bos.redhat.com (8.14.4/8.14.4) with ESMTP id o7I9jRs4023660; Wed, 18 Aug 2010 11:45:27 +0200 Received: (from jakub@localhost) by tyan-ft48-01.lab.bos.redhat.com (8.14.4/8.14.4/Submit) id o7I9jR2n023659; Wed, 18 Aug 2010 11:45:27 +0200 Date: Wed, 18 Aug 2010 09:45:00 -0000 From: Jakub Jelinek To: Richard Guenther Cc: IainS , java-patches@gcc.gnu.org, gcc patches , Richard Henderson Subject: Re: [Patch, libjava] use -fnon-call-exceptions rather than -fasynchronous-unwind-tables. Message-ID: <20100818094527.GN702@tyan-ft48-01.lab.bos.redhat.com> Reply-To: Jakub Jelinek References: <6533D5F3-D5AE-475F-A309-625BC7ACBF48@sandoe-acoustics.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.20 (2009-12-10) Mailing-List: contact java-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: java-patches-owner@gcc.gnu.org X-SW-Source: 2010-q3/txt/msg00036.txt.bz2 On Wed, Aug 18, 2010 at 11:40:15AM +0200, Richard Guenther wrote: > On Wed, Aug 18, 2010 at 11:30 AM, IainS > wrote: > > IIUC, the following should be the 'correct' approach. > > OK for trunk? (with an appropriate changelog,  of course). > > Iain > > That doens't match what the comment says. What is it the correct > approach for? Yeah, I think -fa-u-t is right, otherwise you can't backtrace through signal handlers. If Darwin unwinder is lame enough that it can't grok it, let it change just on Darwin and don't punish sane OSes. > > --- libjava/classpath/configure.ac      (revision 163330) > > +++ libjava/classpath/configure.ac      (working copy) > > @@ -563,7 +563,7 @@ if test "x${COMPILE_JNI}" = xyes; then > >     dnl CFLAGS that are used for all native code.  We want to compile > >     dnl everything with unwinder data so that backtrace() will always > >     dnl work. > > -    EXTRA_CFLAGS='-fexceptions -fasynchronous-unwind-tables' > > +    EXTRA_CFLAGS='-fexceptions -fnon-call-exceptions' > >     AC_SUBST(EXTRA_CFLAGS) > > > >     dnl Strict warning flags which not every module uses. > > > > Jakub