From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1887 invoked by alias); 8 Mar 2011 16:57:07 -0000 Received: (qmail 1872 invoked by uid 22791); 8 Mar 2011 16:57:06 -0000 X-SWARE-Spam-Status: No, hits=-4.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,TW_FD,T_HK_NAME_DR,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 08 Mar 2011 16:57:01 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p28Gupwo001321 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 8 Mar 2011 11:56:51 -0500 Received: from rivendell.middle-earth.co.uk ([10.3.113.4]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p28GukTi022181 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Tue, 8 Mar 2011 11:56:49 -0500 Date: Tue, 08 Mar 2011 16:57:00 -0000 From: Dr Andrew John Hughes To: "Joseph S. Myers" Cc: Jim Meyering , gcc-patches@gcc.gnu.org, java-patches@gcc.gnu.org Subject: Re: avoid useless if-before-free tests Message-ID: <20110308165646.GF2877@rivendell.middle-earth.co.uk> References: <87zkp9zmq0.fsf@rho.meyering.net> <20110307195204.GL9339@rivendell.middle-earth.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact java-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: java-patches-owner@gcc.gnu.org X-SW-Source: 2011-q1/txt/msg00055.txt.bz2 On 22:47 Mon 07 Mar , Joseph S. Myers wrote: > On Mon, 7 Mar 2011, Dr Andrew John Hughes wrote: > > > > http://gcc.gnu.org/codingconventions.html says Classpath changes should go > > > via Classpath upstream, not directly into GCC. I don't know if that's > > > still accurate. > > > > > > > That's still true. This seems to be the first message I've received in this > > thread, so I'm not even aware of what these changes are. Were the earlier > > messages not sent to this list? > > The original patch went only to gcc-patches. > > http://gcc.gnu.org/ml/gcc-patches/2011-03/msg00252.html > Thanks for the link. I'd like some explanation of why these changes are necessary before we start adding them to Classpath. Are we just assuming that all free implementations will ignore NULL now? With regards to fdlibm, there is a further upstream for this where these changes should be made first. fdlibm is also used by OpenJDK. > -- > Joseph S. Myers > joseph@codesourcery.com -- Andrew :) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and IcedTea http://www.gnu.org/software/classpath http://icedtea.classpath.org PGP Key: F5862A37 (https://keys.indymedia.org/) Fingerprint = EA30 D855 D50F 90CD F54D 0698 0713 C3ED F586 2A37