From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <java-patches-return-20336-listarch-java-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 4862 invoked by alias); 7 Jul 2011 20:36:15 -0000
Received: (qmail 4812 invoked by uid 22791); 7 Jul 2011 20:36:14 -0000
X-SWARE-Spam-Status: No, hits=-1.8 required=5.0	tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,TW_IB
X-Spam-Check-By: sourceware.org
Received: from mailout-de.gmx.net (HELO mailout-de.gmx.net) (213.165.64.23)    by sourceware.org (qpsmtpd/0.43rc1) with SMTP; Thu, 07 Jul 2011 20:35:58 +0000
Received: (qmail 30707 invoked by uid 0); 7 Jul 2011 20:35:56 -0000
Received: from 74.125.121.33 by www003.gmx.net with HTTP; Thu, 07 Jul 2011 22:35:53 +0200 (CEST)
Cc: Matthias Klose <doko@ubuntu.com>, java-patches@gcc.gnu.org, GCC Patches <gcc-patches@gcc.gnu.org>
Content-Type: text/plain; charset="utf-8"
Date: Thu, 07 Jul 2011 20:36:00 -0000
From: "Ralf Wildenhues" <Ralf.Wildenhues@gmx.de>
In-Reply-To: <20110707202659.GT2687@tyan-ft48-01.lab.bos.redhat.com>
Message-ID: <20110707203554.280270@gmx.net>
MIME-Version: 1.0
References: <4E15DE84.5030809@ubuntu.com> <4E15E3F6.3050502@cavium.com> <4E15E56E.4070209@ubuntu.com> <4E15E6AF.4050508@cavium.com> <4E15F34D.7050800@redhat.com> <4E16158D.3060206@ubuntu.com> <20110707202659.GT2687@tyan-ft48-01.lab.bos.redhat.com>
Subject: Re: [patch] Disable static build for libjava
To: Jakub Jelinek <jakub@redhat.com>
X-Mutt-Fcc: ~/sent
X-Mutt-References: <20110707202659.GT2687@tyan-ft48-01.lab.bos.redhat.com>
Content-Transfer-Encoding: 8bit
Mailing-List: contact java-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <java-patches.gcc.gnu.org>
List-Subscribe: <mailto:java-patches-subscribe@gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/java-patches/>
List-Post: <mailto:java-patches@gcc.gnu.org>
List-Help: <mailto:java-patches-help@gcc.gnu.org>, <http://gcc.gnu.org/ml/#faqs>
Sender: java-patches-owner@gcc.gnu.org
X-SW-Source: 2011-q3/txt/msg00015.txt.bz2

Hi Matthias,

On Thu, Jul 07, 2011 at 10:26:59PM +0200, Jakub Jelinek wrote:
> On Thu, Jul 07, 2011 at 10:22:37PM +0200, Matthias Klose wrote:
> > +AC_PROG_LIBTOOL

This tests the wrong compiler and toolchain.  The compiler you want
to test doesn't exist yet at the time this configure script is run.
So you might as well deduce the switch you need from a fixed set or
other GCC configure data.

Or you put AC_PROG_LIBTOOL in libjava/ but pass down the value of
enable_static_libjava as --en/disable-static there.

> > +if test x$enable_shared = xyes && test x$enable_static_libjava != xyes ; then
> > +  case $host_cpu in
> 
> Shouldn't this be $host_os instead of $host_cpu ?  cygwin* etc.
> don't look like host_cpu names...
> 
> > +  cygwin* | mingw* | pw32* | cegcc*)
> > +    ;;
> > +  *)
> > +    EXTRA_CONFIGARGS_LIBJAVA=--disable-static

Cheers,
Ralf