From: "H.J. Lu" <hongjiu.lu@intel.com>
To: Uros Bizjak <ubizjak@gmail.com>, java-patches@gcc.gnu.org
Cc: gcc-patches@gcc.gnu.org
Subject: Re: PR libjava/53973: Check and and skip 67h address size prefix for x32
Date: Wed, 18 Jul 2012 16:30:00 -0000 [thread overview]
Message-ID: <20120718163007.GA23495@intel.com> (raw)
In-Reply-To: <20120716210441.GA5620@intel.com>
On Mon, Jul 16, 2012 at 02:04:41PM -0700, H.J. Lu wrote:
> Hi,
>
> Since x32 may generate 64-bit integer divide like
>
> 67 48 f7 bd a0 fe ff ff idivq -0x160(%ebp)
>
> we need to check and skip 67h address size for x32. OK for trunk if
> there are no regressions on Linux/x86-64?
>
> Thanks.
>
> H.J.
> ----
> 2012-07-16 H.J. Lu <hongjiu.lu@intel.com>
>
> PR libjava/53973
> * include/x86_64-signal.h (CHECK_67H_PREFIX): New.
> (HANDLE_DIVIDE_OVERFLOW): Check and and skip 67h address size
> prefix if CHECK_67H_PREFIX is 1.
>
Here is the patch with the updated ChangeLog entry. OK for trunk?
Thanks.
H.J.
---
2012-07-16 H.J. Lu <hongjiu.lu@intel.com>
PR libjava/53973
* include/x86_64-signal.h (CHECK_67H_PREFIX): New.
(HANDLE_DIVIDE_OVERFLOW): Check and and skip 67h address size
prefix if CHECK_67H_PREFIX is 1. Use ULL suffix for 64-bit
integer.
diff --git a/libjava/include/x86_64-signal.h b/libjava/include/x86_64-signal.h
index 4bd8a36..84907c3 100644
--- a/libjava/include/x86_64-signal.h
+++ b/libjava/include/x86_64-signal.h
@@ -21,6 +21,12 @@ details. */
#define HANDLE_SEGV 1
#define HANDLE_FPE 1
+#ifdef __ILP32__
+# define CHECK_67H_PREFIX 1
+#else
+# define CHECK_67H_PREFIX 0
+#endif
+
#define SIGNAL_HANDLER(_name) \
static void _Jv_##_name (int, siginfo_t *, \
void *_p __attribute__ ((__unused__)))
@@ -47,6 +53,10 @@ do \
\
bool _is_64_bit = false; \
\
+ /* Check and skip 67h address size prefix if needed. */ \
+ if (CHECK_67H_PREFIX && _rip[0] == 0x67) \
+ _rip++; \
+ \
if ((_rip[0] & 0xf0) == 0x40) /* REX byte present. */ \
{ \
unsigned char _rex = _rip[0] & 0x0f; \
@@ -64,10 +74,10 @@ do \
{ \
if (_is_64_bit) \
_min_value_dividend = \
- _gregs[REG_RAX] == (greg_t)0x8000000000000000UL; \
+ _gregs[REG_RAX] == (greg_t)0x8000000000000000ULL; \
else \
_min_value_dividend = \
- (_gregs[REG_RAX] & 0xffffffff) == (greg_t)0x80000000UL; \
+ (_gregs[REG_RAX] & 0xffffffff) == (greg_t)0x80000000ULL; \
} \
\
if (_min_value_dividend) \
next parent reply other threads:[~2012-07-18 16:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20120716210441.GA5620@intel.com>
2012-07-18 16:30 ` H.J. Lu [this message]
2012-07-18 17:35 ` Andrew Haley
2012-07-18 17:47 ` Uros Bizjak
2012-07-18 17:58 ` H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120718163007.GA23495@intel.com \
--to=hongjiu.lu@intel.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hjl.tools@gmail.com \
--cc=java-patches@gcc.gnu.org \
--cc=ubizjak@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).