From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <java-patches-return-20614-listarch-java-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 7536 invoked by alias); 19 Dec 2012 17:38:01 -0000
Received: (qmail 7241 invoked by uid 22791); 19 Dec 2012 17:37:59 -0000
X-SWARE-Spam-Status: No, hits=-2.0 required=5.0	tests=AWL,BAYES_00,TW_GJ
X-Spam-Check-By: sourceware.org
Received: from wildebeest.demon.nl (HELO gnu.wildebeest.org) (212.238.236.112)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 19 Dec 2012 17:37:55 +0000
Date: Wed, 19 Dec 2012 17:38:00 -0000
From: Mark Wielaard <mark@klomp.org>
To: Matthias Klose <doko@ubuntu.com>
Cc: classpath-patches@gnu.org, GCJ-patches <java-patches@gcc.gnu.org>
Subject: Re: [cp-patches] [patch] let gjavah accept -source 1.[567]
Message-ID: <20121219173749.GA22367@toonder.wildebeest.org>
References: <50D1BA96.8000600@ubuntu.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <50D1BA96.8000600@ubuntu.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-Spam-Score: -2.9 (--)
X-IsSubscribed: yes
Mailing-List: contact java-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <java-patches.gcc.gnu.org>
List-Subscribe: <mailto:java-patches-subscribe@gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/java-patches/>
List-Post: <mailto:java-patches@gcc.gnu.org>
List-Help: <mailto:java-patches-help@gcc.gnu.org>, <http://gcc.gnu.org/ml/#faqs>
Sender: java-patches-owner@gcc.gnu.org
X-SW-Source: 2012-q4/txt/msg00056.txt.bz2

On Wed, Dec 19, 2012 at 02:01:10PM +0100, Matthias Klose wrote:
> Currently gjavah only accepts -source 1.4 and lower, and errors out for any
> other value. Would it be reasonable to accept higher versions too?

I think that should be fine for gjavah, I cannot think of something
in the bytecode that would impact jni/cni header generation.

But your patch is for gjdoc. There I think there are source constructs
that might be a problem in newer versions. It should support some of
the new 1.5 source level features, but I am not sure if it handles
everything nor whether it handles any 1.6 and 1.7 extensions.

> Index: classpath/tools/gnu/classpath/tools/gjdoc/Main.java
> ===================================================================
> --- classpath/tools/gnu/classpath/tools/gjdoc/Main.java	(Revision 194604)
> +++ classpath/tools/gnu/classpath/tools/gjdoc/Main.java	(Arbeitskopie)
> @@ -1339,10 +1310,13 @@
>              option_source = args[0];
>              if (!"1.2".equals(option_source)
>                  && !"1.3".equals(option_source)
> -                && !"1.4".equals(option_source)) {
> +                && !"1.4".equals(option_source)
> +                && !"1.5".equals(option_source)
> +                && !"1.6".equals(option_source)
> +                && !"1.7".equals(option_source)) {

If you really meant gjdoc I think it would be OK to try to accept it,
but maybe with a warning message that it is untested?

Cheers,

Mark