public inbox for java-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [committed, libjava] XFAIL sourcelocation (PR libgcj/55637) backported to 4.8.3
@ 2014-04-01 10:29 Dominique Dhumieres
  2014-04-02 10:48 ` Rainer Orth
  0 siblings, 1 reply; 5+ messages in thread
From: Dominique Dhumieres @ 2014-04-01 10:29 UTC (permalink / raw)
  To: gcc-patches; +Cc: java-patches, ro

ro@CeBiTec.Uni-Bielefeld.DE (Rainer Orth) wrote:
> Sure, patch preapproved.

Commited as r208983:

2014-04-01  Dominique d'Humieres <dominiq@lps.ens.fr>    
            Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>

        PR libgcj/55637        
        * testsuite/libjava.lang/sourcelocation.xfail: New file.

Index: libjava/testsuite/libjava.lang/sourcelocation.xfail
===================================================================
--- libjava/testsuite/libjava.lang/sourcelocation.xfail	(revision 0)
+++ libjava/testsuite/libjava.lang/sourcelocation.xfail	(working copy)
@@ -0,0 +1 @@
+xfail-output

Dominique

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [committed, libjava] XFAIL sourcelocation (PR libgcj/55637) backported to 4.8.3
  2014-04-01 10:29 [committed, libjava] XFAIL sourcelocation (PR libgcj/55637) backported to 4.8.3 Dominique Dhumieres
@ 2014-04-02 10:48 ` Rainer Orth
  2014-04-03 15:31   ` Dominique d'Humières
  0 siblings, 1 reply; 5+ messages in thread
From: Rainer Orth @ 2014-04-02 10:48 UTC (permalink / raw)
  To: Dominique Dhumieres; +Cc: gcc-patches, java-patches

dominiq@lps.ens.fr (Dominique Dhumieres) writes:

> ro@CeBiTec.Uni-Bielefeld.DE (Rainer Orth) wrote:
>> Sure, patch preapproved.
>
> Commited as r208983:
>
> 2014-04-01  Dominique d'Humieres <dominiq@lps.ens.fr>    
>             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
>
>         PR libgcj/55637        
>         * testsuite/libjava.lang/sourcelocation.xfail: New file.

Btw, the customary format for such a ChangeLog entry is

2014-04-01  Dominique d'Humieres <dominiq@lps.ens.fr>    

	Backport from mainline
	2014-02-20  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>

        PR libgcj/55637
        * testsuite/libjava.lang/sourcelocation.xfail: New file.

This way, you can easily see when the original went in.

	Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [committed, libjava] XFAIL sourcelocation (PR libgcj/55637) backported to 4.8.3
  2014-04-02 10:48 ` Rainer Orth
@ 2014-04-03 15:31   ` Dominique d'Humières
  2014-04-03 15:33     ` Rainer Orth
  0 siblings, 1 reply; 5+ messages in thread
From: Dominique d'Humières @ 2014-04-03 15:31 UTC (permalink / raw)
  To: Rainer Orth; +Cc: gcc-patches, java-patches, Dominique d'Humieres


Thanks for the tip. What should I do now? Should I fix the ChangeLog entry and add a new one or do nothing?

Dominique

Le 2 avr. 2014 à 12:47, Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE> a écrit :

> dominiq@lps.ens.fr (Dominique Dhumieres) writes:
> 
>> ro@CeBiTec.Uni-Bielefeld.DE (Rainer Orth) wrote:
>>> Sure, patch preapproved.
>> 
>> Commited as r208983:
>> 
>> 2014-04-01  Dominique d'Humieres <dominiq@lps.ens.fr>    
>>            Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
>> 
>>        PR libgcj/55637        
>>        * testsuite/libjava.lang/sourcelocation.xfail: New file.
> 
> Btw, the customary format for such a ChangeLog entry is
> 
> 2014-04-01  Dominique d'Humieres <dominiq@lps.ens.fr>    
> 
> 	Backport from mainline
> 	2014-02-20  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
> 
>        PR libgcj/55637
>        * testsuite/libjava.lang/sourcelocation.xfail: New file.
> 
> This way, you can easily see when the original went in.
> 
> 	Rainer
> 
> -- 
> -----------------------------------------------------------------------------
> Rainer Orth, Center for Biotechnology, Bielefeld University

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [committed, libjava] XFAIL sourcelocation (PR libgcj/55637) backported to 4.8.3
  2014-04-03 15:31   ` Dominique d'Humières
@ 2014-04-03 15:33     ` Rainer Orth
  2014-04-04  7:08       ` Dominique Dhumieres
  0 siblings, 1 reply; 5+ messages in thread
From: Rainer Orth @ 2014-04-03 15:33 UTC (permalink / raw)
  To: Dominique d'Humières; +Cc: gcc-patches, java-patches

Hi Dominique,

> Thanks for the tip. What should I do now? Should I fix the ChangeLog entry
> and add a new one or do nothing?

if you want, you could fix the ChangeLog entry in place, but don't add a
new one for that change.

	Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [committed, libjava] XFAIL sourcelocation (PR libgcj/55637) backported to 4.8.3
  2014-04-03 15:33     ` Rainer Orth
@ 2014-04-04  7:08       ` Dominique Dhumieres
  0 siblings, 0 replies; 5+ messages in thread
From: Dominique Dhumieres @ 2014-04-04  7:08 UTC (permalink / raw)
  To: ro, dominiq; +Cc: java-patches, gcc-patches

> if you want, you could fix the ChangeLog entry in place, but don't add a
> new one for that change.

Done,

Dominique

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2014-04-04  7:08 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-04-01 10:29 [committed, libjava] XFAIL sourcelocation (PR libgcj/55637) backported to 4.8.3 Dominique Dhumieres
2014-04-02 10:48 ` Rainer Orth
2014-04-03 15:31   ` Dominique d'Humières
2014-04-03 15:33     ` Rainer Orth
2014-04-04  7:08       ` Dominique Dhumieres

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).