public inbox for java-patches@gcc.gnu.org
 help / color / mirror / Atom feed
  • * Re: [PATCH] win64 support for libffi (2/2)
           [not found] <635C3243-B89E-460E-9C0F-209308D89729@dev.java.net>
           [not found] ` <b609cb3b0905171605tc6a10b7u683c43a99f97382f@mail.gmail.com>
    @ 2009-05-18 10:12 ` Andrew Haley
      2009-05-18 12:26   ` Timothy Wall
      1 sibling, 1 reply; 28+ messages in thread
    From: Andrew Haley @ 2009-05-18 10:12 UTC (permalink / raw)
      To: Timothy Wall; +Cc: Java Patch List, Anthony Green
    
    Timothy Wall wrote:
    > This patch adds support for win64 builds under mingw64 for libffi. 
    > Diffs are against current libffi CVS (5/12/2009).  The build works with
    > mingw or free MSVC cross compiler, although MSVC needs special scripts
    > to wrap the compiler, assembler, and linker (available in the JNA
    > project's build tree at http://jna.dev.java.net).
    > 
    > All libffi testsuite tests pass, excluding long double tests, which are
    > unsupported at this time.
    > 
    > Configury changes have been tested on x86-darwin for inadvertent side
    > effects.
    
    Richard Guenther is right: libffi upstream and gcc have drifted horribly.
    With green's permission I'll merge the changes.
    
    Some of your patch seems odd to me, and perhaps changes are needed.
    
    For example, why this change?
    
    @@ -62,41 +71,59 @@
           size_t z;
    
           /* Align if necessary */
    -      if ((sizeof(int) - 1) & (unsigned) argp)
    -       argp = (char *) ALIGN(argp, sizeof(int));
    +      if ((sizeof(void*) - 1) & (size_t) argp)
    +        argp = (char *) ALIGN(argp, sizeof(void*));
    
    Or this?
    
    Index: src/x86/win32.S
    ===================================================================
    RCS file: /cvs/libffi/libffi/src/x86/win32.S,v
    retrieving revision 1.5
    diff -u -b -w -r1.5 win32.S
    --- src/x86/win32.S     15 Feb 2008 01:24:06 -0000      1.5
    +++ src/x86/win32.S     12 May 2009 13:51:21 -0000
    @@ -20,7 +20,7 @@
        THE SOFTWARE IS PROVIDED ``AS IS'', WITHOUT WARRANTY OF ANY KIND, EXPRESS
        OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
        MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.
    -   IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR
    +   IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS LIABLE FOR
            ANY CLAIM, DAMAGES OR
    
    ^ permalink raw reply	[flat|nested] 28+ messages in thread

  • end of thread, other threads:[~2009-05-22 14:42 UTC | newest]
    
    Thread overview: 28+ messages (download: mbox.gz / follow: Atom feed)
    -- links below jump to the message on this page --
         [not found] <635C3243-B89E-460E-9C0F-209308D89729@dev.java.net>
         [not found] ` <b609cb3b0905171605tc6a10b7u683c43a99f97382f@mail.gmail.com>
         [not found]   ` <4A109F74.6060108@gmail.com>
    2009-05-17 23:49     ` [PATCH] win64 support for libffi (2/2) Timothy Wall
    2009-05-17 23:51       ` NightStrike
    2009-05-18  9:36       ` Andrew Haley
    2009-05-18  9:41         ` Richard Guenther
    2009-05-18 10:16           ` Andrew Haley
    2009-05-18 14:46         ` Dave Korn
    2009-05-18 14:59           ` Andrew Haley
    2009-05-18 15:06             ` Dave Korn
    2009-05-18 17:48             ` Dave Korn
    2009-05-18 17:59               ` NightStrike
    2009-05-18 18:09                 ` Timothy Wall
    2009-05-18 18:41                   ` Andrew Haley
    2009-05-18 19:00                     ` Timothy Wall
    2009-05-19  9:16                       ` Andrew Haley
    2009-05-19 12:13                         ` Dave Korn
    2009-05-21 21:08                         ` NightStrike
    2009-05-22  8:54                           ` Andrew Haley
    2009-05-22 12:01                             ` Dave Korn
    2009-05-22 13:01                               ` Andrew Haley
    2009-05-22 13:53                                 ` Dave Korn
    2009-05-22 14:02                                   ` Andrew Haley
    2009-05-22 14:16                                     ` Dave Korn
    2009-05-22 14:42                                   ` Timothy Wall
    2009-05-18 10:12 ` Andrew Haley
    2009-05-18 12:26   ` Timothy Wall
    2009-05-18 14:37     ` Andrew Haley
    2009-05-18 15:31       ` Timothy Wall
    2009-05-18 18:06       ` Timothy Wall
    

    This is a public inbox, see mirroring instructions
    for how to clone and mirror all data and code used for this inbox;
    as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).