From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25070 invoked by alias); 22 Feb 2007 14:18:57 -0000 Received: (qmail 25062 invoked by uid 22791); 22 Feb 2007 14:18:57 -0000 X-Spam-Check-By: sourceware.org Received: from 206-225-86-27.dedicated.abac.net (HELO thisiscool.com) (206.225.86.27) by sourceware.org (qpsmtpd/0.31) with SMTP; Thu, 22 Feb 2007 14:18:47 +0000 Received: from CPE-65-30-191-92.wi.res.rr.com ([65.30.191.92]) by thisiscool.com (JAMES SMTP Server 2.2.0) with SMTP ID 262; Thu, 22 Feb 2007 13:59:56 +0000 (GMT) From: Mohan Embar To: java-patches@gcc.gnu.org Cc: Danny Smith , Marco Trudel Date: Thu, 22 Feb 2007 14:18:00 -0000 Reply-To: gnustuff@thisiscool.com In-Reply-To: <45DD528F.90103@gmx.ch> Message-Id: <3YB00D9GDB9OOJHFGEA9WVNJD81YB9.45dda634@parallels> Subject: Patch [MinGW] FYI: #undef OUT (was Re: jdwp build failure) MIME-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Opera 6.05 build 1140 X-IsSubscribed: yes Mailing-List: contact java-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: java-patches-owner@gcc.gnu.org X-SW-Source: 2007-q1/txt/msg00603.txt.bz2 Hi All, -->Mohan wrote: >>> I had already tried that, but it didn't work. I had even put an >>> #undef OUT in the offending .cc file with no luck. Still, if it >>> only happens on Win32, it has to be a macro, right?. >>> I've only made half-hearted attempts here. Ouch. I guess I hadn't put the #undef OUT in the right place. Thanks for catching this, Marco. And thanks for your insight, Danny. -->Marco wrote: >Also "OUT" is a common widespread word and might lead to conflicts in >future too. Yes, but we're doing this for other such macros in win32-thread.h already. I've committed the following patch, which seems to unbreak the build. Sorry I've been so distracted lately. -- Mohan http://www.thisiscool.com/ http://www.animalsong.org/ 2007-02-22 Mohan Embar * include/win32-threads.h: Added #undef OUT. Index: include/win32-threads.h =================================================================== --- include/win32-threads.h (revision 122226) +++ include/win32-threads.h (working copy) @@ -227,5 +227,6 @@ #undef STRICT #undef VOID #undef TEXT +#undef OUT #endif /* __JV_WIN32_THREADS__ */