* Patch: Fix stacktrace line numbers for mipsel-linux.
@ 2006-01-18 0:53 David Daney
2006-01-18 19:09 ` Tom Tromey
0 siblings, 1 reply; 3+ messages in thread
From: David Daney @ 2006-01-18 0:53 UTC (permalink / raw)
To: Java Patch List
[-- Attachment #1: Type: text/plain, Size: 999 bytes --]
Due to my hacks to get the mips port working several years ago, the new
stacktrace infrastructure does not print line numbers in stack traces.
This patch removes enough of the hacks so that line numbers are once
again produced.
The disable_dladdr was used only by the mips port for the purpose of
working around bugs in glibc 2.2.[45]. Since I have moved up in the
world and am now using a (mostly) working glibc-2.3.3, and I would
expect that most users of gcc-4.1 will not be using older broken glibcs,
this should be a win. Many of the users of mipsel-linux are using cross
compilers so a configure check for this breakage is not really possible.
Currently building/testing on i686-pc-linux-gnu(FC3) and mipsel-linux
cross compiler.
OK to commit to 4.1 and trunk if no regressions?
2006-01-17 David Daney <ddaney@avtrex.com>
* configure.host (disable_dladdr): Remove variable and its
documentation.
* configure.ac: Do not test for disable_dladdr.
* configure: Regenerate.
[-- Attachment #2: disable_dladdr_no_more.d --]
[-- Type: text/plain, Size: 2243 bytes --]
Index: configure
===================================================================
--- configure (revision 109804)
+++ configure (working copy)
@@ -10127,19 +10127,14 @@
echo "${ECHO_T}$ac_cv_lib_dl_dladdr" >&6
if test $ac_cv_lib_dl_dladdr = yes; then
- if test "x${disable_dladdr}" = "xyes"; then
- #Broken dladdr().
- true
- else
cat >>confdefs.h <<\_ACEOF
#define HAVE_DLADDR 1
_ACEOF
- fi
-
fi
+
if test x"$build" = x"$host"; then
echo "$as_me:$LINENO: checking for /proc/self/exe" >&5
echo $ECHO_N "checking for /proc/self/exe... $ECHO_C" >&6
Index: configure.host
===================================================================
--- configure.host (revision 109804)
+++ configure.host (working copy)
@@ -28,8 +28,6 @@
# pthread_self calls by caching thread IDs in a hashtable
# can_unwind_signal Set to "yes" if the EH unwinder supports throwing
# from a signal handler.
-# disable_dladdr Set to "yes" if dladdr should not be used
-# (i.e it is broken).
# fallback_backtrace_h Header to use for fallback backtrace implementation
# (only for targets that don't support DWARF2 unwind)
# descriptor_h Header to use for looking past function descriptors
@@ -44,7 +42,6 @@
sysdeps_dir=generic
slow_pthread_self=
can_unwind_signal=no
-disable_dladdr=
fallback_backtrace_h=sysdep/generic/backtrace.h
case "${target_optspace}:${host}" in
@@ -251,7 +248,6 @@
case "${host}" in
mipsel*-linux* | mipsisa32el*-linux*)
enable_hash_synchronization_default=yes
- disable_dladdr=yes
;;
esac
;;
Index: configure.ac
===================================================================
--- configure.ac (revision 109804)
+++ configure.ac (working copy)
@@ -930,13 +930,8 @@
])
AC_CHECK_LIB(dl, dladdr, [
- if test "x${disable_dladdr}" = "xyes"; then
- #Broken dladdr().
- true
- else
- AC_DEFINE(HAVE_DLADDR, 1, [Define if you have dladdr()])
- fi
- ])
+ AC_DEFINE(HAVE_DLADDR, 1, [Define if you have dladdr()])])
+
if test x"$build" = x"$host"; then
AC_CHECK_FILES(/proc/self/exe, [
AC_DEFINE(HAVE_PROC_SELF_EXE, 1, [Define if you have /proc/self/exe])])
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Patch: Fix stacktrace line numbers for mipsel-linux.
2006-01-18 0:53 Patch: Fix stacktrace line numbers for mipsel-linux David Daney
@ 2006-01-18 19:09 ` Tom Tromey
2006-01-23 18:31 ` David Daney
0 siblings, 1 reply; 3+ messages in thread
From: Tom Tromey @ 2006-01-18 19:09 UTC (permalink / raw)
To: David Daney; +Cc: Java Patch List
>>>>> "David" == David Daney <ddaney@avtrex.com> writes:
David> OK to commit to 4.1 and trunk if no regressions?
Yes, thanks.
Tom
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Patch: Fix stacktrace line numbers for mipsel-linux.
2006-01-18 19:09 ` Tom Tromey
@ 2006-01-23 18:31 ` David Daney
0 siblings, 0 replies; 3+ messages in thread
From: David Daney @ 2006-01-23 18:31 UTC (permalink / raw)
To: tromey; +Cc: Java Patch List
[-- Attachment #1: Type: text/plain, Size: 585 bytes --]
Tom Tromey wrote:
>>>>>>"David" == David Daney <ddaney@avtrex.com> writes:
>
>
> David> OK to commit to 4.1 and trunk if no regressions?
>
> Yes, thanks.
>
Commited to 4.1 as indicated in the original message.
The diff for the trunk is different as it looks like someone forgot to
run autoheader in the past. Committed to the trunk like this:
2006-01-23 David Daney <ddaney@avtrex.com>
* configure.host (disable_dladdr): Remove variable and its
documentation.
* configure.ac: Do not test for disable_dladdr.
* configure: Regenerate.
* include/config.h.in: Regenerate.
[-- Attachment #2: zzz.d --]
[-- Type: text/plain, Size: 2775 bytes --]
Index: configure
===================================================================
--- configure (revision 110136)
+++ configure (revision 110137)
@@ -9989,19 +9989,14 @@
echo "${ECHO_T}$ac_cv_lib_dl_dladdr" >&6
if test $ac_cv_lib_dl_dladdr = yes; then
- if test "x${disable_dladdr}" = "xyes"; then
- #Broken dladdr().
- true
- else
cat >>confdefs.h <<\_ACEOF
#define HAVE_DLADDR 1
_ACEOF
- fi
-
fi
+
if test x"$build" = x"$host"; then
echo "$as_me:$LINENO: checking for /proc/self/exe" >&5
echo $ECHO_N "checking for /proc/self/exe... $ECHO_C" >&6
Index: configure.host
===================================================================
--- configure.host (revision 110136)
+++ configure.host (revision 110137)
@@ -28,8 +28,6 @@
# pthread_self calls by caching thread IDs in a hashtable
# can_unwind_signal Set to "yes" if the EH unwinder supports throwing
# from a signal handler.
-# disable_dladdr Set to "yes" if dladdr should not be used
-# (i.e it is broken).
# fallback_backtrace_h Header to use for fallback backtrace implementation
# (only for targets that don't support DWARF2 unwind)
# descriptor_h Header to use for looking past function descriptors
@@ -44,7 +42,6 @@
sysdeps_dir=generic
slow_pthread_self=
can_unwind_signal=no
-disable_dladdr=
fallback_backtrace_h=sysdep/generic/backtrace.h
case "${target_optspace}:${host}" in
@@ -251,7 +248,6 @@
case "${host}" in
mipsel*-linux* | mipsisa32el*-linux*)
enable_hash_synchronization_default=yes
- disable_dladdr=yes
;;
esac
;;
Index: configure.ac
===================================================================
--- configure.ac (revision 110136)
+++ configure.ac (revision 110137)
@@ -901,13 +901,8 @@
AC_CHECK_FUNCS(inet_aton inet_addr, break)
AC_CHECK_HEADERS(execinfo.h unistd.h dlfcn.h)
AC_CHECK_LIB(dl, dladdr, [
- if test "x${disable_dladdr}" = "xyes"; then
- #Broken dladdr().
- true
- else
- AC_DEFINE(HAVE_DLADDR, 1, [Define if you have dladdr()])
- fi
- ])
+ AC_DEFINE(HAVE_DLADDR, 1, [Define if you have dladdr()])])
+
if test x"$build" = x"$host"; then
AC_CHECK_FILES(/proc/self/exe, [
AC_DEFINE(HAVE_PROC_SELF_EXE, 1, [Define if you have /proc/self/exe])])
Index: include/config.h.in
===================================================================
--- include/config.h.in (revision 110136)
+++ include/config.h.in (revision 110137)
@@ -49,9 +49,6 @@
/* Define to 1 if you have the <arpa/inet.h> header file. */
#undef HAVE_ARPA_INET_H
-/* Define if your platform has a working backtrace() function. */
-#undef HAVE_BACKTRACE
-
/* Define if Boehm GC in use. */
#undef HAVE_BOEHM_GC
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-01-23 18:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-01-18 0:53 Patch: Fix stacktrace line numbers for mipsel-linux David Daney
2006-01-18 19:09 ` Tom Tromey
2006-01-23 18:31 ` David Daney
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).