From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24503 invoked by alias); 20 Apr 2006 18:23:49 -0000 Received: (qmail 24486 invoked by uid 22791); 20 Apr 2006 18:23:48 -0000 X-Spam-Check-By: sourceware.org Received: from exsmtp02.agrinet.ch (HELO exsmtp02.agrinet.ch) (81.221.252.201) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 20 Apr 2006 18:23:46 +0000 Received: from smtp.messaging.ch ([10.50.250.214]) by exsmtp02.agrinet.ch with Microsoft SMTPSVC(6.0.3790.211); Thu, 20 Apr 2006 20:23:43 +0200 Received: from [192.168.225.5] ([80.219.227.180]) by smtp.messaging.ch with id PWQA1U0013uA8oG0000000 for green@redhat.com; Thu, 20 Apr 2006 20:24:10 +0200 X-IMP: RBL SBL+XBL: 0.00,RBL SPAMCOP: 0.00,RBL SORBS: 0.10,RBL MAPS_ORDB: 0.00,URL RHS: 0.00,URL SURBL: 0.00 Message-ID: <4447D1AD.4020805@pop.agri.ch> Date: Thu, 20 Apr 2006 18:23:00 -0000 From: Andreas Tobler User-Agent: Thunderbird 1.5 (Macintosh/20051201) MIME-Version: 1.0 To: Andrew Haley CC: Java Patches , GCC Patches , Tom Tromey , Anthony Green Subject: Re: [patch] RFT, remove of lint directives in libffi References: <4446AABB.7000506@pop.agri.ch> <17479.20684.32340.630812@zapata.pink> <4447A3FB.8030502@pop.agri.ch> <17479.42252.644738.919081@zapata.pink> In-Reply-To: <17479.42252.644738.919081@zapata.pink> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact java-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: java-patches-owner@gcc.gnu.org X-SW-Source: 2006-q2/txt/msg00082.txt.bz2 Andrew Haley wrote: > Andreas Tobler writes: > > Andrew Haley wrote: > > > Andreas Tobler writes: > > > > > > > > I need some testers here. > > > > This patch tries to remove the lint directives from the libffi code. > > > > As far as I am aware, nobody uses this directives. So, I think for code > > > > cleanness it would be a first step to remove these. > > > > > > > > I can test on powerpc-linux, darwin, solaris and hp-ux. I do not expect > > > > a fallout, but to be sure it would be nice to have some more tests. > > > > > > > > The patch is against trunk. > > > > > > > > If tests go fine, ok for trunk? > > > > > > This patch also deletes ffitest.c. > > > > Yes, I mentioned it in the CL. > > With no explanation at all! :-) Hm, you're right. It was totally clear for me since I did it a long time ago. Sorry. Andreas 2006-04-20 Andreas Tobler * README: Remove notice about 'Crazy Comments'. * src/debug.c: Remove lint directives. Cleanup white spaces. * src/java_raw_api.c: Likewise. * src/prep_cif.c: Likewise. * src/raw_api.c: Likewise. * src/ffitest.c: Delete. No longer needed, all test cases migrated to the testsuite. * src/arm/ffi.c: Remove lint directives. * src/m32r/ffi.c: Likewise. * src/pa/ffi.c: Likewise. * src/powerpc/ffi.c: Likewise. * src/powerpc/ffi_darwin.c: Likewise. * src/sh/ffi.c: Likewise. * src/sh64/ffi.c: Likewise. * src/x86/ffi.c: Likewise. * testsuite/libffi.call/float2.c: Likewise. * testsuite/libffi.call/promotion.c: Likewise. * testsuite/libffi.call/struct1.c: Likewise.