From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30773 invoked by alias); 22 Jun 2006 14:53:01 -0000 Received: (qmail 30757 invoked by uid 22791); 22 Jun 2006 14:53:00 -0000 X-Spam-Check-By: sourceware.org Received: from potter.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 22 Jun 2006 14:53:00 +0000 Received: (qmail 10717 invoked from network); 22 Jun 2006 14:52:58 -0000 Received: from unknown (HELO ?192.168.0.2?) (mitchell@127.0.0.2) by mail.codesourcery.com with ESMTPA; 22 Jun 2006 14:52:58 -0000 Message-ID: <449AAEC0.8000407@codesourcery.com> Date: Thu, 22 Jun 2006 14:53:00 -0000 From: Mark Mitchell User-Agent: Thunderbird 1.5.0.4 (Windows/20060516) MIME-Version: 1.0 To: Andrew Haley CC: Volker Reichelt , gcc-patches@gcc.gnu.org, java-patches@gcc.gnu.org Subject: Re: [patch] Fix PR c++/java 11006: ICE on missing class$ References: <17562.35019.223360.342743@dell.pink> In-Reply-To: <17562.35019.223360.342743@dell.pink> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact java-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: java-patches-owner@gcc.gnu.org X-SW-Source: 2006-q2/txt/msg00465.txt.bz2 Andrew Haley wrote: > Volker Reichelt writes: > > In build_java_class_ref in cp/init.c we have > > > > if (jclass_node == NULL_TREE) > > fatal_error ("call to Java constructor, while % undefined"); > > > > and > > > > if (!field) > > internal_error ("can't find class$"); > > > > Is there are reason why we don't emit a regular error and return > > error_mark_node in these cases? Both conditions can be triggered > > with user errors (see testcases below) and should be treated as > > regular errors IMHO. > > That seems reasonable to me. Me too. That change is pre-approved. -- Mark Mitchell CodeSourcery mark@codesourcery.com (650) 331-3385 x713