From: Bryce McKinlay <mckinlay@redhat.com>
To: Ranjit Mathew <rmathew@gmail.com>
Cc: java-patches@gcc.gnu.org
Subject: Re: [MinGW] RFA: Make Stack Traces Work for Interpreted Code on Windows
Date: Wed, 12 Jul 2006 20:05:00 -0000 [thread overview]
Message-ID: <44B555F0.300@redhat.com> (raw)
In-Reply-To: <44B53154.6030402@gmail.com>
Ranjit Mathew wrote:
>> I think you could just overload them with #defines in backtrace.h?
>> Failing that, I think that adding a couple of #ifdef's in UnwindTraceFn
>> is not as bad as the code duplication.
>>
>
> That worked pretty nicely, thank you. It reduces unnecessary
> duplication of code too. The attached patch implements it and
> was tested using a crossed-native compiler for i686-pc-mingw32.
> I still get usable stack traces for compiled and interpreted
> code.
>
> OK?
>
It occurs to me that you could now actually #define fallback_backtrace
as _Unwind_Backtrace, and get rid of some #ifdefs in stacktrace.cc. Do
you think that is worth doing? Otherwise, this is OK for trunk.
Bryce
next prev parent reply other threads:[~2006-07-12 20:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-09 9:19 Ranjit Mathew
2006-07-11 17:59 ` Bryce McKinlay
2006-07-11 18:34 ` Ranjit Mathew
2006-07-11 21:34 ` Bryce McKinlay
2006-07-12 17:28 ` Ranjit Mathew
2006-07-12 20:05 ` Bryce McKinlay [this message]
2006-07-14 17:26 ` Ranjit Mathew
2006-07-12 20:10 ` Bryce McKinlay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44B555F0.300@redhat.com \
--to=mckinlay@redhat.com \
--cc=java-patches@gcc.gnu.org \
--cc=rmathew@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).