[RFA/JDWP] VMVirtualMachine.initialize

[RFA/JDWP] VMVirtualMachine.initialize

[Keith Seitz]

[-- Attachment #1: Type: text/plain, Size: 541 bytes --]

Hi,

This patch adds an initialize method to classpath's VMVirtualMachine so 
that we can save off the JVMTI environment for future use. [Question: Do 
I need to add some sort of "LOCAL" comment around it?]

After this, I can finally submit a prims.cc patch to implement JDWP startup.

Keith

ChangeLog
2006-08-23  Keith Seitz  <keiths@redhat.com>

         * gnu/classpath/jdwp/VMVirtualMachine.java
         (initialize): Declare.
         * gnu/classpath/jdwp/natVMVirtualMachine.cc
         (initialize): Get and save JVMTI environment.

[-- Attachment #2: VMVM-initialize.patch --]
[-- Type: text/x-patch, Size: 1227 bytes --]

Index: gnu/classpath/jdwp/VMVirtualMachine.java
===================================================================
--- gnu/classpath/jdwp/VMVirtualMachine.java	(revision 116306)
+++ gnu/classpath/jdwp/VMVirtualMachine.java	(working copy)
@@ -57,6 +57,8 @@
  */
 public class VMVirtualMachine
 {
+  public static native void initialize ();
+
   /**
    * Suspend a thread
    *
Index: gnu/classpath/jdwp/natVMVirtualMachine.cc
===================================================================
--- gnu/classpath/jdwp/natVMVirtualMachine.cc	(revision 116306)
+++ gnu/classpath/jdwp/natVMVirtualMachine.cc	(working copy)
@@ -10,6 +10,8 @@
 
 #include <config.h>
 #include <gcj/cni.h>
+#include <jvm.h>
+#include <jvmti.h>
 
 #include <java/lang/Class.h>
 #include <java/lang/ClassLoader.h>
@@ -28,7 +30,17 @@
 using namespace gnu::classpath::jdwp::event;
 using namespace gnu::classpath::jdwp::util;
 
+// JVMTI environment
+static jvmtiEnv *_jdwp_jvmtiEnv;
+
 void
+gnu::classpath::jdwp::VMVirtualMachine::initialize ()
+{
+  JavaVM *vm = _Jv_GetJavaVM ();
+  vm->GetEnv (reinterpret_cast<void **> (&_jdwp_jvmtiEnv), JVMTI_VERSION_1_0);
+}
+
+void
 gnu::classpath::jdwp::VMVirtualMachine ::suspendThread (Thread *thread)
 {
 }

Re: [RFA/JDWP] VMVirtualMachine.initialize

[Tom Tromey]

>>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes:

Keith> This patch adds an initialize method to classpath's VMVirtualMachine
Keith> so that we can save off the JVMTI environment for future
Keith> use. [Question: Do I need to add some sort of "LOCAL" comment around
Keith> it?]

You don't need one -- the VM classes are all VM-local by definition.

Keith> After this, I can finally submit a prims.cc patch to implement
Keith> JDWP startup.

Awesome.

Tom

Re: [RFA/JDWP] VMVirtualMachine.initialize

[Keith Seitz]

Tom Tromey wrote:
>>>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes:
> 
> Keith> This patch adds an initialize method to classpath's VMVirtualMachine
> Keith> so that we can save off the JVMTI environment for future
> Keith> use. [Question: Do I need to add some sort of "LOCAL" comment around
> Keith> it?]
> 
> You don't need one -- the VM classes are all VM-local by definition.

Done. Thanks.

> Keith> After this, I can finally submit a prims.cc patch to implement
> Keith> JDWP startup.
> 
> Awesome.

Coming right up!

Keith