* [Patch] No special treatment for boehm-gc when cross compiling.
@ 2007-01-17 22:49 David Daney
2007-01-17 22:52 ` Tom Tromey
0 siblings, 1 reply; 2+ messages in thread
From: David Daney @ 2007-01-17 22:49 UTC (permalink / raw)
To: Java Patch List
[-- Attachment #1: Type: text/plain, Size: 692 bytes --]
This is a precursor for the heap dump support I will submit shortly.
The upstream GC sources already do the same thing.
I think Tom Tromey may have already oked this patch, but I can't find
anything to confirm that, so I am submitting it again.
The heap dump code uses the GC interfaces that are disabled when cross
compiling. Under the principle that cross compiles should not differ
from native builds, I removed this disabling code.
Tested on x86_64-linux.
OK to commit?
2007-01-17 David Daney <ddaney@avtrex.com>
* configure.ac: Don't define NO_SIGSET and NO_DEBUGGING while
cross-compiling.
* configure: Regenerated.
* include/gc_config.h.in: Regenerated.
[-- Attachment #2: boehm-gc.diff.txt --]
[-- Type: text/plain, Size: 866 bytes --]
Index: boehm-gc/configure.ac
===================================================================
--- boehm-gc/configure.ac (revision 120765)
+++ boehm-gc/configure.ac (working copy)
@@ -488,14 +488,6 @@ AC_DEFINE(JAVA_FINALIZATION,1,[make it s
AC_DEFINE(GC_GCJ_SUPPORT,1,[include support for gcj])
AC_DEFINE(ATOMIC_UNCOLLECTABLE,1,[include code for GC_malloc_atomic_uncollectable])
-dnl This is something of a hack. When cross-compiling we turn off
-dnl some functionality. These is only correct when targetting an
-dnl embedded system. FIXME.
-if test -n "${with_cross_host}"; then
- AC_DEFINE(NO_SIGSET,1,[use empty GC_disable_signals and GC_enable_signals])
- AC_DEFINE(NO_DEBUGGING,1,[removes GC_dump])
-fi
-
AC_ARG_ENABLE(gc-debug,
[ --enable-gc-debug include full support for pointer backtracing etc.],
[ if test "$enable_gc_debug" = "yes"; then
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [Patch] No special treatment for boehm-gc when cross compiling.
2007-01-17 22:49 [Patch] No special treatment for boehm-gc when cross compiling David Daney
@ 2007-01-17 22:52 ` Tom Tromey
0 siblings, 0 replies; 2+ messages in thread
From: Tom Tromey @ 2007-01-17 22:52 UTC (permalink / raw)
To: David Daney; +Cc: Java Patch List
>>>>> "David" == David Daney <ddaney@avtrex.com> writes:
David> This is a precursor for the heap dump support I will submit shortly.
David> The upstream GC sources already do the same thing.
This is ok. Thanks.
Tom
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-01-17 22:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-01-17 22:49 [Patch] No special treatment for boehm-gc when cross compiling David Daney
2007-01-17 22:52 ` Tom Tromey
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).